[INFO] updating cached repository jaemk/rc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaemk/rc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/rc" "work/ex/clippy-test-run/sources/stable/gh/jaemk/rc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaemk/rc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/rc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/rc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/rc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 99889f4e93817f951eb23df1b5f46280009f0206 [INFO] sha for GitHub repo jaemk/rc: 99889f4e93817f951eb23df1b5f46280009f0206 [INFO] validating manifest of jaemk/rc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaemk/rc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaemk/rc [INFO] finished frobbing jaemk/rc [INFO] frobbed toml for jaemk/rc written to work/ex/clippy-test-run/sources/stable/gh/jaemk/rc/Cargo.toml [INFO] started frobbing jaemk/rc [INFO] finished frobbing jaemk/rc [INFO] frobbed toml for jaemk/rc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/rc/Cargo.toml [INFO] crate jaemk/rc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaemk/rc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaemk/rc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6b73b0bafddef31f8205a554c658162ce69fe51752a1fa85b16a41336c63d760 [INFO] running `"docker" "start" "-a" "6b73b0bafddef31f8205a554c658162ce69fe51752a1fa85b16a41336c63d760"` [INFO] [stderr] Checking num-complex v0.1.37 [INFO] [stderr] Checking clap v2.23.3 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking rc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &Value::Num(ref n) => { [INFO] [stderr] 49 | | write!(f, "", n) [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | Value::Num(ref n) => { [INFO] [stderr] 49 | write!(f, "", n) [INFO] [stderr] 50 | } [INFO] [stderr] 51 | Value::Str(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Env` [INFO] [stderr] --> src/lib.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | / pub fn new() -> Env { [INFO] [stderr] 169 | | Env { stack: Stack::new(), buffers: HashMap::new() } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | impl Default for Env { [INFO] [stderr] 168 | fn default() -> Self { [INFO] [stderr] 169 | Self::new() [INFO] [stderr] 170 | } [INFO] [stderr] 171 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:194:26 [INFO] [stderr] | [INFO] [stderr] 194 | .expect(&format!("Error parsing token: {:?}", token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error parsing token: {:?}", token))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &Value::Num(ref n) => { [INFO] [stderr] 49 | | write!(f, "", n) [INFO] [stderr] 50 | | } [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | Value::Num(ref n) => { [INFO] [stderr] 49 | write!(f, "", n) [INFO] [stderr] 50 | } [INFO] [stderr] 51 | Value::Str(ref s) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Env` [INFO] [stderr] --> src/lib.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | / pub fn new() -> Env { [INFO] [stderr] 169 | | Env { stack: Stack::new(), buffers: HashMap::new() } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | impl Default for Env { [INFO] [stderr] 168 | fn default() -> Self { [INFO] [stderr] 169 | Self::new() [INFO] [stderr] 170 | } [INFO] [stderr] 171 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:194:26 [INFO] [stderr] | [INFO] [stderr] 194 | .expect(&format!("Error parsing token: {:?}", token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error parsing token: {:?}", token))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.94s [INFO] running `"docker" "inspect" "6b73b0bafddef31f8205a554c658162ce69fe51752a1fa85b16a41336c63d760"` [INFO] running `"docker" "rm" "-f" "6b73b0bafddef31f8205a554c658162ce69fe51752a1fa85b16a41336c63d760"` [INFO] [stdout] 6b73b0bafddef31f8205a554c658162ce69fe51752a1fa85b16a41336c63d760