[INFO] updating cached repository jaemk/notify-hook [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jaemk/notify-hook [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/notify-hook" "work/ex/clippy-test-run/sources/stable/gh/jaemk/notify-hook"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jaemk/notify-hook'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jaemk/notify-hook" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/notify-hook"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/notify-hook'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7afad84a573f115ef6c3eab371b2212244e97c9f [INFO] sha for GitHub repo jaemk/notify-hook: 7afad84a573f115ef6c3eab371b2212244e97c9f [INFO] validating manifest of jaemk/notify-hook on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jaemk/notify-hook on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jaemk/notify-hook [INFO] finished frobbing jaemk/notify-hook [INFO] frobbed toml for jaemk/notify-hook written to work/ex/clippy-test-run/sources/stable/gh/jaemk/notify-hook/Cargo.toml [INFO] started frobbing jaemk/notify-hook [INFO] finished frobbing jaemk/notify-hook [INFO] frobbed toml for jaemk/notify-hook written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jaemk/notify-hook/Cargo.toml [INFO] crate jaemk/notify-hook has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jaemk/notify-hook against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jaemk/notify-hook:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d77e59f737e5fad32c0baf812bd198aff05eff50258190ee087a17d3bc8e0223 [INFO] running `"docker" "start" "-a" "d77e59f737e5fad32c0baf812bd198aff05eff50258190ee087a17d3bc8e0223"` [INFO] [stderr] Compiling rustc-demangle v0.1.7 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Compiling serde_json v1.0.10 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.0 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking libz-sys v1.0.18 [INFO] [stderr] Compiling backtrace v0.3.5 [INFO] [stderr] Checking mio v0.6.13 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling tempdir v0.3.6 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking serde_qs v0.3.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Checking hyper v0.11.20 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking git2 v0.7.0 [INFO] [stderr] Checking notify-hook v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | commits: commits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `commits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/payload.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | commits: commits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `commits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:60:72 [INFO] [stderr] | [INFO] [stderr] 60 | message: commit.message().map(String::from).unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:89:33 [INFO] [stderr] | [INFO] [stderr] 89 | .unwrap_or_else(|| String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:111:63 [INFO] [stderr] | [INFO] [stderr] 111 | name: sig.name().map(String::from).unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | email: sig.email().map(String::from).unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:206:39 [INFO] [stderr] | [INFO] [stderr] 206 | let parts = line.trim().split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | let commits = revwalk.into_iter().map(|rev| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `revwalk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:60:72 [INFO] [stderr] | [INFO] [stderr] 60 | message: commit.message().map(String::from).unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:89:33 [INFO] [stderr] | [INFO] [stderr] 89 | .unwrap_or_else(|| String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:111:63 [INFO] [stderr] | [INFO] [stderr] 111 | name: sig.name().map(String::from).unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/payload.rs:112:65 [INFO] [stderr] | [INFO] [stderr] 112 | email: sig.email().map(String::from).unwrap_or_else(|| String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:74:20 [INFO] [stderr] | [INFO] [stderr] 74 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:206:39 [INFO] [stderr] | [INFO] [stderr] 206 | let parts = line.trim().split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | let commits = revwalk.into_iter().map(|rev| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `revwalk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 35s [INFO] running `"docker" "inspect" "d77e59f737e5fad32c0baf812bd198aff05eff50258190ee087a17d3bc8e0223"` [INFO] running `"docker" "rm" "-f" "d77e59f737e5fad32c0baf812bd198aff05eff50258190ee087a17d3bc8e0223"` [INFO] [stdout] d77e59f737e5fad32c0baf812bd198aff05eff50258190ee087a17d3bc8e0223