[INFO] updating cached repository jacwah/oak [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jacwah/oak [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jacwah/oak" "work/ex/clippy-test-run/sources/stable/gh/jacwah/oak"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jacwah/oak'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jacwah/oak" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jacwah/oak"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jacwah/oak'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8cc41d56c6b66ceca1da6ff4ed14542673c50233 [INFO] sha for GitHub repo jacwah/oak: 8cc41d56c6b66ceca1da6ff4ed14542673c50233 [INFO] validating manifest of jacwah/oak on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jacwah/oak on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jacwah/oak [INFO] finished frobbing jacwah/oak [INFO] frobbed toml for jacwah/oak written to work/ex/clippy-test-run/sources/stable/gh/jacwah/oak/Cargo.toml [INFO] started frobbing jacwah/oak [INFO] finished frobbing jacwah/oak [INFO] frobbed toml for jacwah/oak written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jacwah/oak/Cargo.toml [INFO] crate jacwah/oak has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jacwah/oak against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jacwah/oak:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9065e2893bdb01539966afca6d04614aa06f2f2eb1182b139bc2049e28d276a9 [INFO] running `"docker" "start" "-a" "9065e2893bdb01539966afca6d04614aa06f2f2eb1182b139bc2049e28d276a9"` [INFO] [stderr] Checking matches v0.1.3 [INFO] [stderr] Compiling libz-sys v1.0.6 [INFO] [stderr] Compiling cmake v0.1.18 [INFO] [stderr] Checking clap v2.16.2 [INFO] [stderr] Checking globset v0.1.2 [INFO] [stderr] Checking unicode-bidi v0.2.3 [INFO] [stderr] Compiling libgit2-sys v0.5.1 [INFO] [stderr] Checking idna v0.1.0 [INFO] [stderr] Checking url v1.2.2 [INFO] [stderr] Checking git2 v0.5.0 [INFO] [stderr] Checking oak v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/print_processor.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | file_filter: file_filter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | has_next_sibling: has_next_sibling, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_next_sibling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | invert: invert [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `invert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters.rs:146:43 [INFO] [stderr] | [INFO] [stderr] 146 | .map(|repo| GitignoreFilter { repo: repo }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/print_processor.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | file_filter: file_filter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:195:9 [INFO] [stderr] | [INFO] [stderr] 195 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | has_next_sibling: has_next_sibling, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_next_sibling` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | invert: invert [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `invert` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/filters.rs:146:43 [INFO] [stderr] | [INFO] [stderr] 146 | .map(|repo| GitignoreFilter { repo: repo }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | Err(err) => return Some(Err(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:182:43 [INFO] [stderr] | [INFO] [stderr] 182 | Some(Err(err)) => return Some(Err(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/tree.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | / loop { [INFO] [stderr] 207 | | match self.dir_stack.as_mut_slice().last_mut() { [INFO] [stderr] 208 | | Some(dir) => { [INFO] [stderr] 209 | | match next_entry(dir) { [INFO] [stderr] ... | [INFO] [stderr] 225 | | return Some(Ok(Event::CloseDir)); [INFO] [stderr] 226 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:231:45 [INFO] [stderr] | [INFO] [stderr] 231 | Err(err) => return Some(Err(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `oak`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | Err(err) => return Some(Err(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:182:43 [INFO] [stderr] | [INFO] [stderr] 182 | Some(Err(err)) => return Some(Err(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/tree.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | / loop { [INFO] [stderr] 207 | | match self.dir_stack.as_mut_slice().last_mut() { [INFO] [stderr] 208 | | Some(dir) => { [INFO] [stderr] 209 | | match next_entry(dir) { [INFO] [stderr] ... | [INFO] [stderr] 225 | | return Some(Ok(Event::CloseDir)); [INFO] [stderr] 226 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:231:45 [INFO] [stderr] | [INFO] [stderr] 231 | Err(err) => return Some(Err(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `oak`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9065e2893bdb01539966afca6d04614aa06f2f2eb1182b139bc2049e28d276a9"` [INFO] running `"docker" "rm" "-f" "9065e2893bdb01539966afca6d04614aa06f2f2eb1182b139bc2049e28d276a9"` [INFO] [stdout] 9065e2893bdb01539966afca6d04614aa06f2f2eb1182b139bc2049e28d276a9