[INFO] updating cached repository jacobvaneijk/dmr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jacobvaneijk/dmr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jacobvaneijk/dmr" "work/ex/clippy-test-run/sources/stable/gh/jacobvaneijk/dmr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jacobvaneijk/dmr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jacobvaneijk/dmr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jacobvaneijk/dmr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jacobvaneijk/dmr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0c6d6be3c20f30371995b74866af4ecf4e77ac8 [INFO] sha for GitHub repo jacobvaneijk/dmr: b0c6d6be3c20f30371995b74866af4ecf4e77ac8 [INFO] validating manifest of jacobvaneijk/dmr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jacobvaneijk/dmr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jacobvaneijk/dmr [INFO] finished frobbing jacobvaneijk/dmr [INFO] frobbed toml for jacobvaneijk/dmr written to work/ex/clippy-test-run/sources/stable/gh/jacobvaneijk/dmr/Cargo.toml [INFO] started frobbing jacobvaneijk/dmr [INFO] finished frobbing jacobvaneijk/dmr [INFO] frobbed toml for jacobvaneijk/dmr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jacobvaneijk/dmr/Cargo.toml [INFO] crate jacobvaneijk/dmr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jacobvaneijk/dmr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jacobvaneijk/dmr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6535c318eba6e35740d8485bad16aaee239b1c634fb117738b59defdc74c7251 [INFO] running `"docker" "start" "-a" "6535c318eba6e35740d8485bad16aaee239b1c634fb117738b59defdc74c7251"` [INFO] [stderr] Checking dmr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | Ok(_) => return Ok(src), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(src)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Err(why) => return Err(why.description().to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(why.description().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let output = match matches.opt_str("o") { [INFO] [stderr] | ^^^^^^ help: consider using `_output` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/driver.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut src = match read_file(filename) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | Ok(_) => return Ok(src), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(src)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Err(why) => return Err(why.description().to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(why.description().to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `output` [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let output = match matches.opt_str("o") { [INFO] [stderr] | ^^^^^^ help: consider using `_output` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/driver.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let mut src = match read_file(filename) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "6535c318eba6e35740d8485bad16aaee239b1c634fb117738b59defdc74c7251"` [INFO] running `"docker" "rm" "-f" "6535c318eba6e35740d8485bad16aaee239b1c634fb117738b59defdc74c7251"` [INFO] [stdout] 6535c318eba6e35740d8485bad16aaee239b1c634fb117738b59defdc74c7251