[INFO] updating cached repository jackyzhen/rustian-roulette [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jackyzhen/rustian-roulette [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jackyzhen/rustian-roulette" "work/ex/clippy-test-run/sources/stable/gh/jackyzhen/rustian-roulette"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jackyzhen/rustian-roulette'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jackyzhen/rustian-roulette" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackyzhen/rustian-roulette"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackyzhen/rustian-roulette'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2143b3280c42308f8b65e36b0d6749e58793c47 [INFO] sha for GitHub repo jackyzhen/rustian-roulette: f2143b3280c42308f8b65e36b0d6749e58793c47 [INFO] validating manifest of jackyzhen/rustian-roulette on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jackyzhen/rustian-roulette on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jackyzhen/rustian-roulette [INFO] finished frobbing jackyzhen/rustian-roulette [INFO] frobbed toml for jackyzhen/rustian-roulette written to work/ex/clippy-test-run/sources/stable/gh/jackyzhen/rustian-roulette/Cargo.toml [INFO] started frobbing jackyzhen/rustian-roulette [INFO] finished frobbing jackyzhen/rustian-roulette [INFO] frobbed toml for jackyzhen/rustian-roulette written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackyzhen/rustian-roulette/Cargo.toml [INFO] crate jackyzhen/rustian-roulette has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jackyzhen/rustian-roulette against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jackyzhen/rustian-roulette:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 206dbf810c3502ad648f1d253e0414315f0ce634f49147df258c54561adb3a23 [INFO] running `"docker" "start" "-a" "206dbf810c3502ad648f1d253e0414315f0ce634f49147df258c54561adb3a23"` [INFO] [stderr] Checking rustian-roulette v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | '\u{1F52B}', [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | '\u{1F525}', [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/printer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | print!("{}\n", " ".repeat(100)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:40 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:41 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:54 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | '\u{1F52B}', [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | '\u{1F525}', [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/printer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | print!("{}\n", " ".repeat(100)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:40 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | '\u{271D}', '\u{1F480}', file, '\u{1F480}', '\u{271D}' [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:41 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/printer.rs:63:54 [INFO] [stderr] | [INFO] [stderr] 63 | '\u{1F340}', '\u{1F340}', file, '\u{1F340}', '\u{1F340}' [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/cmd.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | let home = env::home_dir().expect("could not get home dir"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/cmd.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | let home = env::home_dir().expect("could not get home dir"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | fn parse_args(args: &Vec) -> HashMap<&str, &str> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/cmd.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | if let Ok(_) = arg.parse::() { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 64 | | map.entry(CHAMBER_ARG).or_insert(arg); [INFO] [stderr] 65 | | } else { [INFO] [stderr] 66 | | map.entry(PATH_ARG).or_insert(arg); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________- help: try this: `if arg.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/printer.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | match input.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `input.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if contents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | fn parse_args(args: &Vec) -> HashMap<&str, &str> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd.rs:49:28 [INFO] [stderr] | [INFO] [stderr] 49 | if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/cmd.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | if let Ok(_) = arg.parse::() { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 64 | | map.entry(CHAMBER_ARG).or_insert(arg); [INFO] [stderr] 65 | | } else { [INFO] [stderr] 66 | | map.entry(PATH_ARG).or_insert(arg); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________- help: try this: `if arg.parse::().is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/printer.rs:14:11 [INFO] [stderr] | [INFO] [stderr] 14 | match input.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `input.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if contents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.95s [INFO] running `"docker" "inspect" "206dbf810c3502ad648f1d253e0414315f0ce634f49147df258c54561adb3a23"` [INFO] running `"docker" "rm" "-f" "206dbf810c3502ad648f1d253e0414315f0ce634f49147df258c54561adb3a23"` [INFO] [stdout] 206dbf810c3502ad648f1d253e0414315f0ce634f49147df258c54561adb3a23