[INFO] updating cached repository jackdeansmith/idastar [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jackdeansmith/idastar [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jackdeansmith/idastar" "work/ex/clippy-test-run/sources/stable/gh/jackdeansmith/idastar"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jackdeansmith/idastar'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jackdeansmith/idastar" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackdeansmith/idastar"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackdeansmith/idastar'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8593bdaa14d2d5246aa73cad9c9992fd61c5487a [INFO] sha for GitHub repo jackdeansmith/idastar: 8593bdaa14d2d5246aa73cad9c9992fd61c5487a [INFO] validating manifest of jackdeansmith/idastar on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jackdeansmith/idastar on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jackdeansmith/idastar [INFO] finished frobbing jackdeansmith/idastar [INFO] frobbed toml for jackdeansmith/idastar written to work/ex/clippy-test-run/sources/stable/gh/jackdeansmith/idastar/Cargo.toml [INFO] started frobbing jackdeansmith/idastar [INFO] finished frobbing jackdeansmith/idastar [INFO] frobbed toml for jackdeansmith/idastar written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jackdeansmith/idastar/Cargo.toml [INFO] crate jackdeansmith/idastar has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jackdeansmith/idastar against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jackdeansmith/idastar:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a25b90d1573c6a601904f2a2274f4c87cd421ffa373fb1cf4a578059b38ad787 [INFO] running `"docker" "start" "-a" "a25b90d1573c6a601904f2a2274f4c87cd421ffa373fb1cf4a578059b38ad787"` [INFO] [stderr] Checking idastar v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | self == &1000000u64 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | MoveIter{number: self.clone(), direction: Some(Direction::Left)} [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match moves{ [INFO] [stderr] 56 | | Some(vector) => println!("Moves: {:?}", vector), [INFO] [stderr] 57 | | None => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(vector) = moves { println!("Moves: {:?}", vector) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | self == &1000000u64 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | MoveIter{number: self.clone(), direction: Some(Direction::Left)} [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / match moves{ [INFO] [stderr] 56 | | Some(vector) => println!("Moves: {:?}", vector), [INFO] [stderr] 57 | | None => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(vector) = moves { println!("Moves: {:?}", vector) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "a25b90d1573c6a601904f2a2274f4c87cd421ffa373fb1cf4a578059b38ad787"` [INFO] running `"docker" "rm" "-f" "a25b90d1573c6a601904f2a2274f4c87cd421ffa373fb1cf4a578059b38ad787"` [INFO] [stdout] a25b90d1573c6a601904f2a2274f4c87cd421ffa373fb1cf4a578059b38ad787