[INFO] updating cached repository jD91mZM2/termwm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jD91mZM2/termwm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jD91mZM2/termwm" "work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/termwm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/termwm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jD91mZM2/termwm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/termwm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/termwm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b62580e2e6a8c1a5895f84db4b0a73dff36e339 [INFO] sha for GitHub repo jD91mZM2/termwm: 0b62580e2e6a8c1a5895f84db4b0a73dff36e339 [INFO] validating manifest of jD91mZM2/termwm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jD91mZM2/termwm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jD91mZM2/termwm [INFO] finished frobbing jD91mZM2/termwm [INFO] frobbed toml for jD91mZM2/termwm written to work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/termwm/Cargo.toml [INFO] started frobbing jD91mZM2/termwm [INFO] finished frobbing jD91mZM2/termwm [INFO] frobbed toml for jD91mZM2/termwm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/termwm/Cargo.toml [INFO] crate jD91mZM2/termwm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jD91mZM2/termwm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/termwm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7557a830cc96d2bf4336613cba452856835f14f63d4c38dd367146841d90c90c [INFO] running `"docker" "start" "-a" "7557a830cc96d2bf4336613cba452856835f14f63d4c38dd367146841d90c90c"` [INFO] [stderr] Checking utf8parse v0.1.1 [INFO] [stderr] Checking pseudoterm v0.1.1 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking vte v0.3.3 [INFO] [stderr] Checking ransid v0.4.6 [INFO] [stderr] Compiling synstructure v0.10.0 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking termwm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/buffer.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | write!(w, "\x1b[{};{}H", y+1, x+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/buffer.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | write!(w, "\x1b[{};{}H", y+1, x+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | width = (self.inner.width as i32 + (self.inner.x as i32 - x as i32)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.inner.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:97:53 [INFO] [stderr] | [INFO] [stderr] 97 | width = (self.inner.width as i32 + (self.inner.x as i32 - x as i32)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.inner.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:97:75 [INFO] [stderr] | [INFO] [stderr] 97 | width = (self.inner.width as i32 + (self.inner.x as i32 - x as i32)) as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | width = (self.inner.width as i32 + (self.inner.x as i32 - x as i32)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.inner.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:97:53 [INFO] [stderr] | [INFO] [stderr] 97 | width = (self.inner.width as i32 + (self.inner.x as i32 - x as i32)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.inner.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/window.rs:97:75 [INFO] [stderr] | [INFO] [stderr] 97 | width = (self.inner.width as i32 + (self.inner.x as i32 - x as i32)) as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/window.rs:276:69 [INFO] [stderr] | [INFO] [stderr] 276 | *self.get(from_x + rel_x, from_y + rel_y) = self.get(to_x + rel_x, to_y + rel_y).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.get(to_x + rel_x, to_y + rel_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/window.rs:276:69 [INFO] [stderr] | [INFO] [stderr] 276 | *self.get(from_x + rel_x, from_y + rel_y) = self.get(to_x + rel_x, to_y + rel_y).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.get(to_x + rel_x, to_y + rel_y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/workspace.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | let x = (x.saturating_sub(0o40 + 1) as u16).min(self.buffer.width-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(x.saturating_sub(0o40 + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/workspace.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | let y = (y.saturating_sub(0o40 + 1) as u16).min(self.buffer.height-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(y.saturating_sub(0o40 + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/workspace.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | let x = (x.saturating_sub(0o40 + 1) as u16).min(self.buffer.width-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(x.saturating_sub(0o40 + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/workspace.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | let y = (y.saturating_sub(0o40 + 1) as u16).min(self.buffer.height-1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(y.saturating_sub(0o40 + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | .unwrap_or(Cow::Borrowed(OsStr::new("bash"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Cow::Borrowed(OsStr::new("bash")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | let shell: Cow = env::args_os().skip(1) [INFO] [stderr] | _____________________________^ [INFO] [stderr] 85 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | .unwrap_or(Cow::Borrowed(OsStr::new("bash"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Cow::Borrowed(OsStr::new("bash")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | let shell: Cow = env::args_os().skip(1) [INFO] [stderr] | _____________________________^ [INFO] [stderr] 85 | | .next() [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.16s [INFO] running `"docker" "inspect" "7557a830cc96d2bf4336613cba452856835f14f63d4c38dd367146841d90c90c"` [INFO] running `"docker" "rm" "-f" "7557a830cc96d2bf4336613cba452856835f14f63d4c38dd367146841d90c90c"` [INFO] [stdout] 7557a830cc96d2bf4336613cba452856835f14f63d4c38dd367146841d90c90c