[INFO] updating cached repository jD91mZM2/numcoder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jD91mZM2/numcoder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jD91mZM2/numcoder" "work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/numcoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/numcoder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jD91mZM2/numcoder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/numcoder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/numcoder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 205e135c9a3f4f1f8a19df86b337ba0638fd67dc [INFO] sha for GitHub repo jD91mZM2/numcoder: 205e135c9a3f4f1f8a19df86b337ba0638fd67dc [INFO] validating manifest of jD91mZM2/numcoder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jD91mZM2/numcoder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jD91mZM2/numcoder [INFO] finished frobbing jD91mZM2/numcoder [INFO] frobbed toml for jD91mZM2/numcoder written to work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/numcoder/Cargo.toml [INFO] started frobbing jD91mZM2/numcoder [INFO] finished frobbing jD91mZM2/numcoder [INFO] frobbed toml for jD91mZM2/numcoder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/numcoder/Cargo.toml [INFO] crate jD91mZM2/numcoder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jD91mZM2/numcoder against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/numcoder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3cae315dd351343e7bbeac6bd74eab2f7df16ce6424c044c4f8480e6222647ff [INFO] running `"docker" "start" "-a" "3cae315dd351343e7bbeac6bd74eab2f7df16ce6424c044c4f8480e6222647ff"` [INFO] [stderr] Checking numcoder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | let numbers = numbers.iter().map(|n| *n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `numbers.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:55 [INFO] [stderr] | [INFO] [stderr] 99 | let input = input.trim().as_bytes().iter().map(|n| *n as u32); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | if text.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | if text.ends_with("]") { [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:142:26 [INFO] [stderr] | [INFO] [stderr] 142 | for token in text.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:157:3 [INFO] [stderr] | [INFO] [stderr] 157 | limit = limit >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `limit >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:168:11 [INFO] [stderr] | [INFO] [stderr] 168 | fn encode<'a, I>(numbers: I, limit: usize, length: usize, verbose: bool) -> Option [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | let numbers = numbers.iter().map(|n| *n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `numbers.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:99:55 [INFO] [stderr] | [INFO] [stderr] 99 | let input = input.trim().as_bytes().iter().map(|n| *n as u32); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:22 [INFO] [stderr] | [INFO] [stderr] 134 | if text.starts_with("[") { [INFO] [stderr] | ^^^ help: try using a char instead: `'['` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:137:20 [INFO] [stderr] | [INFO] [stderr] 137 | if text.ends_with("]") { [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:142:26 [INFO] [stderr] | [INFO] [stderr] 142 | for token in text.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:157:3 [INFO] [stderr] | [INFO] [stderr] 157 | limit = limit >> 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `limit >>= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:168:11 [INFO] [stderr] | [INFO] [stderr] 168 | fn encode<'a, I>(numbers: I, limit: usize, length: usize, verbose: bool) -> Option [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.66s [INFO] running `"docker" "inspect" "3cae315dd351343e7bbeac6bd74eab2f7df16ce6424c044c4f8480e6222647ff"` [INFO] running `"docker" "rm" "-f" "3cae315dd351343e7bbeac6bd74eab2f7df16ce6424c044c4f8480e6222647ff"` [INFO] [stdout] 3cae315dd351343e7bbeac6bd74eab2f7df16ce6424c044c4f8480e6222647ff