[INFO] updating cached repository jD91mZM2/generic-turing-machine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jD91mZM2/generic-turing-machine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jD91mZM2/generic-turing-machine" "work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/generic-turing-machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/generic-turing-machine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jD91mZM2/generic-turing-machine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/generic-turing-machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/generic-turing-machine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ad9ac7b01821364c0b3be26b5393463fff312f63 [INFO] sha for GitHub repo jD91mZM2/generic-turing-machine: ad9ac7b01821364c0b3be26b5393463fff312f63 [INFO] validating manifest of jD91mZM2/generic-turing-machine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jD91mZM2/generic-turing-machine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jD91mZM2/generic-turing-machine [INFO] finished frobbing jD91mZM2/generic-turing-machine [INFO] frobbed toml for jD91mZM2/generic-turing-machine written to work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/generic-turing-machine/Cargo.toml [INFO] started frobbing jD91mZM2/generic-turing-machine [INFO] finished frobbing jD91mZM2/generic-turing-machine [INFO] frobbed toml for jD91mZM2/generic-turing-machine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jD91mZM2/generic-turing-machine/Cargo.toml [INFO] crate jD91mZM2/generic-turing-machine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jD91mZM2/generic-turing-machine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jD91mZM2/generic-turing-machine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c85b3847181bc5ee51eb2cddb0192223d3fbefdcdc122e4a8209cc05614d829d [INFO] running `"docker" "start" "-a" "c85b3847181bc5ee51eb2cddb0192223d3fbefdcdc122e4a8209cc05614d829d"` [INFO] [stderr] Checking text_unit v0.1.5 [INFO] [stderr] Checking smol_str v0.1.7 [INFO] [stderr] Compiling syn v0.15.16 [INFO] [stderr] Checking rowan v0.1.1 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking generic-turing-machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/runner.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if -self.i - 1 >= self.head.len() as isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 83 | if -self.i > self.head.len() as isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | / if self.next() == Some('*') { [INFO] [stderr] 100 | | if self.next() == Some('/') { [INFO] [stderr] 101 | | ended = true; [INFO] [stderr] 102 | | break; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 99 | if self.next() == Some('*') && self.next() == Some('/') { [INFO] [stderr] 100 | ended = true; [INFO] [stderr] 101 | break; [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/runner.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if -self.i - 1 >= self.head.len() as isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 83 | if -self.i > self.head.len() as isize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tokenizer.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | / if self.next() == Some('*') { [INFO] [stderr] 100 | | if self.next() == Some('/') { [INFO] [stderr] 101 | | ended = true; [INFO] [stderr] 102 | | break; [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 99 | if self.next() == Some('*') && self.next() == Some('/') { [INFO] [stderr] 100 | ended = true; [INFO] [stderr] 101 | break; [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tokenizer.rs:122:41 [INFO] [stderr] | [INFO] [stderr] 122 | } else if !c.is_ascii() { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 123 | | Some((Token::Error, SmolStr::new(&start.input[start.offset..self.offset]))) [INFO] [stderr] 124 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tokenizer.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | if self.next()? != '\'' { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 121 | | Some((Token::Error, SmolStr::new(&start.input[start.offset..self.offset]))) [INFO] [stderr] 122 | | } else if !c.is_ascii() { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / let mut fail = false; [INFO] [stderr] 80 | | if node.kind() == Token::Error { [INFO] [stderr] 81 | | print_span(code, node.range()); [INFO] [stderr] 82 | | eprintln!("-> error: unexpected tokens"); [INFO] [stderr] 83 | | fail = true; [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let fail = if node.kind() == Token::Error { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `generic-turing-machine`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tokenizer.rs:122:41 [INFO] [stderr] | [INFO] [stderr] 122 | } else if !c.is_ascii() { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 123 | | Some((Token::Error, SmolStr::new(&start.input[start.offset..self.offset]))) [INFO] [stderr] 124 | | } else { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tokenizer.rs:120:41 [INFO] [stderr] | [INFO] [stderr] 120 | if self.next()? != '\'' { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 121 | | Some((Token::Error, SmolStr::new(&start.input[start.offset..self.offset]))) [INFO] [stderr] 122 | | } else if !c.is_ascii() { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / let mut fail = false; [INFO] [stderr] 80 | | if node.kind() == Token::Error { [INFO] [stderr] 81 | | print_span(code, node.range()); [INFO] [stderr] 82 | | eprintln!("-> error: unexpected tokens"); [INFO] [stderr] 83 | | fail = true; [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let fail = if node.kind() == Token::Error { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `generic-turing-machine`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c85b3847181bc5ee51eb2cddb0192223d3fbefdcdc122e4a8209cc05614d829d"` [INFO] running `"docker" "rm" "-f" "c85b3847181bc5ee51eb2cddb0192223d3fbefdcdc122e4a8209cc05614d829d"` [INFO] [stdout] c85b3847181bc5ee51eb2cddb0192223d3fbefdcdc122e4a8209cc05614d829d