[INFO] updating cached repository j16r/virtual68 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/j16r/virtual68 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/j16r/virtual68" "work/ex/clippy-test-run/sources/stable/gh/j16r/virtual68"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/j16r/virtual68'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/j16r/virtual68" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j16r/virtual68"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j16r/virtual68'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d6049874ca9e2565cb666b61d6c9f5cf01f8994e [INFO] sha for GitHub repo j16r/virtual68: d6049874ca9e2565cb666b61d6c9f5cf01f8994e [INFO] validating manifest of j16r/virtual68 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of j16r/virtual68 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing j16r/virtual68 [INFO] finished frobbing j16r/virtual68 [INFO] frobbed toml for j16r/virtual68 written to work/ex/clippy-test-run/sources/stable/gh/j16r/virtual68/Cargo.toml [INFO] started frobbing j16r/virtual68 [INFO] finished frobbing j16r/virtual68 [INFO] frobbed toml for j16r/virtual68 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j16r/virtual68/Cargo.toml [INFO] crate j16r/virtual68 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting j16r/virtual68 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/j16r/virtual68:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20d7988bb4281f16332bf14964a7881ab2f0564fa311acd72465333383dac3cf [INFO] running `"docker" "start" "-a" "20d7988bb4281f16332bf14964a7881ab2f0564fa311acd72465333383dac3cf"` [INFO] [stderr] Checking combine v1.3.0 [INFO] [stderr] Checking virtual68 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/grammar.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | command [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/grammar.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | let command = match token.as_ref() { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 16 | | "aba" => Command::ABA, [INFO] [stderr] 17 | | "adc" => Command::ADC, [INFO] [stderr] 18 | | "add" => Command::ADD, [INFO] [stderr] ... | [INFO] [stderr] 89 | | _ => panic!("unrecognized opcode '{}'", token), [INFO] [stderr] 90 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/grammar.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | command [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/grammar.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | let command = match token.as_ref() { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 16 | | "aba" => Command::ABA, [INFO] [stderr] 17 | | "adc" => Command::ADC, [INFO] [stderr] 18 | | "add" => Command::ADD, [INFO] [stderr] ... | [INFO] [stderr] 89 | | _ => panic!("unrecognized opcode '{}'", token), [INFO] [stderr] 90 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/linker.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | let mut program = Program::new(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_decimal` [INFO] [stderr] --> src/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn is_decimal(input: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/grammar.rs:128:49 [INFO] [stderr] | [INFO] [stderr] 128 | let instruction_no_operand = (opcode()).map(|opcode: Command| Instruction::OperandNone(opcode)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::OperandNone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/linker.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | fn opcode(command: &Command) -> Opcode { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/linker.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn assemble(program: &Program) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/machine.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / fn index<'a>(&'a self, i: u16) -> &'a u8 { [INFO] [stderr] 24 | | self.bytes.index(i as usize) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/machine.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / fn index_mut<'a>(&'a mut self, i: u16) -> &'a mut u8 { [INFO] [stderr] 30 | | self.bytes.index_mut(i as usize) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/machine.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | const CARRY_BORROW_FLAG: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:97:43 [INFO] [stderr] | [INFO] [stderr] 97 | let opcode = Opcode::from_i32(self.ram[self.ix] as i32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[self.ix])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:196:38 [INFO] [stderr] | [INFO] [stderr] 196 | let total: u16 = self.acca as u16 + self.accb as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.acca)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:196:57 [INFO] [stderr] | [INFO] [stderr] 196 | let total: u16 = self.acca as u16 + self.accb as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.accb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_decimal` [INFO] [stderr] --> src/grammar.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | fn is_decimal(input: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/grammar.rs:128:49 [INFO] [stderr] | [INFO] [stderr] 128 | let instruction_no_operand = (opcode()).map(|opcode: Command| Instruction::OperandNone(opcode)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Instruction::OperandNone` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/linker.rs:5:20 [INFO] [stderr] | [INFO] [stderr] 5 | fn opcode(command: &Command) -> Opcode { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/linker.rs:87:26 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn assemble(program: &Program) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/machine.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / fn index<'a>(&'a self, i: u16) -> &'a u8 { [INFO] [stderr] 24 | | self.bytes.index(i as usize) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/machine.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / fn index_mut<'a>(&'a mut self, i: u16) -> &'a mut u8 { [INFO] [stderr] 30 | | self.bytes.index_mut(i as usize) [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/machine.rs:71:31 [INFO] [stderr] | [INFO] [stderr] 71 | const CARRY_BORROW_FLAG: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:97:43 [INFO] [stderr] | [INFO] [stderr] 97 | let opcode = Opcode::from_i32(self.ram[self.ix] as i32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.ram[self.ix])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:196:38 [INFO] [stderr] | [INFO] [stderr] 196 | let total: u16 = self.acca as u16 + self.accb as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.acca)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:196:57 [INFO] [stderr] | [INFO] [stderr] 196 | let total: u16 = self.acca as u16 + self.accb as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.accb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.46s [INFO] running `"docker" "inspect" "20d7988bb4281f16332bf14964a7881ab2f0564fa311acd72465333383dac3cf"` [INFO] running `"docker" "rm" "-f" "20d7988bb4281f16332bf14964a7881ab2f0564fa311acd72465333383dac3cf"` [INFO] [stdout] 20d7988bb4281f16332bf14964a7881ab2f0564fa311acd72465333383dac3cf