[INFO] updating cached repository j0ni/rife [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/j0ni/rife [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/j0ni/rife" "work/ex/clippy-test-run/sources/stable/gh/j0ni/rife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/j0ni/rife'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/j0ni/rife" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j0ni/rife"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j0ni/rife'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0f9d0f9460a88d3df4190d3279573562a869873 [INFO] sha for GitHub repo j0ni/rife: e0f9d0f9460a88d3df4190d3279573562a869873 [INFO] validating manifest of j0ni/rife on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of j0ni/rife on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing j0ni/rife [INFO] finished frobbing j0ni/rife [INFO] frobbed toml for j0ni/rife written to work/ex/clippy-test-run/sources/stable/gh/j0ni/rife/Cargo.toml [INFO] started frobbing j0ni/rife [INFO] finished frobbing j0ni/rife [INFO] frobbed toml for j0ni/rife written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j0ni/rife/Cargo.toml [INFO] crate j0ni/rife has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting j0ni/rife against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/j0ni/rife:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5f49bafe6ce540af19a2ef5373f084e15b66bb712f02012017795a1512ddd49 [INFO] running `"docker" "start" "-a" "d5f49bafe6ce540af19a2ef5373f084e15b66bb712f02012017795a1512ddd49"` [INFO] [stderr] Checking stb_truetype v0.2.4 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking ordered-float v0.5.2 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking rife v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/board.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Debug, Clone, Eq, Hash, Copy)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/board.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40| / impl PartialEq for LCell { [INFO] [stderr] 41| | fn eq(&self, other: &LCell) -> bool { [INFO] [stderr] 42| | self.x == other.x && self.y == other.y [INFO] [stderr] 43| | } [INFO] [stderr] 44| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/board.rs:55:43 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn init(&mut self, initial_state: &Vec<(i32, i32)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, i32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | fn neighbours(&self, cell: &LCell) -> HashSet { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `LCell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:102:73 [INFO] [stderr] | [INFO] [stderr] 102 | } else if living_nb_cnt == 2 && self.state.contains(&c) { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 103 | | s.insert(c); [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:100:39 [INFO] [stderr] | [INFO] [stderr] 100 | if living_nb_cnt == 3 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 101 | | s.insert(c); [INFO] [stderr] 102 | | } else if living_nb_cnt == 2 && self.state.contains(&c) { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn init(&mut self, initial_state: &Vec<(i32, i32)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, i32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rife`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/board.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Debug, Clone, Eq, Hash, Copy)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/board.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40| / impl PartialEq for LCell { [INFO] [stderr] 41| | fn eq(&self, other: &LCell) -> bool { [INFO] [stderr] 42| | self.x == other.x && self.y == other.y [INFO] [stderr] 43| | } [INFO] [stderr] 44| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/board.rs:55:43 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn init(&mut self, initial_state: &Vec<(i32, i32)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, i32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | fn neighbours(&self, cell: &LCell) -> HashSet { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `LCell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:102:73 [INFO] [stderr] | [INFO] [stderr] 102 | } else if living_nb_cnt == 2 && self.state.contains(&c) { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 103 | | s.insert(c); [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:100:39 [INFO] [stderr] | [INFO] [stderr] 100 | if living_nb_cnt == 3 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 101 | | s.insert(c); [INFO] [stderr] 102 | | } else if living_nb_cnt == 2 && self.state.contains(&c) { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/draw.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | (coord as f64) * BLOCK_SIZE [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(coord)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/game.rs:39:43 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn init(&mut self, initial_state: &Vec<(i32, i32)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(i32, i32)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rife`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d5f49bafe6ce540af19a2ef5373f084e15b66bb712f02012017795a1512ddd49"` [INFO] running `"docker" "rm" "-f" "d5f49bafe6ce540af19a2ef5373f084e15b66bb712f02012017795a1512ddd49"` [INFO] [stdout] d5f49bafe6ce540af19a2ef5373f084e15b66bb712f02012017795a1512ddd49