[INFO] updating cached repository j-dong/lambda [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/j-dong/lambda [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/j-dong/lambda" "work/ex/clippy-test-run/sources/stable/gh/j-dong/lambda"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/j-dong/lambda'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/j-dong/lambda" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j-dong/lambda"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j-dong/lambda'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] feb657900ec0364b58bae78a1e158ef6986ffd9a [INFO] sha for GitHub repo j-dong/lambda: feb657900ec0364b58bae78a1e158ef6986ffd9a [INFO] validating manifest of j-dong/lambda on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of j-dong/lambda on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing j-dong/lambda [INFO] finished frobbing j-dong/lambda [INFO] frobbed toml for j-dong/lambda written to work/ex/clippy-test-run/sources/stable/gh/j-dong/lambda/Cargo.toml [INFO] started frobbing j-dong/lambda [INFO] finished frobbing j-dong/lambda [INFO] frobbed toml for j-dong/lambda written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/j-dong/lambda/Cargo.toml [INFO] crate j-dong/lambda has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting j-dong/lambda against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/j-dong/lambda:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e2018f20c5a33156f4d1916c787b9e881155d2cd2240e5357d2bd7a6725de915 [INFO] running `"docker" "start" "-a" "e2018f20c5a33156f4d1916c787b9e881155d2cd2240e5357d2bd7a6725de915"` [INFO] [stderr] Checking lambda v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/interpret.rs:16:89 [INFO] [stderr] | [INFO] [stderr] 16 | LambdaExpr::Lambda(v, e) => if v == param { LambdaExpr::Lambda(v, e) } else { [INFO] [stderr] | _________________________________________________________________________________________^ [INFO] [stderr] 17 | | if arg.contains(&v) { [INFO] [stderr] 18 | | // alpha-conversion [INFO] [stderr] 19 | | let new_name = { [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | LambdaExpr::Lambda(v, e) => if v == param { LambdaExpr::Lambda(v, e) } else if arg.contains(&v) { [INFO] [stderr] 17 | // alpha-conversion [INFO] [stderr] 18 | let new_name = { [INFO] [stderr] 19 | let mut name = v.clone(); [INFO] [stderr] 20 | name.push('\''); [INFO] [stderr] 21 | name [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/interpret.rs:16:89 [INFO] [stderr] | [INFO] [stderr] 16 | LambdaExpr::Lambda(v, e) => if v == param { LambdaExpr::Lambda(v, e) } else { [INFO] [stderr] | _________________________________________________________________________________________^ [INFO] [stderr] 17 | | if arg.contains(&v) { [INFO] [stderr] 18 | | // alpha-conversion [INFO] [stderr] 19 | | let new_name = { [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | LambdaExpr::Lambda(v, e) => if v == param { LambdaExpr::Lambda(v, e) } else if arg.contains(&v) { [INFO] [stderr] 17 | // alpha-conversion [INFO] [stderr] 18 | let new_name = { [INFO] [stderr] 19 | let mut name = v.clone(); [INFO] [stderr] 20 | name.push('\''); [INFO] [stderr] 21 | name [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/lambda.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match expr { [INFO] [stderr] 17 | | &LambdaExpr::Lambda(_, _) => write!(f, "({})", expr), [INFO] [stderr] 18 | | _ => write!(f, "{}", expr), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *expr { [INFO] [stderr] 17 | LambdaExpr::Lambda(_, _) => write!(f, "({})", expr), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/lambda.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match expr { [INFO] [stderr] 27 | | &LambdaExpr::Apply(_, _) => write!(f, "({})", expr), [INFO] [stderr] 28 | | _ => write!(f, "{}", expr), [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *expr { [INFO] [stderr] 27 | LambdaExpr::Apply(_, _) => write!(f, "({})", expr), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/lambda.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &LambdaExpr::Variable(ref v) => write!(f, "{}", v), [INFO] [stderr] 37 | | &LambdaExpr::Apply(ref e1, ref e2) => write!(f, "{} {}", ParenthesizedLeft(&*e1), ParenthesizedRight(&*e2)), [INFO] [stderr] 38 | | &LambdaExpr::Lambda(ref v, ref e) => write!(f, "λ{} {}", v, e), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | LambdaExpr::Variable(ref v) => write!(f, "{}", v), [INFO] [stderr] 37 | LambdaExpr::Apply(ref e1, ref e2) => write!(f, "{} {}", ParenthesizedLeft(&*e1), ParenthesizedRight(&*e2)), [INFO] [stderr] 38 | LambdaExpr::Lambda(ref v, ref e) => write!(f, "λ{} {}", v, e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr/lambda.rs:94:78 [INFO] [stderr] | [INFO] [stderr] 94 | let index = self.contents.char_indices().nth(1).map(|x| x.0).unwrap_or(self.contents.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.contents.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr/lambda.rs:103:33 [INFO] [stderr] | [INFO] [stderr] 103 | }).map(|x| x.0).unwrap_or(self.contents.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.contents.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/iota.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / match self { [INFO] [stderr] 10 | | &IotaExpr::Iota => { s.push('i'); }, [INFO] [stderr] 11 | | &IotaExpr::Apply(ref e1, ref e2) => { [INFO] [stderr] 12 | | s.push('*'); [INFO] [stderr] ... | [INFO] [stderr] 15 | | }, [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *self { [INFO] [stderr] 10 | IotaExpr::Iota => { s.push('i'); }, [INFO] [stderr] 11 | IotaExpr::Apply(ref e1, ref e2) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match self { [INFO] [stderr] 67 | | &IntExpr::Variable(ref v) => v == var, [INFO] [stderr] 68 | | &IntExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 69 | | &IntExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] 70 | | _ => false [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *self { [INFO] [stderr] 67 | IntExpr::Variable(ref v) => v == var, [INFO] [stderr] 68 | IntExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 69 | IntExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / if let &IntExpr::Variable(ref v) = self { [INFO] [stderr] 76 | | v == var [INFO] [stderr] 77 | | } else { false } [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | if let IntExpr::Variable(ref v) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/convert.rs:107:50 [INFO] [stderr] | [INFO] [stderr] 107 | Box::new(IntExpr::from(IntExpr::translate(e))))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `IntExpr::from()`: `IntExpr::translate(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match self { [INFO] [stderr] 117 | | &IntExpr::Variable(ref v) => LambdaExpr::Variable(v.clone()), [INFO] [stderr] 118 | | &IntExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 119 | | &IntExpr::Lambda(ref v, ref e) => LambdaExpr::Lambda(v.clone(), Box::new(e.display_lambda())), [INFO] [stderr] ... | [INFO] [stderr] 122 | | &IntExpr::I => LambdaExpr::Variable("I".to_string()), [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *self { [INFO] [stderr] 117 | IntExpr::Variable(ref v) => LambdaExpr::Variable(v.clone()), [INFO] [stderr] 118 | IntExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 119 | IntExpr::Lambda(ref v, ref e) => LambdaExpr::Lambda(v.clone(), Box::new(e.display_lambda())), [INFO] [stderr] 120 | IntExpr::S => LambdaExpr::Variable("S".to_string()), [INFO] [stderr] 121 | IntExpr::K => LambdaExpr::Variable("K".to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / match self { [INFO] [stderr] 193 | | &IotaExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 194 | | &IotaExpr::Iota => LambdaExpr::Variable("ι".to_string()), [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 192 | match *self { [INFO] [stderr] 193 | IotaExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 194 | IotaExpr::Iota => LambdaExpr::Variable("ι".to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | / match self { [INFO] [stderr] 6 | | &LambdaExpr::Variable(ref v) => v == var, [INFO] [stderr] 7 | | &LambdaExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 8 | | &LambdaExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] 9 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 5 | match *self { [INFO] [stderr] 6 | LambdaExpr::Variable(ref v) => v == var, [INFO] [stderr] 7 | LambdaExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 8 | LambdaExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/lambda.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match expr { [INFO] [stderr] 17 | | &LambdaExpr::Lambda(_, _) => write!(f, "({})", expr), [INFO] [stderr] 18 | | _ => write!(f, "{}", expr), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *expr { [INFO] [stderr] 17 | LambdaExpr::Lambda(_, _) => write!(f, "({})", expr), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/lambda.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / match expr { [INFO] [stderr] 27 | | &LambdaExpr::Apply(_, _) => write!(f, "({})", expr), [INFO] [stderr] 28 | | _ => write!(f, "{}", expr), [INFO] [stderr] 29 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 26 | match *expr { [INFO] [stderr] 27 | LambdaExpr::Apply(_, _) => write!(f, "({})", expr), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/lambda.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &LambdaExpr::Variable(ref v) => write!(f, "{}", v), [INFO] [stderr] 37 | | &LambdaExpr::Apply(ref e1, ref e2) => write!(f, "{} {}", ParenthesizedLeft(&*e1), ParenthesizedRight(&*e2)), [INFO] [stderr] 38 | | &LambdaExpr::Lambda(ref v, ref e) => write!(f, "λ{} {}", v, e), [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | LambdaExpr::Variable(ref v) => write!(f, "{}", v), [INFO] [stderr] 37 | LambdaExpr::Apply(ref e1, ref e2) => write!(f, "{} {}", ParenthesizedLeft(&*e1), ParenthesizedRight(&*e2)), [INFO] [stderr] 38 | LambdaExpr::Lambda(ref v, ref e) => write!(f, "λ{} {}", v, e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr/lambda.rs:94:78 [INFO] [stderr] | [INFO] [stderr] 94 | let index = self.contents.char_indices().nth(1).map(|x| x.0).unwrap_or(self.contents.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.contents.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/expr/lambda.rs:103:33 [INFO] [stderr] | [INFO] [stderr] 103 | }).map(|x| x.0).unwrap_or(self.contents.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.contents.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expr/iota.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / match self { [INFO] [stderr] 10 | | &IotaExpr::Iota => { s.push('i'); }, [INFO] [stderr] 11 | | &IotaExpr::Apply(ref e1, ref e2) => { [INFO] [stderr] 12 | | s.push('*'); [INFO] [stderr] ... | [INFO] [stderr] 15 | | }, [INFO] [stderr] 16 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *self { [INFO] [stderr] 10 | IotaExpr::Iota => { s.push('i'); }, [INFO] [stderr] 11 | IotaExpr::Apply(ref e1, ref e2) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match self { [INFO] [stderr] 67 | | &IntExpr::Variable(ref v) => v == var, [INFO] [stderr] 68 | | &IntExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 69 | | &IntExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] 70 | | _ => false [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *self { [INFO] [stderr] 67 | IntExpr::Variable(ref v) => v == var, [INFO] [stderr] 68 | IntExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 69 | IntExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / if let &IntExpr::Variable(ref v) = self { [INFO] [stderr] 76 | | v == var [INFO] [stderr] 77 | | } else { false } [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | if let IntExpr::Variable(ref v) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/convert.rs:107:50 [INFO] [stderr] | [INFO] [stderr] 107 | Box::new(IntExpr::from(IntExpr::translate(e))))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `IntExpr::from()`: `IntExpr::translate(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / match self { [INFO] [stderr] 117 | | &IntExpr::Variable(ref v) => LambdaExpr::Variable(v.clone()), [INFO] [stderr] 118 | | &IntExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 119 | | &IntExpr::Lambda(ref v, ref e) => LambdaExpr::Lambda(v.clone(), Box::new(e.display_lambda())), [INFO] [stderr] ... | [INFO] [stderr] 122 | | &IntExpr::I => LambdaExpr::Variable("I".to_string()), [INFO] [stderr] 123 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 116 | match *self { [INFO] [stderr] 117 | IntExpr::Variable(ref v) => LambdaExpr::Variable(v.clone()), [INFO] [stderr] 118 | IntExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 119 | IntExpr::Lambda(ref v, ref e) => LambdaExpr::Lambda(v.clone(), Box::new(e.display_lambda())), [INFO] [stderr] 120 | IntExpr::S => LambdaExpr::Variable("S".to_string()), [INFO] [stderr] 121 | IntExpr::K => LambdaExpr::Variable("K".to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/convert.rs:192:9 [INFO] [stderr] | [INFO] [stderr] 192 | / match self { [INFO] [stderr] 193 | | &IotaExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 194 | | &IotaExpr::Iota => LambdaExpr::Variable("ι".to_string()), [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 192 | match *self { [INFO] [stderr] 193 | IotaExpr::Apply(ref e1, ref e2) => LambdaExpr::Apply(Box::new(e1.display_lambda()), Box::new(e2.display_lambda())), [INFO] [stderr] 194 | IotaExpr::Iota => LambdaExpr::Variable("ι".to_string()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpret.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | / match self { [INFO] [stderr] 6 | | &LambdaExpr::Variable(ref v) => v == var, [INFO] [stderr] 7 | | &LambdaExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 8 | | &LambdaExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] 9 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 5 | match *self { [INFO] [stderr] 6 | LambdaExpr::Variable(ref v) => v == var, [INFO] [stderr] 7 | LambdaExpr::Apply(ref e1, ref e2) => e1.contains(var) || e2.contains(var), [INFO] [stderr] 8 | LambdaExpr::Lambda(ref v, ref e) => v != var && e.contains(var), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/beta.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/beta.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if line.len() == 0 { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/lambda2iota.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/lambda2iota.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/beta.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/beta.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | if line.len() == 0 { continue; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.23s [INFO] running `"docker" "inspect" "e2018f20c5a33156f4d1916c787b9e881155d2cd2240e5357d2bd7a6725de915"` [INFO] running `"docker" "rm" "-f" "e2018f20c5a33156f4d1916c787b9e881155d2cd2240e5357d2bd7a6725de915"` [INFO] [stdout] e2018f20c5a33156f4d1916c787b9e881155d2cd2240e5357d2bd7a6725de915