[INFO] updating cached repository izumariu/hsubs-comgen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/izumariu/hsubs-comgen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/izumariu/hsubs-comgen" "work/ex/clippy-test-run/sources/stable/gh/izumariu/hsubs-comgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/izumariu/hsubs-comgen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/izumariu/hsubs-comgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izumariu/hsubs-comgen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izumariu/hsubs-comgen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7fb70d9458152282c39b9797ef4a3de5c3c87a59 [INFO] sha for GitHub repo izumariu/hsubs-comgen: 7fb70d9458152282c39b9797ef4a3de5c3c87a59 [INFO] validating manifest of izumariu/hsubs-comgen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of izumariu/hsubs-comgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing izumariu/hsubs-comgen [INFO] finished frobbing izumariu/hsubs-comgen [INFO] frobbed toml for izumariu/hsubs-comgen written to work/ex/clippy-test-run/sources/stable/gh/izumariu/hsubs-comgen/Cargo.toml [INFO] started frobbing izumariu/hsubs-comgen [INFO] finished frobbing izumariu/hsubs-comgen [INFO] frobbed toml for izumariu/hsubs-comgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izumariu/hsubs-comgen/Cargo.toml [INFO] crate izumariu/hsubs-comgen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting izumariu/hsubs-comgen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/izumariu/hsubs-comgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e77cfe5ad48403df4754cc127fe1216f1ec0b1a3c8b8c3e0d1165fce64b28e0c [INFO] running `"docker" "start" "-a" "e77cfe5ad48403df4754cc127fe1216f1ec0b1a3c8b8c3e0d1165fce64b28e0c"` [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking hsubs-comgen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const KNOWN_BOTS: [&'static str ; 13] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / if !dist.is_nan() { [INFO] [stderr] 113 | | if dist < &min || min.is_nan() { [INFO] [stderr] 114 | | min = *dist; [INFO] [stderr] 115 | | min_k = bot.to_string(); [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | if !dist.is_nan() && (dist < &min || min.is_nan()) { [INFO] [stderr] 113 | min = *dist; [INFO] [stderr] 114 | min_k = bot.to_string(); [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const KNOWN_BOTS: [&'static str ; 13] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | / if !dist.is_nan() { [INFO] [stderr] 113 | | if dist < &min || min.is_nan() { [INFO] [stderr] 114 | | min = *dist; [INFO] [stderr] 115 | | min_k = bot.to_string(); [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | if !dist.is_nan() && (dist < &min || min.is_nan()) { [INFO] [stderr] 113 | min = *dist; [INFO] [stderr] 114 | min_k = bot.to_string(); [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | if val == String::from("42") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"42"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | for bot in KNOWN_BOTS.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(_) = Regex::new(&rx).unwrap().captures(bot) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 55 | | let this_distance = user_loc.distance_to(locations.get(rx).unwrap()); [INFO] [stderr] 56 | | eprintln!("{} =~ /{}/ | DISTANCE={}", bot, rx, this_distance); [INFO] [stderr] 57 | | distances.insert(String::from(*bot), this_distance); [INFO] [stderr] 58 | | has_match = true; [INFO] [stderr] 59 | | break; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________- help: try this: `if Regex::new(&rx).unwrap().captures(bot).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:55:66 [INFO] [stderr] | [INFO] [stderr] 55 | let this_distance = user_loc.distance_to(locations.get(rx).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&locations[rx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:104:11 [INFO] [stderr] | [INFO] [stderr] 104 | while hm.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hm.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | if val == String::from("42") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"42"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:51:35 [INFO] [stderr] | [INFO] [stderr] 51 | for bot in KNOWN_BOTS.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(_) = Regex::new(&rx).unwrap().captures(bot) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 55 | | let this_distance = user_loc.distance_to(locations.get(rx).unwrap()); [INFO] [stderr] 56 | | eprintln!("{} =~ /{}/ | DISTANCE={}", bot, rx, this_distance); [INFO] [stderr] 57 | | distances.insert(String::from(*bot), this_distance); [INFO] [stderr] 58 | | has_match = true; [INFO] [stderr] 59 | | break; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________- help: try this: `if Regex::new(&rx).unwrap().captures(bot).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:55:66 [INFO] [stderr] | [INFO] [stderr] 55 | let this_distance = user_loc.distance_to(locations.get(rx).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&locations[rx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:156:41 [INFO] [stderr] | [INFO] [stderr] 156 | let packlist = hm.get_mut(&bot).expect(&format!("Error accessing Vector for {}", bot)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Error accessing Vector for {}", bot))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:167:33 [INFO] [stderr] | [INFO] [stderr] 167 | for known_bot in KNOWN_BOTS.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:184:32 [INFO] [stderr] | [INFO] [stderr] 184 | let thisval = *packs.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | if *packs.get(i-1).unwrap() == thisval - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:188:51 [INFO] [stderr] | [INFO] [stderr] 188 | while i+1 src/main.rs:188:77 [INFO] [stderr] | [INFO] [stderr] 188 | while i+1 src/main.rs:191:58 [INFO] [stderr] | [INFO] [stderr] 191 | command.push_str(&format!("-{}",*packs.get(i).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:104:11 [INFO] [stderr] | [INFO] [stderr] 104 | while hm.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hm.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:201:68 [INFO] [stderr] | [INFO] [stderr] 201 | command.push_str(&format!("/MSG {} XDCC SEND {}", bot, packs.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&packs[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:210:62 [INFO] [stderr] | [INFO] [stderr] 210 | fn summarize_sorted(hm: &HashMap>, sorting: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:221:36 [INFO] [stderr] | [INFO] [stderr] 221 | let thisval = *packs.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | if *packs.get(i-1).unwrap() == thisval - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:225:55 [INFO] [stderr] | [INFO] [stderr] 225 | while i+1 src/main.rs:225:81 [INFO] [stderr] | [INFO] [stderr] 225 | while i+1 src/main.rs:228:62 [INFO] [stderr] | [INFO] [stderr] 228 | command.push_str(&format!("-{}",*packs.get(i).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:238:76 [INFO] [stderr] | [INFO] [stderr] 238 | command.push_str(&format!("/MSG {} XDCC SEND {}", botname, packs.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&packs[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:156:41 [INFO] [stderr] | [INFO] [stderr] 156 | let packlist = hm.get_mut(&bot).expect(&format!("Error accessing Vector for {}", bot)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Error accessing Vector for {}", bot))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:167:33 [INFO] [stderr] | [INFO] [stderr] 167 | for known_bot in KNOWN_BOTS.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: Could not compile `hsubs-comgen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:184:32 [INFO] [stderr] | [INFO] [stderr] 184 | let thisval = *packs.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | if *packs.get(i-1).unwrap() == thisval - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:188:51 [INFO] [stderr] | [INFO] [stderr] 188 | while i+1 src/main.rs:188:77 [INFO] [stderr] | [INFO] [stderr] 188 | while i+1 src/main.rs:191:58 [INFO] [stderr] | [INFO] [stderr] 191 | command.push_str(&format!("-{}",*packs.get(i).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:201:68 [INFO] [stderr] | [INFO] [stderr] 201 | command.push_str(&format!("/MSG {} XDCC SEND {}", bot, packs.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&packs[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:210:62 [INFO] [stderr] | [INFO] [stderr] 210 | fn summarize_sorted(hm: &HashMap>, sorting: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:221:36 [INFO] [stderr] | [INFO] [stderr] 221 | let thisval = *packs.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | if *packs.get(i-1).unwrap() == thisval - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:225:55 [INFO] [stderr] | [INFO] [stderr] 225 | while i+1 src/main.rs:225:81 [INFO] [stderr] | [INFO] [stderr] 225 | while i+1 src/main.rs:228:62 [INFO] [stderr] | [INFO] [stderr] 228 | command.push_str(&format!("-{}",*packs.get(i).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `packs[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:238:76 [INFO] [stderr] | [INFO] [stderr] 238 | command.push_str(&format!("/MSG {} XDCC SEND {}", botname, packs.get(0).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&packs[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hsubs-comgen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e77cfe5ad48403df4754cc127fe1216f1ec0b1a3c8b8c3e0d1165fce64b28e0c"` [INFO] running `"docker" "rm" "-f" "e77cfe5ad48403df4754cc127fe1216f1ec0b1a3c8b8c3e0d1165fce64b28e0c"` [INFO] [stdout] e77cfe5ad48403df4754cc127fe1216f1ec0b1a3c8b8c3e0d1165fce64b28e0c