[INFO] updating cached repository izumariu/cleanup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/izumariu/cleanup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/izumariu/cleanup" "work/ex/clippy-test-run/sources/stable/gh/izumariu/cleanup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/izumariu/cleanup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/izumariu/cleanup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izumariu/cleanup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izumariu/cleanup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7643d3c70c0e92249dccd45cd758875a3602440a [INFO] sha for GitHub repo izumariu/cleanup: 7643d3c70c0e92249dccd45cd758875a3602440a [INFO] validating manifest of izumariu/cleanup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of izumariu/cleanup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing izumariu/cleanup [INFO] finished frobbing izumariu/cleanup [INFO] frobbed toml for izumariu/cleanup written to work/ex/clippy-test-run/sources/stable/gh/izumariu/cleanup/Cargo.toml [INFO] started frobbing izumariu/cleanup [INFO] finished frobbing izumariu/cleanup [INFO] frobbed toml for izumariu/cleanup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izumariu/cleanup/Cargo.toml [INFO] crate izumariu/cleanup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting izumariu/cleanup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/izumariu/cleanup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4687de98b42bfa14596942a201d944c6369d08b210549e8cd430c94cb2bece0 [INFO] running `"docker" "start" "-a" "e4687de98b42bfa14596942a201d944c6369d08b210549e8cd430c94cb2bece0"` [INFO] [stderr] Checking cleanup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:149:16 [INFO] [stderr] | [INFO] [stderr] 149 | } else if entry_path.is_file() { [INFO] [stderr] | ________________^ [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | [INFO] [stderr] 152 | | if entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 156 | | [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | } else if entry_path.is_file() && entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] 150 | prgmsg(&lang, &Message::FileRemove(String::from(entry_path.to_str().unwrap()))); [INFO] [stderr] 151 | fs::remove_file(entry_path).unwrap(); [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | } else if entry_path.is_file() { [INFO] [stderr] | ________________^ [INFO] [stderr] 193 | | [INFO] [stderr] 194 | | if entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] 195 | | prgmsg(lang, &Message::FileRemove(String::from(entry_path.to_str().unwrap()))); [INFO] [stderr] ... | [INFO] [stderr] 198 | | [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | } else if entry_path.is_file() && entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] 193 | prgmsg(lang, &Message::FileRemove(String::from(entry_path.to_str().unwrap()))); [INFO] [stderr] 194 | fs::remove_file(entry_path).unwrap(); [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:149:16 [INFO] [stderr] | [INFO] [stderr] 149 | } else if entry_path.is_file() { [INFO] [stderr] | ________________^ [INFO] [stderr] 150 | | [INFO] [stderr] 151 | | [INFO] [stderr] 152 | | if entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 156 | | [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 149 | } else if entry_path.is_file() && entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] 150 | prgmsg(&lang, &Message::FileRemove(String::from(entry_path.to_str().unwrap()))); [INFO] [stderr] 151 | fs::remove_file(entry_path).unwrap(); [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | } else if entry_path.is_file() { [INFO] [stderr] | ________________^ [INFO] [stderr] 193 | | [INFO] [stderr] 194 | | if entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] 195 | | prgmsg(lang, &Message::FileRemove(String::from(entry_path.to_str().unwrap()))); [INFO] [stderr] ... | [INFO] [stderr] 198 | | [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 192 | } else if entry_path.is_file() && entry_path.metadata().unwrap().len() == 0 { [INFO] [stderr] 193 | prgmsg(lang, &Message::FileRemove(String::from(entry_path.to_str().unwrap()))); [INFO] [stderr] 194 | fs::remove_file(entry_path).unwrap(); [INFO] [stderr] 195 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | fn allows_increment(&self, current: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | / if *current >= *bound { [INFO] [stderr] 65 | | false [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | true [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!(*current >= *bound)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:165:75 [INFO] [stderr] | [INFO] [stderr] 165 | fn deeper(path: &str, lang: &Language, depth: &DepthLevel, depth_current: &u32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | fn allows_increment(&self, current: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | / if *current >= *bound { [INFO] [stderr] 65 | | false [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | true [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!(*current >= *bound)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:165:75 [INFO] [stderr] | [INFO] [stderr] 165 | fn deeper(path: &str, lang: &Language, depth: &DepthLevel, depth_current: &u32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "e4687de98b42bfa14596942a201d944c6369d08b210549e8cd430c94cb2bece0"` [INFO] running `"docker" "rm" "-f" "e4687de98b42bfa14596942a201d944c6369d08b210549e8cd430c94cb2bece0"` [INFO] [stdout] e4687de98b42bfa14596942a201d944c6369d08b210549e8cd430c94cb2bece0