[INFO] updating cached repository izderadicka/ptunnel-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/izderadicka/ptunnel-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/izderadicka/ptunnel-rust" "work/ex/clippy-test-run/sources/stable/gh/izderadicka/ptunnel-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/izderadicka/ptunnel-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/izderadicka/ptunnel-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izderadicka/ptunnel-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izderadicka/ptunnel-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a2496e3ed47f4e8c90c10a8d70b22adccd625c93 [INFO] sha for GitHub repo izderadicka/ptunnel-rust: a2496e3ed47f4e8c90c10a8d70b22adccd625c93 [INFO] validating manifest of izderadicka/ptunnel-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of izderadicka/ptunnel-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing izderadicka/ptunnel-rust [INFO] finished frobbing izderadicka/ptunnel-rust [INFO] frobbed toml for izderadicka/ptunnel-rust written to work/ex/clippy-test-run/sources/stable/gh/izderadicka/ptunnel-rust/Cargo.toml [INFO] started frobbing izderadicka/ptunnel-rust [INFO] finished frobbing izderadicka/ptunnel-rust [INFO] frobbed toml for izderadicka/ptunnel-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/izderadicka/ptunnel-rust/Cargo.toml [INFO] crate izderadicka/ptunnel-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting izderadicka/ptunnel-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/izderadicka/ptunnel-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33e0c0f845567524ea0260fd08cd5fe4869827dac877c35334fc8112086b2841 [INFO] running `"docker" "start" "-a" "33e0c0f845567524ea0260fd08cd5fe4869827dac877c35334fc8112086b2841"` [INFO] [stderr] Checking termcolor v1.0.3 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking tokio-dns-unofficial v0.4.0 [INFO] [stderr] Checking ptunnel v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/config.rs:195:22 [INFO] [stderr] | [INFO] [stderr] 195 | for name in vars.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/proxy/stream.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | .and_then(|stream| read_proxy_response(stream)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_proxy_response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | config.local_addr.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.local_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/config.rs:195:22 [INFO] [stderr] | [INFO] [stderr] 195 | for name in vars.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/proxy/stream.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | .and_then(|stream| read_proxy_response(stream)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_proxy_response` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | config.local_addr.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.local_addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.23s [INFO] running `"docker" "inspect" "33e0c0f845567524ea0260fd08cd5fe4869827dac877c35334fc8112086b2841"` [INFO] running `"docker" "rm" "-f" "33e0c0f845567524ea0260fd08cd5fe4869827dac877c35334fc8112086b2841"` [INFO] [stdout] 33e0c0f845567524ea0260fd08cd5fe4869827dac877c35334fc8112086b2841