[INFO] updating cached repository iyuroch/rust_shell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iyuroch/rust_shell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iyuroch/rust_shell" "work/ex/clippy-test-run/sources/stable/gh/iyuroch/rust_shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iyuroch/rust_shell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iyuroch/rust_shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iyuroch/rust_shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iyuroch/rust_shell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ed492acbc57081a799b256b9f4cf90efcdd1206 [INFO] sha for GitHub repo iyuroch/rust_shell: 4ed492acbc57081a799b256b9f4cf90efcdd1206 [INFO] validating manifest of iyuroch/rust_shell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iyuroch/rust_shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iyuroch/rust_shell [INFO] finished frobbing iyuroch/rust_shell [INFO] frobbed toml for iyuroch/rust_shell written to work/ex/clippy-test-run/sources/stable/gh/iyuroch/rust_shell/Cargo.toml [INFO] started frobbing iyuroch/rust_shell [INFO] finished frobbing iyuroch/rust_shell [INFO] frobbed toml for iyuroch/rust_shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iyuroch/rust_shell/Cargo.toml [INFO] crate iyuroch/rust_shell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iyuroch/rust_shell against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/iyuroch/rust_shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd3264ad41e64ab3d65164934ccf159bf5ba346254551a1cf970bd88329a3997 [INFO] running `"docker" "start" "-a" "bd3264ad41e64ab3d65164934ccf159bf5ba346254551a1cf970bd88329a3997"` [INFO] [stderr] Checking rust_shell v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | match chdir(*&args[1].to_str().unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args[1].to_str().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | match chdir(*&args[1].to_str().unwrap()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `args[1].to_str().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | let cstr_argv: Vec<_> = str_argv.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match exec_name.as_ref() { [INFO] [stderr] 46 | | "cd" => { [INFO] [stderr] 47 | | cd(cstr_argv); [INFO] [stderr] 48 | | return; [INFO] [stderr] 49 | | }, [INFO] [stderr] 50 | | _ => {}, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | if let "cd" = exec_name.as_ref() { [INFO] [stderr] 46 | cd(cstr_argv); [INFO] [stderr] 47 | return; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / match parent_write_end { [INFO] [stderr] 67 | | Some(v) => { [INFO] [stderr] 68 | | match close(v) { [INFO] [stderr] 69 | | Ok(_) => {}, [INFO] [stderr] ... | [INFO] [stderr] 73 | | None => {}, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | if let Some(v) = parent_write_end { [INFO] [stderr] 67 | match close(v) { [INFO] [stderr] 68 | Ok(_) => {}, [INFO] [stderr] 69 | Err(_e) => {}, [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / match read_end { [INFO] [stderr] 77 | | Some(v) => { [INFO] [stderr] 78 | | match close(v) { [INFO] [stderr] 79 | | Ok(_) => {}, [INFO] [stderr] ... | [INFO] [stderr] 83 | | None => {}, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(v) = read_end { [INFO] [stderr] 77 | match close(v) { [INFO] [stderr] 78 | Ok(_) => {}, [INFO] [stderr] 79 | Err(_e) => {}, [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match last { [INFO] [stderr] 87 | | Some(_) => match waitpid(child, Option::None) { [INFO] [stderr] 88 | | Ok(_) => { [INFO] [stderr] 89 | | return; [INFO] [stderr] ... | [INFO] [stderr] 93 | | None => {}, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(_) = last { match waitpid(child, Option::None) { [INFO] [stderr] 87 | Ok(_) => { [INFO] [stderr] 88 | return; [INFO] [stderr] 89 | }, [INFO] [stderr] 90 | Err(e) => println!("Error: {}", e) [INFO] [stderr] 91 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | / match parent_write_end { [INFO] [stderr] 104 | | Some(v) => close(v).unwrap(), [INFO] [stderr] 105 | | None => {}, [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = parent_write_end { close(v).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | / match child_read_end { [INFO] [stderr] 109 | | Some(v) => close(v).unwrap(), [INFO] [stderr] 110 | | None => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = child_read_end { close(v).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | / match read_end { [INFO] [stderr] 114 | | Some(v) => { [INFO] [stderr] 115 | | dup2(v, 0).unwrap(); [INFO] [stderr] 116 | | }, [INFO] [stderr] 117 | | None => {}, [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | if let Some(v) = read_end { [INFO] [stderr] 114 | dup2(v, 0).unwrap(); [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | / match write_end { [INFO] [stderr] 121 | | Some(v) => { [INFO] [stderr] 122 | | dup2(v, 1).unwrap(); [INFO] [stderr] 123 | | }, [INFO] [stderr] 124 | | None => {}, [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(v) = write_end { [INFO] [stderr] 121 | dup2(v, 1).unwrap(); [INFO] [stderr] 122 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | / match *first_child { [INFO] [stderr] 134 | | Some(v) => { [INFO] [stderr] 135 | | match kill(v, SIGKILL) { [INFO] [stderr] 136 | | Ok(_) => {}, [INFO] [stderr] ... | [INFO] [stderr] 142 | | None => {}, [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 133 | if let Some(v) = *first_child { [INFO] [stderr] 134 | match kill(v, SIGKILL) { [INFO] [stderr] 135 | Ok(_) => {}, [INFO] [stderr] 136 | Err(e) => { [INFO] [stderr] 137 | println!("cannot kill pid {:?}", e); [INFO] [stderr] 138 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:160:37 [INFO] [stderr] | [INFO] [stderr] 160 | prompt_string.extend_from_slice(" > ".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" > "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | io::stdout().write(&prompt_string).expect("Cannot print"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | if pr_arr.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pr_arr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:196:42 [INFO] [stderr] | [INFO] [stderr] 196 | fd_arr.extend(&[Some(write_end.clone()), Some(read_end.clone())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `write_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:196:67 [INFO] [stderr] | [INFO] [stderr] 196 | fd_arr.extend(&[Some(write_end.clone()), Some(read_end.clone())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `read_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_shell`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:39:44 [INFO] [stderr] | [INFO] [stderr] 39 | let cstr_argv: Vec<_> = str_argv.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match exec_name.as_ref() { [INFO] [stderr] 46 | | "cd" => { [INFO] [stderr] 47 | | cd(cstr_argv); [INFO] [stderr] 48 | | return; [INFO] [stderr] 49 | | }, [INFO] [stderr] 50 | | _ => {}, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 45 | if let "cd" = exec_name.as_ref() { [INFO] [stderr] 46 | cd(cstr_argv); [INFO] [stderr] 47 | return; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | / match parent_write_end { [INFO] [stderr] 67 | | Some(v) => { [INFO] [stderr] 68 | | match close(v) { [INFO] [stderr] 69 | | Ok(_) => {}, [INFO] [stderr] ... | [INFO] [stderr] 73 | | None => {}, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | if let Some(v) = parent_write_end { [INFO] [stderr] 67 | match close(v) { [INFO] [stderr] 68 | Ok(_) => {}, [INFO] [stderr] 69 | Err(_e) => {}, [INFO] [stderr] 70 | } [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / match read_end { [INFO] [stderr] 77 | | Some(v) => { [INFO] [stderr] 78 | | match close(v) { [INFO] [stderr] 79 | | Ok(_) => {}, [INFO] [stderr] ... | [INFO] [stderr] 83 | | None => {}, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | if let Some(v) = read_end { [INFO] [stderr] 77 | match close(v) { [INFO] [stderr] 78 | Ok(_) => {}, [INFO] [stderr] 79 | Err(_e) => {}, [INFO] [stderr] 80 | } [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match last { [INFO] [stderr] 87 | | Some(_) => match waitpid(child, Option::None) { [INFO] [stderr] 88 | | Ok(_) => { [INFO] [stderr] 89 | | return; [INFO] [stderr] ... | [INFO] [stderr] 93 | | None => {}, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(_) = last { match waitpid(child, Option::None) { [INFO] [stderr] 87 | Ok(_) => { [INFO] [stderr] 88 | return; [INFO] [stderr] 89 | }, [INFO] [stderr] 90 | Err(e) => println!("Error: {}", e) [INFO] [stderr] 91 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | / match parent_write_end { [INFO] [stderr] 104 | | Some(v) => close(v).unwrap(), [INFO] [stderr] 105 | | None => {}, [INFO] [stderr] 106 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = parent_write_end { close(v).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | / match child_read_end { [INFO] [stderr] 109 | | Some(v) => close(v).unwrap(), [INFO] [stderr] 110 | | None => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(v) = child_read_end { close(v).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | / match read_end { [INFO] [stderr] 114 | | Some(v) => { [INFO] [stderr] 115 | | dup2(v, 0).unwrap(); [INFO] [stderr] 116 | | }, [INFO] [stderr] 117 | | None => {}, [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | if let Some(v) = read_end { [INFO] [stderr] 114 | dup2(v, 0).unwrap(); [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | / match write_end { [INFO] [stderr] 121 | | Some(v) => { [INFO] [stderr] 122 | | dup2(v, 1).unwrap(); [INFO] [stderr] 123 | | }, [INFO] [stderr] 124 | | None => {}, [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | if let Some(v) = write_end { [INFO] [stderr] 121 | dup2(v, 1).unwrap(); [INFO] [stderr] 122 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | / match *first_child { [INFO] [stderr] 134 | | Some(v) => { [INFO] [stderr] 135 | | match kill(v, SIGKILL) { [INFO] [stderr] 136 | | Ok(_) => {}, [INFO] [stderr] ... | [INFO] [stderr] 142 | | None => {}, [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 133 | if let Some(v) = *first_child { [INFO] [stderr] 134 | match kill(v, SIGKILL) { [INFO] [stderr] 135 | Ok(_) => {}, [INFO] [stderr] 136 | Err(e) => { [INFO] [stderr] 137 | println!("cannot kill pid {:?}", e); [INFO] [stderr] 138 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:160:37 [INFO] [stderr] | [INFO] [stderr] 160 | prompt_string.extend_from_slice(" > ".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" > "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:161:5 [INFO] [stderr] | [INFO] [stderr] 161 | io::stdout().write(&prompt_string).expect("Cannot print"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | if pr_arr.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pr_arr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:196:42 [INFO] [stderr] | [INFO] [stderr] 196 | fd_arr.extend(&[Some(write_end.clone()), Some(read_end.clone())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `write_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:196:67 [INFO] [stderr] | [INFO] [stderr] 196 | fd_arr.extend(&[Some(write_end.clone()), Some(read_end.clone())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `read_end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_shell`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bd3264ad41e64ab3d65164934ccf159bf5ba346254551a1cf970bd88329a3997"` [INFO] running `"docker" "rm" "-f" "bd3264ad41e64ab3d65164934ccf159bf5ba346254551a1cf970bd88329a3997"` [INFO] [stdout] bd3264ad41e64ab3d65164934ccf159bf5ba346254551a1cf970bd88329a3997