[INFO] updating cached repository ivanacostarubio/libssh-scanner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ivanacostarubio/libssh-scanner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ivanacostarubio/libssh-scanner" "work/ex/clippy-test-run/sources/stable/gh/ivanacostarubio/libssh-scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ivanacostarubio/libssh-scanner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ivanacostarubio/libssh-scanner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ivanacostarubio/libssh-scanner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ivanacostarubio/libssh-scanner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 16d5dc6a2c9f61bf54fd33f02dc581143141e8ee [INFO] sha for GitHub repo ivanacostarubio/libssh-scanner: 16d5dc6a2c9f61bf54fd33f02dc581143141e8ee [INFO] validating manifest of ivanacostarubio/libssh-scanner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ivanacostarubio/libssh-scanner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ivanacostarubio/libssh-scanner [INFO] finished frobbing ivanacostarubio/libssh-scanner [INFO] frobbed toml for ivanacostarubio/libssh-scanner written to work/ex/clippy-test-run/sources/stable/gh/ivanacostarubio/libssh-scanner/Cargo.toml [INFO] started frobbing ivanacostarubio/libssh-scanner [INFO] finished frobbing ivanacostarubio/libssh-scanner [INFO] frobbed toml for ivanacostarubio/libssh-scanner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ivanacostarubio/libssh-scanner/Cargo.toml [INFO] crate ivanacostarubio/libssh-scanner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ivanacostarubio/libssh-scanner against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ivanacostarubio/libssh-scanner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1126a0ca4e7480b2ab80d02b707d1ad2229773cd52ea7ceab8389802dae66c4f [INFO] running `"docker" "start" "-a" "1126a0ca4e7480b2ab80d02b707d1ad2229773cd52ea7ceab8389802dae66c4f"` [INFO] [stderr] Compiling libz-sys v1.0.24 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Checking ssh2 v0.3.3 [INFO] [stderr] Checking libssh-scan v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | let split: Vec<_> = banner.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let version: i32 = split.last().clone().unwrap_or(&"9").parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `split.last()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | let split: Vec<_> = banner.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let version: i32 = split.last().clone().unwrap_or(&"9").parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `split.last()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.21s [INFO] running `"docker" "inspect" "1126a0ca4e7480b2ab80d02b707d1ad2229773cd52ea7ceab8389802dae66c4f"` [INFO] running `"docker" "rm" "-f" "1126a0ca4e7480b2ab80d02b707d1ad2229773cd52ea7ceab8389802dae66c4f"` [INFO] [stdout] 1126a0ca4e7480b2ab80d02b707d1ad2229773cd52ea7ceab8389802dae66c4f