[INFO] updating cached repository itsaark/helix
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/itsaark/helix
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/itsaark/helix" "work/ex/clippy-test-run/sources/stable/gh/itsaark/helix"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/itsaark/helix'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/itsaark/helix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itsaark/helix"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itsaark/helix'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0d1b22b227fb8e070ea84db4a46ee06186919788
[INFO] sha for GitHub repo itsaark/helix: 0d1b22b227fb8e070ea84db4a46ee06186919788
[INFO] validating manifest of itsaark/helix on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of itsaark/helix on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing itsaark/helix
[INFO] finished frobbing itsaark/helix
[INFO] frobbed toml for itsaark/helix written to work/ex/clippy-test-run/sources/stable/gh/itsaark/helix/Cargo.toml
[INFO] started frobbing itsaark/helix
[INFO] finished frobbing itsaark/helix
[INFO] frobbed toml for itsaark/helix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itsaark/helix/Cargo.toml
[INFO] crate itsaark/helix has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting itsaark/helix against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/itsaark/helix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 598e31d636d641f710bf7a940a9b302a1f8f59d156f6eea77cab9d7b0d67fbd4
[INFO] running `"docker" "start" "-a" "598e31d636d641f710bf7a940a9b302a1f8f59d156f6eea77cab9d7b0d67fbd4"`
[INFO] [stderr]     Checking serde_json v1.0.26
[INFO] [stderr]     Checking helix v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/compression/perceptual.rs:106:28
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let mut hvalue : u64 = 0xAAAAAAAA;
[INFO] [stderr]     |                            ^^^^^^^^^^ help: consider: `0xAAAA_AAAA`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/compression/fasta.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 |         return self.hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/compression/perceptual.rs:106:28
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let mut hvalue : u64 = 0xAAAAAAAA;
[INFO] [stderr]     |                            ^^^^^^^^^^ help: consider: `0xAAAA_AAAA`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/compression/fasta.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 |         return self.hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]    --> src/compression/fasta.rs:211:13
[INFO] [stderr]     |
[INFO] [stderr] 211 |         for i in 0..10 {
[INFO] [stderr]     |             ^ help: consider using `_i` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `d`
[INFO] [stderr]    --> src/compression/fasta.rs:222:13
[INFO] [stderr]     |
[INFO] [stderr] 222 |         let d = f1.distance_to(&f2);
[INFO] [stderr]     |             ^ help: consider using `_d` instead
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/compression/perceptual.rs:161:30
[INFO] [stderr]     |
[INFO] [stderr] 161 |         let value = distance("0001".as_bytes(),"0000".as_bytes());
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0001"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/compression/perceptual.rs:161:48
[INFO] [stderr]     |
[INFO] [stderr] 161 |         let value = distance("0001".as_bytes(),"0000".as_bytes());
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0000"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/compression/perceptual.rs:165:30
[INFO] [stderr]     |
[INFO] [stderr] 165 |         let value = distance("000A".as_bytes(),"0000".as_bytes());
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"000A"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/compression/perceptual.rs:165:48
[INFO] [stderr]     |
[INFO] [stderr] 165 |         let value = distance("000A".as_bytes(),"0000".as_bytes());
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0000"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/compression/perceptual.rs:175:44
[INFO] [stderr]     |
[INFO] [stderr] 175 |         let value = distance(s1.as_bytes(),"0000".as_bytes());
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"0000"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.71s
[INFO] running `"docker" "inspect" "598e31d636d641f710bf7a940a9b302a1f8f59d156f6eea77cab9d7b0d67fbd4"`
[INFO] running `"docker" "rm" "-f" "598e31d636d641f710bf7a940a9b302a1f8f59d156f6eea77cab9d7b0d67fbd4"`
[INFO] [stdout] 598e31d636d641f710bf7a940a9b302a1f8f59d156f6eea77cab9d7b0d67fbd4