[INFO] updating cached repository itarato/phprustparser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/itarato/phprustparser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/itarato/phprustparser" "work/ex/clippy-test-run/sources/stable/gh/itarato/phprustparser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/itarato/phprustparser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/itarato/phprustparser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itarato/phprustparser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itarato/phprustparser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a11f1e1a38e931a76508f5f471fda7573a1432a2
[INFO] sha for GitHub repo itarato/phprustparser: a11f1e1a38e931a76508f5f471fda7573a1432a2
[INFO] validating manifest of itarato/phprustparser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of itarato/phprustparser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing itarato/phprustparser
[INFO] finished frobbing itarato/phprustparser
[INFO] frobbed toml for itarato/phprustparser written to work/ex/clippy-test-run/sources/stable/gh/itarato/phprustparser/Cargo.toml
[INFO] started frobbing itarato/phprustparser
[INFO] finished frobbing itarato/phprustparser
[INFO] frobbed toml for itarato/phprustparser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itarato/phprustparser/Cargo.toml
[INFO] crate itarato/phprustparser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting itarato/phprustparser against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/itarato/phprustparser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 46f642f8d850a6d6f9408a98b0aca6dfb79d576491b6fd4c67e2656a34d478e3
[INFO] running `"docker" "start" "-a" "46f642f8d850a6d6f9408a98b0aca6dfb79d576491b6fd4c67e2656a34d478e3"`
[INFO] [stderr]     Checking phpparser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/reader.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             chars: chars,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `chars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ast.rs:223:13
[INFO] [stderr]     |
[INFO] [stderr] 223 |             tokens: tokens,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/reader.rs:11:13
[INFO] [stderr]    |
[INFO] [stderr] 11 |             chars: chars,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `chars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ast.rs:223:13
[INFO] [stderr]     |
[INFO] [stderr] 223 |             tokens: tokens,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 | /     return "<?php
[INFO] [stderr] 138 | |
[INFO] [stderr] 139 | | function say($text, $bump) {
[INFO] [stderr] 140 | |     echo('Hello World');
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | | say($foo);
[INFO] [stderr] 152 | | ".to_string();
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 137 |     "<?php
[INFO] [stderr] 138 | 
[INFO] [stderr] 139 | function say($text, $bump) {
[INFO] [stderr] 140 |     echo('Hello World');
[INFO] [stderr] 141 |     $foo = 1 + ((2 - 3) . ($text * 10));
[INFO] [stderr] 142 | }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:137:5
[INFO] [stderr]     |
[INFO] [stderr] 137 | /     return "<?php
[INFO] [stderr] 138 | |
[INFO] [stderr] 139 | | function say($text, $bump) {
[INFO] [stderr] 140 | |     echo('Hello World');
[INFO] [stderr] ...   |
[INFO] [stderr] 151 | | say($foo);
[INFO] [stderr] 152 | | ".to_string();
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 137 |     "<?php
[INFO] [stderr] 138 | 
[INFO] [stderr] 139 | function say($text, $bump) {
[INFO] [stderr] 140 |     echo('Hello World');
[INFO] [stderr] 141 |     $foo = 1 + ((2 - 3) . ($text * 10));
[INFO] [stderr] 142 | }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::iter::Iterator`
[INFO] [stderr]  --> src/ast.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::iter::Iterator;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/reader.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         self.chars.iter().skip(self.position).take(n).map(|ch| *ch).collect()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.chars.iter().skip(self.position).take(n).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/reader.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         self.chars.iter().skip(self.position).take_while(pred).map(|ch| *ch).collect()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.chars.iter().skip(self.position).take_while(pred).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/ast.rs:38:24
[INFO] [stderr]    |
[INFO] [stderr] 38 |     pub fn new(tokens: &Vec<Token>) -> AstBuilder {
[INFO] [stderr]    |                        ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the `t @ _` pattern can be written as just `t`
[INFO] [stderr]    --> src/ast.rs:109:17
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 t @ _ => panic!("Unknown token {:?}", t),
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ast.rs:124:15
[INFO] [stderr]     |
[INFO] [stderr] 124 |         while children.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the `t @ _` pattern can be written as just `t`
[INFO] [stderr]    --> src/ast.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             t @ _ => panic!("Unexpected token {:?}", t),
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `t @ _` pattern can be written as just `t`
[INFO] [stderr]    --> src/ast.rs:204:17
[INFO] [stderr]     |
[INFO] [stderr] 204 |                 t @ _ => panic!("Unexpected token for arg list {:?}", t),
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::iter::Iterator`
[INFO] [stderr]  --> src/ast.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::iter::Iterator;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |     (NUMBER) => (
[INFO] [stderr] 31 | |         in_char_ranges_callback!{['0', '9'], ['-', '-'], ['.', '.']}
[INFO] [stderr]    | |______________________________________________________^ help: try: `**ch == '-'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:63:39
[INFO] [stderr]    |
[INFO] [stderr] 63 |               let s = reader.peek_until(is_valid_fn!(NUMBER));
[INFO] [stderr]    |                                         -------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_comparisons)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |     (NUMBER) => (
[INFO] [stderr] 31 | |         in_char_ranges_callback!{['0', '9'], ['-', '-'], ['.', '.']}
[INFO] [stderr]    | |__________________________________________________________________^ help: try: `**ch == '.'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:63:39
[INFO] [stderr]    |
[INFO] [stderr] 63 |               let s = reader.peek_until(is_valid_fn!(NUMBER));
[INFO] [stderr]    |                                         -------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |     (VARNAME) => (
[INFO] [stderr] 28 | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]    | |______________________________________________________________________________^ help: try: `**ch == '_'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |               let s = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]    |                                         --------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |     (VARNAME) => (
[INFO] [stderr] 28 | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]    | |__________________________________________________________________________________________^ help: try: `**ch == '$'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |               let s = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]    |                                         --------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:93:12
[INFO] [stderr]    |
[INFO] [stderr] 93 |         if ops.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ops.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/macros.rs:5:25
[INFO] [stderr]     |
[INFO] [stderr] 5   |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 6   | |         }
[INFO] [stderr] 7   | |     }
[INFO] [stderr] 8   | | }
[INFO] [stderr] ...   |
[INFO] [stderr] 27  | |     (VARNAME) => (
[INFO] [stderr] 28  | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]     | |______________________________________________________________________________^ help: try: `**ch == '_'`
[INFO] [stderr]     | 
[INFO] [stderr]    ::: src/main.rs:114:42
[INFO] [stderr]     |
[INFO] [stderr] 114 |               let name = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]     |                                            --------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/macros.rs:5:25
[INFO] [stderr]     |
[INFO] [stderr] 5   |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 6   | |         }
[INFO] [stderr] 7   | |     }
[INFO] [stderr] 8   | | }
[INFO] [stderr] ...   |
[INFO] [stderr] 27  | |     (VARNAME) => (
[INFO] [stderr] 28  | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]     | |__________________________________________________________________________________________^ help: try: `**ch == '$'`
[INFO] [stderr]     | 
[INFO] [stderr]    ::: src/main.rs:114:42
[INFO] [stderr]     |
[INFO] [stderr] 114 |               let name = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]     |                                            --------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/reader.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         self.chars.iter().skip(self.position).take(n).map(|ch| *ch).collect()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.chars.iter().skip(self.position).take(n).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/reader.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 |         self.chars.iter().skip(self.position).take_while(pred).map(|ch| *ch).collect()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.chars.iter().skip(self.position).take_while(pred).cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/ast.rs:38:24
[INFO] [stderr]    |
[INFO] [stderr] 38 |     pub fn new(tokens: &Vec<Token>) -> AstBuilder {
[INFO] [stderr]    |                        ^^^^^^^^^^^ help: change this to: `&[Token]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the `t @ _` pattern can be written as just `t`
[INFO] [stderr]    --> src/ast.rs:109:17
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 t @ _ => panic!("Unknown token {:?}", t),
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ast.rs:124:15
[INFO] [stderr]     |
[INFO] [stderr] 124 |         while children.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the `t @ _` pattern can be written as just `t`
[INFO] [stderr]    --> src/ast.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             t @ _ => panic!("Unexpected token {:?}", t),
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the `t @ _` pattern can be written as just `t`
[INFO] [stderr]    --> src/ast.rs:204:17
[INFO] [stderr]     |
[INFO] [stderr] 204 |                 t @ _ => panic!("Unexpected token for arg list {:?}", t),
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |     (NUMBER) => (
[INFO] [stderr] 31 | |         in_char_ranges_callback!{['0', '9'], ['-', '-'], ['.', '.']}
[INFO] [stderr]    | |______________________________________________________^ help: try: `**ch == '-'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:63:39
[INFO] [stderr]    |
[INFO] [stderr] 63 |               let s = reader.peek_until(is_valid_fn!(NUMBER));
[INFO] [stderr]    |                                         -------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_comparisons)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |     (NUMBER) => (
[INFO] [stderr] 31 | |         in_char_ranges_callback!{['0', '9'], ['-', '-'], ['.', '.']}
[INFO] [stderr]    | |__________________________________________________________________^ help: try: `**ch == '.'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:63:39
[INFO] [stderr]    |
[INFO] [stderr] 63 |               let s = reader.peek_until(is_valid_fn!(NUMBER));
[INFO] [stderr]    |                                         -------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |     (VARNAME) => (
[INFO] [stderr] 28 | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]    | |______________________________________________________________________________^ help: try: `**ch == '_'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |               let s = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]    |                                         --------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]   --> src/macros.rs:5:25
[INFO] [stderr]    |
[INFO] [stderr] 5  |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 6  | |         }
[INFO] [stderr] 7  | |     }
[INFO] [stderr] 8  | | }
[INFO] [stderr] ...  |
[INFO] [stderr] 27 | |     (VARNAME) => (
[INFO] [stderr] 28 | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]    | |__________________________________________________________________________________________^ help: try: `**ch == '$'`
[INFO] [stderr]    | 
[INFO] [stderr]   ::: src/main.rs:74:39
[INFO] [stderr]    |
[INFO] [stderr] 74 |               let s = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]    |                                         --------------------- in this macro invocation
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:93:12
[INFO] [stderr]    |
[INFO] [stderr] 93 |         if ops.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ops.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/macros.rs:5:25
[INFO] [stderr]     |
[INFO] [stderr] 5   |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 6   | |         }
[INFO] [stderr] 7   | |     }
[INFO] [stderr] 8   | | }
[INFO] [stderr] ...   |
[INFO] [stderr] 27  | |     (VARNAME) => (
[INFO] [stderr] 28  | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]     | |______________________________________________________________________________^ help: try: `**ch == '_'`
[INFO] [stderr]     | 
[INFO] [stderr]    ::: src/main.rs:114:42
[INFO] [stderr]     |
[INFO] [stderr] 114 |               let name = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]     |                                            --------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr] warning: This binary expression can be simplified
[INFO] [stderr]    --> src/macros.rs:5:25
[INFO] [stderr]     |
[INFO] [stderr] 5   |               $( (**ch >= $f && **ch <= $t) ||)* false
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 6   | |         }
[INFO] [stderr] 7   | |     }
[INFO] [stderr] 8   | | }
[INFO] [stderr] ...   |
[INFO] [stderr] 27  | |     (VARNAME) => (
[INFO] [stderr] 28  | |         in_char_ranges_callback!{['a', 'z'], ['A', 'Z'], ['0', '9'], ['_', '_'], ['$', '$']}
[INFO] [stderr]     | |__________________________________________________________________________________________^ help: try: `**ch == '$'`
[INFO] [stderr]     | 
[INFO] [stderr]    ::: src/main.rs:114:42
[INFO] [stderr]     |
[INFO] [stderr] 114 |               let name = reader.peek_until(is_valid_fn!(VARNAME));
[INFO] [stderr]     |                                            --------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.37s
[INFO] running `"docker" "inspect" "46f642f8d850a6d6f9408a98b0aca6dfb79d576491b6fd4c67e2656a34d478e3"`
[INFO] running `"docker" "rm" "-f" "46f642f8d850a6d6f9408a98b0aca6dfb79d576491b6fd4c67e2656a34d478e3"`
[INFO] [stdout] 46f642f8d850a6d6f9408a98b0aca6dfb79d576491b6fd4c67e2656a34d478e3