[INFO] updating cached repository itarato/gameboy_emu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/itarato/gameboy_emu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/itarato/gameboy_emu" "work/ex/clippy-test-run/sources/stable/gh/itarato/gameboy_emu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/itarato/gameboy_emu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/itarato/gameboy_emu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itarato/gameboy_emu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itarato/gameboy_emu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec11c750f45f73f66a5dbcbd3089b1500d47e1a9 [INFO] sha for GitHub repo itarato/gameboy_emu: ec11c750f45f73f66a5dbcbd3089b1500d47e1a9 [INFO] validating manifest of itarato/gameboy_emu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of itarato/gameboy_emu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing itarato/gameboy_emu [INFO] finished frobbing itarato/gameboy_emu [INFO] frobbed toml for itarato/gameboy_emu written to work/ex/clippy-test-run/sources/stable/gh/itarato/gameboy_emu/Cargo.toml [INFO] started frobbing itarato/gameboy_emu [INFO] finished frobbing itarato/gameboy_emu [INFO] frobbed toml for itarato/gameboy_emu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itarato/gameboy_emu/Cargo.toml [INFO] crate itarato/gameboy_emu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting itarato/gameboy_emu against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/itarato/gameboy_emu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 748773c8dfd17a229102e6a6f77f44f5d1c4f90e818478e2c4c30465e1c66c5a [INFO] running `"docker" "start" "-a" "748773c8dfd17a229102e6a6f77f44f5d1c4f90e818478e2c4c30465e1c66c5a"` [INFO] [stderr] Checking gameboy_emu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bus.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bus.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | timer: timer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `timer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | boot_rom: boot_rom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `boot_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | lengths: lengths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lengths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bus.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bus.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | timer: timer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `timer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | boot_rom: boot_rom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `boot_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboy.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | io: io, [INFO] [stderr] | ^^^^^^ help: replace it with: `io` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | lengths: lengths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `lengths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io.rs:8:28 [INFO] [stderr] | [INFO] [stderr] 8 | const TICK_SEQ_VIDEO_023: &'static str = "video_023"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | const TICK_SEQ_VIDEO_1: &'static str = "video_1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io.rs:8:28 [INFO] [stderr] | [INFO] [stderr] 8 | const TICK_SEQ_VIDEO_023: &'static str = "video_023"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | const TICK_SEQ_VIDEO_1: &'static str = "video_1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/timer.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let mut ticker = self.ticks.get_mut(&cycle).unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/bus.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | let diff = MEM_MAP_ECHO_OF_INTERNAL_RAM_START - MEM_MAP_ECHO_OF_INTERNAL_RAM_START; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bus.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | self.timer.inc(cycles as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(cycles)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | (hi as u16) << 8 | lo as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | (hi as u16) << 8 | lo as u16 [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/cpu.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / pub fn next_instruction(&mut self, bus: &mut Bus) { [INFO] [stderr] 188 | | let opcode = self.read_opcode(bus); [INFO] [stderr] 189 | | let mut cycles = 0u8; [INFO] [stderr] 190 | | println!("Read opcode {:#x} ({:#b}) at PC {:#x} ({})", opcode, opcode, self.pc - 1, self.pc - 1); [INFO] [stderr] ... | [INFO] [stderr] 644 | | self.handle_timing(); [INFO] [stderr] 645 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/timer.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | let mut ticker = self.ticks.get_mut(&cycle).unwrap(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 300 | 0x20 => jr!(self, bus, !self.flag.z_zero), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/bus.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | let diff = MEM_MAP_ECHO_OF_INTERNAL_RAM_START - MEM_MAP_ECHO_OF_INTERNAL_RAM_START; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bus.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | self.timer.inc(cycles as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(cycles)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | (hi as u16) << 8 | lo as u16 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | (hi as u16) << 8 | lo as u16 [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 302 | 0x30 => jr!(self, bus, !self.flag.c_carry), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 304 | 0x18 => jr!(self, bus, true), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 306 | 0x28 => jr!(self, bus, self.flag.z_zero), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 308 | 0x38 => jr!(self, bus, self.flag.c_carry), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/cpu.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | / pub fn next_instruction(&mut self, bus: &mut Bus) { [INFO] [stderr] 188 | | let opcode = self.read_opcode(bus); [INFO] [stderr] 189 | | let mut cycles = 0u8; [INFO] [stderr] 190 | | println!("Read opcode {:#x} ({:#b}) at PC {:#x} ({})", opcode, opcode, self.pc - 1, self.pc - 1); [INFO] [stderr] ... | [INFO] [stderr] 644 | | self.handle_timing(); [INFO] [stderr] 645 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:549:42 [INFO] [stderr] | [INFO] [stderr] 549 | bus.write_byte((0xFF00 + (addr as u16)) as usize, self.acc); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:559:42 [INFO] [stderr] | [INFO] [stderr] 559 | bus.write_byte((0xFF00 + (self.c as u16)) as usize, self.acc); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:570:52 [INFO] [stderr] | [INFO] [stderr] 570 | self.acc = bus.read_byte((0xFF00 | (offs as u16)) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:642:29 [INFO] [stderr] | [INFO] [stderr] 642 | bus.register_cycles(cycles as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(cycles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 300 | 0x20 => jr!(self, bus, !self.flag.z_zero), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 302 | 0x30 => jr!(self, bus, !self.flag.c_carry), [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 304 | 0x18 => jr!(self, bus, true), [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 306 | 0x28 => jr!(self, bus, self.flag.z_zero), [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:99:51 [INFO] [stderr] | [INFO] [stderr] 99 | $_self.pc = (($_self.pc as i16) + ((addr as i8) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from((addr as i8))` [INFO] [stderr] ... [INFO] [stderr] 308 | 0x38 => jr!(self, bus, self.flag.c_carry), [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:549:42 [INFO] [stderr] | [INFO] [stderr] 549 | bus.write_byte((0xFF00 + (addr as u16)) as usize, self.acc); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:559:42 [INFO] [stderr] | [INFO] [stderr] 559 | bus.write_byte((0xFF00 + (self.c as u16)) as usize, self.acc); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:570:52 [INFO] [stderr] | [INFO] [stderr] 570 | self.acc = bus.read_byte((0xFF00 | (offs as u16)) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:642:29 [INFO] [stderr] | [INFO] [stderr] 642 | bus.register_cycles(cycles as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(cycles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/timer.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | self.sequences.get(&name).unwrap().current_phase [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.sequences[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/timer.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.sequences.get(&name).unwrap().did_tick [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.sequences[&name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/timer.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | self.sequences.get(&name).unwrap().current_phase [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.sequences[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/timer.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.sequences.get(&name).unwrap().did_tick [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.sequences[&name]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: Could not compile `gameboy_emu`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `gameboy_emu`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "748773c8dfd17a229102e6a6f77f44f5d1c4f90e818478e2c4c30465e1c66c5a"` [INFO] running `"docker" "rm" "-f" "748773c8dfd17a229102e6a6f77f44f5d1c4f90e818478e2c4c30465e1c66c5a"` [INFO] [stdout] 748773c8dfd17a229102e6a6f77f44f5d1c4f90e818478e2c4c30465e1c66c5a