[INFO] updating cached repository itaibn/turing [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/itaibn/turing [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/itaibn/turing" "work/ex/clippy-test-run/sources/stable/gh/itaibn/turing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/itaibn/turing'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/itaibn/turing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itaibn/turing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itaibn/turing'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3136b638f6e6822dcbb94c4a8baad2efcbea14ac [INFO] sha for GitHub repo itaibn/turing: 3136b638f6e6822dcbb94c4a8baad2efcbea14ac [INFO] validating manifest of itaibn/turing on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of itaibn/turing on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing itaibn/turing [INFO] finished frobbing itaibn/turing [INFO] frobbed toml for itaibn/turing written to work/ex/clippy-test-run/sources/stable/gh/itaibn/turing/Cargo.toml [INFO] started frobbing itaibn/turing [INFO] finished frobbing itaibn/turing [INFO] frobbed toml for itaibn/turing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itaibn/turing/Cargo.toml [INFO] crate itaibn/turing has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting itaibn/turing against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/itaibn/turing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 850ca5830674af5c54750d13198cf77f0a63273bbd6308503e7b02cf2909c53a [INFO] running `"docker" "start" "-a" "850ca5830674af5c54750d13198cf77f0a63273bbd6308503e7b02cf2909c53a"` [INFO] [stderr] Compiling gio v0.1.2 [INFO] [stderr] Compiling gdk-pixbuf v0.1.2 [INFO] [stderr] Compiling gdk v0.5.2 [INFO] [stderr] Compiling gtk v0.1.2 [INFO] [stderr] Compiling gio-sys v0.3.3 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.3 [INFO] [stderr] Compiling pango-sys v0.3.3 [INFO] [stderr] Compiling gdk-sys v0.3.3 [INFO] [stderr] Compiling gtk-sys v0.3.3 [INFO] [stderr] Checking clap v2.24.1 [INFO] [stderr] Checking pango v0.1.2 [INFO] [stderr] Checking turing v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turing.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | turing_machine: turing_machine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `turing_machine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turing.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | next_state: next_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turing.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | transition_rules: transition_rules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transition_rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/turing.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | write!(f, "Number of states: {}\n", self.num_states())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/turing.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | write!(f, "Initial state: {}\n", self.initial_state())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/turing.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | write!(f, " {}: 0 -> {}; 1 -> {}\n", state, action0, action1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turing.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | turing_machine: turing_machine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `turing_machine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turing.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | next_state: next_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turing.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | transition_rules: transition_rules, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transition_rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/turing.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | write!(f, "Number of states: {}\n", self.num_states())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/turing.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | write!(f, "Initial state: {}\n", self.initial_state())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/turing.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | write!(f, " {}: 0 -> {}; 1 -> {}\n", state, action0, action1)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turing.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return self.is_halted(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_halted()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turing.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | return self.is_halted(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.is_halted()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let ref computation = gui_state.run; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------- help: try: `let computation = &gui_state.run;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | cr.rectangle((j as f64)*CELL_WIDTH, 0.0, CELL_WIDTH, CELL_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | cr.move_to((computation.tape_head_position() - gui_state.view_start) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(computation.tape_head_position() - gui_state.view_start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | let ref computation = gui_state.run; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------------- help: try: `let computation = &gui_state.run;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | cr.rectangle((j as f64)*CELL_WIDTH, 0.0, CELL_WIDTH, CELL_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(j)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | cr.move_to((computation.tape_head_position() - gui_state.view_start) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(computation.tape_head_position() - gui_state.view_start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.71s [INFO] running `"docker" "inspect" "850ca5830674af5c54750d13198cf77f0a63273bbd6308503e7b02cf2909c53a"` [INFO] running `"docker" "rm" "-f" "850ca5830674af5c54750d13198cf77f0a63273bbd6308503e7b02cf2909c53a"` [INFO] [stdout] 850ca5830674af5c54750d13198cf77f0a63273bbd6308503e7b02cf2909c53a