[INFO] updating cached repository itadinanta/gfx-gtk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/itadinanta/gfx-gtk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/itadinanta/gfx-gtk" "work/ex/clippy-test-run/sources/stable/gh/itadinanta/gfx-gtk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/itadinanta/gfx-gtk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/itadinanta/gfx-gtk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itadinanta/gfx-gtk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itadinanta/gfx-gtk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fdd09da97ed8e470eeec73c232f59367c9e87285 [INFO] sha for GitHub repo itadinanta/gfx-gtk: fdd09da97ed8e470eeec73c232f59367c9e87285 [INFO] validating manifest of itadinanta/gfx-gtk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of itadinanta/gfx-gtk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing itadinanta/gfx-gtk [INFO] finished frobbing itadinanta/gfx-gtk [INFO] frobbed toml for itadinanta/gfx-gtk written to work/ex/clippy-test-run/sources/stable/gh/itadinanta/gfx-gtk/Cargo.toml [INFO] started frobbing itadinanta/gfx-gtk [INFO] finished frobbing itadinanta/gfx-gtk [INFO] frobbed toml for itadinanta/gfx-gtk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/itadinanta/gfx-gtk/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting itadinanta/gfx-gtk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/itadinanta/gfx-gtk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86aab74b794f788be1d6db2772cb93b51d3da644efd609a07a96bf1b0cbd56d3 [INFO] running `"docker" "start" "-a" "86aab74b794f788be1d6db2772cb93b51d3da644efd609a07a96bf1b0cbd56d3"` [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling gio v0.5.1 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Checking glib v0.6.1 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling epoxy v0.1.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Compiling derivative v1.0.2 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx-gtk v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dl.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | move |s| loader.get_proc_addr(s).unwrap_or_else(|| ptr::null()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `ptr::null` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/dl.rs:18:50 [INFO] [stderr] | [INFO] [stderr] 18 | move |s| loader.get_proc_addr(s).unwrap_or_else(|| ptr::null()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `ptr::null` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/setup.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | let ref vp = new_context.viewport(); [INFO] [stderr] | ----^^^^^^-------------------------- help: try: `let vp = &new_context.viewport();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/setup.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | let ref mut ctx = new_context.gfx_context_mut(); [INFO] [stderr] | ----^^^^^^^^^^^--------------------------------- help: try: `let ctx = &mut new_context.gfx_context_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 09s [INFO] running `"docker" "inspect" "86aab74b794f788be1d6db2772cb93b51d3da644efd609a07a96bf1b0cbd56d3"` [INFO] running `"docker" "rm" "-f" "86aab74b794f788be1d6db2772cb93b51d3da644efd609a07a96bf1b0cbd56d3"` [INFO] [stdout] 86aab74b794f788be1d6db2772cb93b51d3da644efd609a07a96bf1b0cbd56d3