[INFO] updating cached repository isthisnagee/rust-grid [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/isthisnagee/rust-grid [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/isthisnagee/rust-grid" "work/ex/clippy-test-run/sources/stable/gh/isthisnagee/rust-grid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/isthisnagee/rust-grid'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/isthisnagee/rust-grid" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isthisnagee/rust-grid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isthisnagee/rust-grid'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22dd8f4016664a3a5c6726987c4e62f8884ed24d [INFO] sha for GitHub repo isthisnagee/rust-grid: 22dd8f4016664a3a5c6726987c4e62f8884ed24d [INFO] validating manifest of isthisnagee/rust-grid on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of isthisnagee/rust-grid on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing isthisnagee/rust-grid [INFO] finished frobbing isthisnagee/rust-grid [INFO] frobbed toml for isthisnagee/rust-grid written to work/ex/clippy-test-run/sources/stable/gh/isthisnagee/rust-grid/Cargo.toml [INFO] started frobbing isthisnagee/rust-grid [INFO] finished frobbing isthisnagee/rust-grid [INFO] frobbed toml for isthisnagee/rust-grid written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isthisnagee/rust-grid/Cargo.toml [INFO] crate isthisnagee/rust-grid has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting isthisnagee/rust-grid against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/isthisnagee/rust-grid:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97e1fbcfcd5dfe7041b7a40da60b2bb7681568af2dce7c2cdac6a585c69465ec [INFO] running `"docker" "start" "-a" "97e1fbcfcd5dfe7041b7a40da60b2bb7681568af2dce7c2cdac6a585c69465ec"` [INFO] [stderr] Compiling cairo-rs v0.3.0 [INFO] [stderr] Compiling glib-sys v0.5.0 [INFO] [stderr] Compiling gobject-sys v0.5.0 [INFO] [stderr] Compiling cairo-sys-rs v0.5.0 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking glib v0.4.1 [INFO] [stderr] Checking noise v0.5.0 [INFO] [stderr] Checking art v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return Coord { [INFO] [stderr] 73 | | x: self.x as f64, [INFO] [stderr] 74 | | y: self.y as f64, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | Coord { [INFO] [stderr] 73 | x: self.x as f64, [INFO] [stderr] 74 | y: self.y as f64, [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return [self.x + 0.13, self.y - 0.42, 1.2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.x + 0.13, self.y - 0.42, 1.2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ordering::Greater; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return Ordering::Greater; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.x == other.x && self.y == other.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x == other.x && self.y == other.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | return self.top_left; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.top_left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / return Quad { [INFO] [stderr] 250 | | bottom_left: f_v, [INFO] [stderr] 251 | | bottom_right: f_v + Coord { x: dist, y: 0. }, [INFO] [stderr] 252 | | top_right: f_v + Coord { x: dist, y: dist }, [INFO] [stderr] 253 | | top_left: f_v + Coord { x: 0., y: dist }, [INFO] [stderr] 254 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 249 | Quad { [INFO] [stderr] 250 | bottom_left: f_v, [INFO] [stderr] 251 | bottom_right: f_v + Coord { x: dist, y: 0. }, [INFO] [stderr] 252 | top_right: f_v + Coord { x: dist, y: dist }, [INFO] [stderr] 253 | top_left: f_v + Coord { x: 0., y: dist }, [INFO] [stderr] 254 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | / return Quad { [INFO] [stderr] 269 | | bottom_left: self.bottom_left + Coord { x: p1, y: p1 }, [INFO] [stderr] 270 | | bottom_right: self.bottom_right + Coord { x: p2, y: p2 }, [INFO] [stderr] 271 | | top_left: self.top_left + Coord { x: p3, y: p3 }, [INFO] [stderr] 272 | | top_right: self.top_right + Coord { x: p4, y: p4 }, [INFO] [stderr] 273 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 268 | Quad { [INFO] [stderr] 269 | bottom_left: self.bottom_left + Coord { x: p1, y: p1 }, [INFO] [stderr] 270 | bottom_right: self.bottom_right + Coord { x: p2, y: p2 }, [INFO] [stderr] 271 | top_left: self.top_left + Coord { x: p3, y: p3 }, [INFO] [stderr] 272 | top_right: self.top_right + Coord { x: p4, y: p4 }, [INFO] [stderr] 273 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | return grid; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | context.rectangle(0., 0., scaled_width as f64, scaled_height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scaled_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:52 [INFO] [stderr] | [INFO] [stderr] 31 | context.rectangle(0., 0., scaled_width as f64, scaled_height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scaled_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn to_f64(&self) -> Coord { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | x: self.x as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | y: self.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | if (self.x < other.x) || (self.x == other.x && self.y < other.y) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.x - other.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | if (self.x < other.x) || (self.x == other.x && self.y < other.y) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | let ref mut between = |v: i32| { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 235 | let between = &mut (|v: i32| { [INFO] [stderr] 236 | rand::seq::sample_iter(&mut rng, 3..(v / 2 - 3), 1) [INFO] [stderr] 237 | .unwrap() [INFO] [stderr] 238 | .first() [INFO] [stderr] 239 | .unwrap() [INFO] [stderr] 240 | .clone() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | / rand::seq::sample_iter(&mut rng, 3..(v / 2 - 3), 1) [INFO] [stderr] 237 | | .unwrap() [INFO] [stderr] 238 | | .first() [INFO] [stderr] 239 | | .unwrap() [INFO] [stderr] 240 | | .clone() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 236 | *rand::seq::sample_iter(&mut rng, 3..(v / 2 - 3), 1) [INFO] [stderr] 237 | .unwrap() [INFO] [stderr] 238 | .first() [INFO] [stderr] 239 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:248:26 [INFO] [stderr] | [INFO] [stderr] 248 | let dist = 1.5 * scale as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:299:17 [INFO] [stderr] | [INFO] [stderr] 299 | let first = quad.first().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `quad.first()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:303:29 [INFO] [stderr] | [INFO] [stderr] 303 | while let Some(coord) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for coord in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `art`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / return Coord { [INFO] [stderr] 73 | | x: self.x as f64, [INFO] [stderr] 74 | | y: self.y as f64, [INFO] [stderr] 75 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 72 | Coord { [INFO] [stderr] 73 | x: self.x as f64, [INFO] [stderr] 74 | y: self.y as f64, [INFO] [stderr] 75 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | return [self.x + 0.13, self.y - 0.42, 1.2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[self.x + 0.13, self.y - 0.42, 1.2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ordering::Greater; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return Ordering::Greater; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Greater` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | return self.x == other.x && self.y == other.y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x == other.x && self.y == other.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | return self.top_left; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.top_left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / return Quad { [INFO] [stderr] 250 | | bottom_left: f_v, [INFO] [stderr] 251 | | bottom_right: f_v + Coord { x: dist, y: 0. }, [INFO] [stderr] 252 | | top_right: f_v + Coord { x: dist, y: dist }, [INFO] [stderr] 253 | | top_left: f_v + Coord { x: 0., y: dist }, [INFO] [stderr] 254 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 249 | Quad { [INFO] [stderr] 250 | bottom_left: f_v, [INFO] [stderr] 251 | bottom_right: f_v + Coord { x: dist, y: 0. }, [INFO] [stderr] 252 | top_right: f_v + Coord { x: dist, y: dist }, [INFO] [stderr] 253 | top_left: f_v + Coord { x: 0., y: dist }, [INFO] [stderr] 254 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | / return Quad { [INFO] [stderr] 269 | | bottom_left: self.bottom_left + Coord { x: p1, y: p1 }, [INFO] [stderr] 270 | | bottom_right: self.bottom_right + Coord { x: p2, y: p2 }, [INFO] [stderr] 271 | | top_left: self.top_left + Coord { x: p3, y: p3 }, [INFO] [stderr] 272 | | top_right: self.top_right + Coord { x: p4, y: p4 }, [INFO] [stderr] 273 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 268 | Quad { [INFO] [stderr] 269 | bottom_left: self.bottom_left + Coord { x: p1, y: p1 }, [INFO] [stderr] 270 | bottom_right: self.bottom_right + Coord { x: p2, y: p2 }, [INFO] [stderr] 271 | top_left: self.top_left + Coord { x: p3, y: p3 }, [INFO] [stderr] 272 | top_right: self.top_right + Coord { x: p4, y: p4 }, [INFO] [stderr] 273 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | return grid; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | context.rectangle(0., 0., scaled_width as f64, scaled_height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scaled_width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:52 [INFO] [stderr] | [INFO] [stderr] 31 | context.rectangle(0., 0., scaled_width as f64, scaled_height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scaled_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn to_f64(&self) -> Coord { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | x: self.x as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | y: self.y as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | if (self.x < other.x) || (self.x == other.x && self.y < other.y) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.x - other.x).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | if (self.x < other.x) || (self.x == other.x && self.y < other.y) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:235:13 [INFO] [stderr] | [INFO] [stderr] 235 | let ref mut between = |v: i32| { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 235 | let between = &mut (|v: i32| { [INFO] [stderr] 236 | rand::seq::sample_iter(&mut rng, 3..(v / 2 - 3), 1) [INFO] [stderr] 237 | .unwrap() [INFO] [stderr] 238 | .first() [INFO] [stderr] 239 | .unwrap() [INFO] [stderr] 240 | .clone() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | / rand::seq::sample_iter(&mut rng, 3..(v / 2 - 3), 1) [INFO] [stderr] 237 | | .unwrap() [INFO] [stderr] 238 | | .first() [INFO] [stderr] 239 | | .unwrap() [INFO] [stderr] 240 | | .clone() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 236 | *rand::seq::sample_iter(&mut rng, 3..(v / 2 - 3), 1) [INFO] [stderr] 237 | .unwrap() [INFO] [stderr] 238 | .first() [INFO] [stderr] 239 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:248:26 [INFO] [stderr] | [INFO] [stderr] 248 | let dist = 1.5 * scale as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:299:17 [INFO] [stderr] | [INFO] [stderr] 299 | let first = quad.first().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `quad.first()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:303:29 [INFO] [stderr] | [INFO] [stderr] 303 | while let Some(coord) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for coord in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `art`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "97e1fbcfcd5dfe7041b7a40da60b2bb7681568af2dce7c2cdac6a585c69465ec"` [INFO] running `"docker" "rm" "-f" "97e1fbcfcd5dfe7041b7a40da60b2bb7681568af2dce7c2cdac6a585c69465ec"` [INFO] [stdout] 97e1fbcfcd5dfe7041b7a40da60b2bb7681568af2dce7c2cdac6a585c69465ec