[INFO] updating cached repository isavegas/rimworld_tools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/isavegas/rimworld_tools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/isavegas/rimworld_tools" "work/ex/clippy-test-run/sources/stable/gh/isavegas/rimworld_tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/isavegas/rimworld_tools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/isavegas/rimworld_tools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isavegas/rimworld_tools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isavegas/rimworld_tools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1f6da4399f48dc5b78125df54d8f6752c9b123f8 [INFO] sha for GitHub repo isavegas/rimworld_tools: 1f6da4399f48dc5b78125df54d8f6752c9b123f8 [INFO] validating manifest of isavegas/rimworld_tools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of isavegas/rimworld_tools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing isavegas/rimworld_tools [INFO] finished frobbing isavegas/rimworld_tools [INFO] frobbed toml for isavegas/rimworld_tools written to work/ex/clippy-test-run/sources/stable/gh/isavegas/rimworld_tools/Cargo.toml [INFO] started frobbing isavegas/rimworld_tools [INFO] finished frobbing isavegas/rimworld_tools [INFO] frobbed toml for isavegas/rimworld_tools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isavegas/rimworld_tools/Cargo.toml [INFO] crate isavegas/rimworld_tools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting isavegas/rimworld_tools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/isavegas/rimworld_tools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b78b048a2473da506852b5eb140f62f6028c97a120280ce4d44de832f0626efd [INFO] running `"docker" "start" "-a" "b78b048a2473da506852b5eb140f62f6028c97a120280ce4d44de832f0626efd"` [INFO] [stderr] Checking quick-xml v0.11.0 [INFO] [stderr] Checking rimworld_tools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | revision: revision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `revision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | build_number: build_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | active_mods: active_mods [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_mods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | revision: revision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `revision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | build_number: build_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | active_mods: active_mods [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_mods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/platform/linux/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const APPID: & 'static str = "294100"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const LIBRARY_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const WORKSHOP_PATH: & 'static str = "steamapps\\workshop\\content"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const GAME_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const USERDATA_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/semver.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn from_str(in_str: &str) -> Result { [INFO] [stderr] 20 | | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] 21 | | return Err(format!("Invalid semver {}", in_str)); [INFO] [stderr] 22 | | } [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:52 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | let parts = in_str.split(".").map(|s| s.parse() ).collect::>>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mod_info/loader.rs:18:42 [INFO] [stderr] | [INFO] [stderr] 18 | let mut about_xml_path_buf = PathBuf::from(entry.path().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `entry.path().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mod_info/loader.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | if text.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mod_info::ModMetaData` [INFO] [stderr] --> src/mod_info/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> ModMetaData { [INFO] [stderr] 18 | | ModMetaData { [INFO] [stderr] 19 | | author: None, [INFO] [stderr] 20 | | name: None, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mod_info::Mod` [INFO] [stderr] --> src/mod_info/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Mod { [INFO] [stderr] 36 | | Mod { [INFO] [stderr] 37 | | meta_data: ModMetaData::new(), [INFO] [stderr] 38 | | version: None, [INFO] [stderr] 39 | | id: None, [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for mod_info::Mod { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/platform/linux/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const APPID: & 'static str = "294100"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const LIBRARY_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const WORKSHOP_PATH: & 'static str = "steamapps\\workshop\\content"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const GAME_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const USERDATA_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `userdata::PrefsData` [INFO] [stderr] --> src/userdata/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> PrefsData { [INFO] [stderr] 55 | | PrefsData { [INFO] [stderr] 56 | | volume_game: 0.0, [INFO] [stderr] 57 | | volume_music: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/semver.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn from_str(in_str: &str) -> Result { [INFO] [stderr] 20 | | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] 21 | | return Err(format!("Invalid semver {}", in_str)); [INFO] [stderr] 22 | | } [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:52 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | let parts = in_str.split(".").map(|s| s.parse() ).collect::>>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mod_info/loader.rs:18:42 [INFO] [stderr] | [INFO] [stderr] 18 | let mut about_xml_path_buf = PathBuf::from(entry.path().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `entry.path().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mod_info/loader.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | if text.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mod_info::ModMetaData` [INFO] [stderr] --> src/mod_info/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> ModMetaData { [INFO] [stderr] 18 | | ModMetaData { [INFO] [stderr] 19 | | author: None, [INFO] [stderr] 20 | | name: None, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `mod_info::Mod` [INFO] [stderr] --> src/mod_info/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Mod { [INFO] [stderr] 36 | | Mod { [INFO] [stderr] 37 | | meta_data: ModMetaData::new(), [INFO] [stderr] 38 | | version: None, [INFO] [stderr] 39 | | id: None, [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for mod_info::Mod { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `userdata::PrefsData` [INFO] [stderr] --> src/userdata/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> PrefsData { [INFO] [stderr] 55 | | PrefsData { [INFO] [stderr] 56 | | volume_game: 0.0, [INFO] [stderr] 57 | | volume_music: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | revision: revision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `revision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | build_number: build_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | active_mods: active_mods [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_mods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/semver.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | revision: revision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `revision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | build_number: build_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/userdata/loader.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | active_mods: active_mods [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `active_mods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/platform/linux/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const APPID: & 'static str = "294100"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const LIBRARY_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const WORKSHOP_PATH: & 'static str = "steamapps\\workshop\\content"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const GAME_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const USERDATA_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> tests/semver.rs:128:54 [INFO] [stderr] | [INFO] [stderr] 128 | assert!(Version::new(0, 1, 0).to_string() == String::from("0.1.0"), "to_string should output valid semver") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"0.1.0"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mod_info/loader.rs:18:42 [INFO] [stderr] | [INFO] [stderr] 18 | let mut about_xml_path_buf = PathBuf::from(entry.path().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `entry.path().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mod_info/loader.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | if text.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:52 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | let parts = in_str.split(".").map(|s| s.parse() ).collect::>>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/platform/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod platform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/platform/linux/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | const APPID: & 'static str = "294100"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:8:23 [INFO] [stderr] | [INFO] [stderr] 8 | const LIBRARY_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const WORKSHOP_PATH: & 'static str = "steamapps\\workshop\\content"; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | const GAME_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/platform/linux/mod.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const USERDATA_PATH: & 'static str = ""; [INFO] [stderr] | --^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:45:47 [INFO] [stderr] | [INFO] [stderr] 45 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `current_rimworld_version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:60:24 [INFO] [stderr] | [INFO] [stderr] 60 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `current_rimworld_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mod_info/loader.rs:18:42 [INFO] [stderr] | [INFO] [stderr] 18 | let mut about_xml_path_buf = PathBuf::from(entry.path().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `entry.path().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/mod_info/loader.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | if text.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:28 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:20:52 [INFO] [stderr] | [INFO] [stderr] 20 | if in_str.contains("+") || in_str.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/semver.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | let parts = in_str.split(".").map(|s| s.parse() ).collect::>>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:45:24 [INFO] [stderr] | [INFO] [stderr] 45 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:45:47 [INFO] [stderr] | [INFO] [stderr] 45 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `current_rimworld_version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:60:24 [INFO] [stderr] | [INFO] [stderr] 60 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | outdated = mods.iter().filter(|m| m.meta_data.target_version.as_ref().unwrap_or(&blank_version) < ¤t_rimworld_version).map(|m| m.clone()).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `current_rimworld_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.46s [INFO] running `"docker" "inspect" "b78b048a2473da506852b5eb140f62f6028c97a120280ce4d44de832f0626efd"` [INFO] running `"docker" "rm" "-f" "b78b048a2473da506852b5eb140f62f6028c97a120280ce4d44de832f0626efd"` [INFO] [stdout] b78b048a2473da506852b5eb140f62f6028c97a120280ce4d44de832f0626efd