[INFO] updating cached repository isaacd9/ruthp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/isaacd9/ruthp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/isaacd9/ruthp" "work/ex/clippy-test-run/sources/stable/gh/isaacd9/ruthp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/isaacd9/ruthp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/isaacd9/ruthp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isaacd9/ruthp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isaacd9/ruthp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 069864e864f964da48df590821807697b01e051e [INFO] sha for GitHub repo isaacd9/ruthp: 069864e864f964da48df590821807697b01e051e [INFO] validating manifest of isaacd9/ruthp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of isaacd9/ruthp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing isaacd9/ruthp [INFO] finished frobbing isaacd9/ruthp [INFO] frobbed toml for isaacd9/ruthp written to work/ex/clippy-test-run/sources/stable/gh/isaacd9/ruthp/Cargo.toml [INFO] started frobbing isaacd9/ruthp [INFO] finished frobbing isaacd9/ruthp [INFO] frobbed toml for isaacd9/ruthp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/isaacd9/ruthp/Cargo.toml [INFO] crate isaacd9/ruthp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting isaacd9/ruthp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/isaacd9/ruthp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0560cc7a66d0b763c9ccf031beea72134e87feacc5fecece6307d0bcdd09fa98 [INFO] running `"docker" "start" "-a" "0560cc7a66d0b763c9ccf031beea72134e87feacc5fecece6307d0bcdd09fa98"` [INFO] [stderr] Checking lisp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / return match st { [INFO] [stderr] 19 | | "+" => Token::Operator(Operator::Plus), [INFO] [stderr] 20 | | _ => Token::Unknown [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | match st { [INFO] [stderr] 19 | "+" => Token::Operator(Operator::Plus), [INFO] [stderr] 20 | _ => Token::Unknown [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return replaced.split_whitespace().map(|ch| { [INFO] [stderr] 27 | | match ch.chars().next().unwrap() { [INFO] [stderr] 28 | | '(' => Token::LeftParen, [INFO] [stderr] 29 | | ')' => Token::RightParen, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }).collect(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | replaced.split_whitespace().map(|ch| { [INFO] [stderr] 27 | match ch.chars().next().unwrap() { [INFO] [stderr] 28 | '(' => Token::LeftParen, [INFO] [stderr] 29 | ')' => Token::RightParen, [INFO] [stderr] 30 | '+' | '-' | '*' | '/' => tokenize_operator(ch), [INFO] [stderr] 31 | '0' ... '9' => match ch.parse::() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | return Result::Ok((vec![], rest.to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok((vec![], rest.to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | _ => return Result::Err("parse error"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err("parse error")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / return match st { [INFO] [stderr] 19 | | "+" => Token::Operator(Operator::Plus), [INFO] [stderr] 20 | | _ => Token::Unknown [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | match st { [INFO] [stderr] 19 | "+" => Token::Operator(Operator::Plus), [INFO] [stderr] 20 | _ => Token::Unknown [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / return replaced.split_whitespace().map(|ch| { [INFO] [stderr] 27 | | match ch.chars().next().unwrap() { [INFO] [stderr] 28 | | '(' => Token::LeftParen, [INFO] [stderr] 29 | | ')' => Token::RightParen, [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }).collect(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | replaced.split_whitespace().map(|ch| { [INFO] [stderr] 27 | match ch.chars().next().unwrap() { [INFO] [stderr] 28 | '(' => Token::LeftParen, [INFO] [stderr] 29 | ')' => Token::RightParen, [INFO] [stderr] 30 | '+' | '-' | '*' | '/' => tokenize_operator(ch), [INFO] [stderr] 31 | '0' ... '9' => match ch.parse::() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | return Result::Ok((vec![], rest.to_vec())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok((vec![], rest.to_vec()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | _ => return Result::Err("parse error"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err("parse error")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Add` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | Add, [INFO] [stderr] | ^^^ [INFO] [stderr] warning: variant is never constructed: `Add` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | Add, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "0560cc7a66d0b763c9ccf031beea72134e87feacc5fecece6307d0bcdd09fa98"` [INFO] running `"docker" "rm" "-f" "0560cc7a66d0b763c9ccf031beea72134e87feacc5fecece6307d0bcdd09fa98"` [INFO] [stdout] 0560cc7a66d0b763c9ccf031beea72134e87feacc5fecece6307d0bcdd09fa98