[INFO] updating cached repository irony-rust/nickel-cms [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/irony-rust/nickel-cms [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/irony-rust/nickel-cms" "work/ex/clippy-test-run/sources/stable/gh/irony-rust/nickel-cms"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/irony-rust/nickel-cms'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/irony-rust/nickel-cms" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/irony-rust/nickel-cms"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/irony-rust/nickel-cms'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b1453be37ccbef8e188618f2a013cc322e0f1019 [INFO] sha for GitHub repo irony-rust/nickel-cms: b1453be37ccbef8e188618f2a013cc322e0f1019 [INFO] validating manifest of irony-rust/nickel-cms on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of irony-rust/nickel-cms on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing irony-rust/nickel-cms [INFO] finished frobbing irony-rust/nickel-cms [INFO] frobbed toml for irony-rust/nickel-cms written to work/ex/clippy-test-run/sources/stable/gh/irony-rust/nickel-cms/Cargo.toml [INFO] started frobbing irony-rust/nickel-cms [INFO] finished frobbing irony-rust/nickel-cms [INFO] frobbed toml for irony-rust/nickel-cms written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/irony-rust/nickel-cms/Cargo.toml [INFO] crate irony-rust/nickel-cms has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting irony-rust/nickel-cms against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/irony-rust/nickel-cms:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a37fd80ae7efe73a1a52ba61cae63a99d891c4a969f963ba2ffe12cd80ffdec2 [INFO] running `"docker" "start" "-a" "a37fd80ae7efe73a1a52ba61cae63a99d891c4a969f963ba2ffe12cd80ffdec2"` [INFO] [stderr] Compiling byteorder v1.0.0 [INFO] [stderr] Compiling nom v2.2.1 [INFO] [stderr] Compiling md5 v0.3.5 [INFO] [stderr] Checking unidecode v0.2.0 [INFO] [stderr] Checking humansize v1.0.1 [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Checking base64 v0.3.1 [INFO] [stderr] Checking mustache v0.8.0 [INFO] [stderr] Checking toml v0.2.1 [INFO] [stderr] Checking ructe v0.3.0 [INFO] [stderr] Checking url v1.5.0 [INFO] [stderr] Checking chrono v0.3.1 [INFO] [stderr] Checking slug v0.1.2 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Compiling nickel-cms v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking nickel v0.10.0 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking tera v0.10.6 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/form_validator.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | Validators { validators: validators } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validators` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/form_validator.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | Validators { validators: validators } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `validators` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/middleware/form_validator.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / macro_rules! parse_field { [INFO] [stderr] 19 | | ( $field:expr, $vtype:ty ) => {{ [INFO] [stderr] 20 | | $field.parse::<$vtype>() [INFO] [stderr] 21 | | }}; [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `vtype` [INFO] [stderr] --> src/middleware/form_validator.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | fn type_ref_parser(vtype: i32){ [INFO] [stderr] | ^^^^^ help: consider using `_vtype` instead [INFO] [stderr] | [INFO] [stderr] ::: src/admin/models/pages.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / validators! ( [INFO] [stderr] 29 | | ["done.a", "age"]: f32 => required(), max(1); [INFO] [stderr] 30 | | ["age", "tst4"]: i32 => max(1, "2+"); [INFO] [stderr] 31 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware/form_validator.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | let mut err = validation_errors.get_mut(&field).unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `type_ref_parser` [INFO] [stderr] --> src/middleware/form_validator.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | fn type_ref_parser(vtype: i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/admin/models/pages.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / validators! ( [INFO] [stderr] 29 | | ["done.a", "age"]: f32 => required(), max(1); [INFO] [stderr] 30 | | ["age", "tst4"]: i32 => max(1, "2+"); [INFO] [stderr] 31 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/middleware/render.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn render<'mw, T, F>(res: Response<'mw, T>, do_render: F) [INFO] [stderr] 9 | | -> MiddlewareResult<'mw, T> [INFO] [stderr] 10 | | where F: FnOnce(&mut io::Write) -> io::Result<()> [INFO] [stderr] 11 | | { [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/middleware/form_validator.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | Validators::new(Self::validators()).create_validator(&form_data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/middleware/form_validator.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | / macro_rules! parse_field { [INFO] [stderr] 19 | | ( $field:expr, $vtype:ty ) => {{ [INFO] [stderr] 20 | | $field.parse::<$vtype>() [INFO] [stderr] 21 | | }}; [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_header.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_header.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_footer.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_sidebar.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_create.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_form.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_options.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_formjs.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_tabs.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_index.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/main/template_index.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/helpers/template_css.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/helpers/template_js.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `admin::handlers::HeaderData<'a>` [INFO] [stderr] --> src/admin/handlers/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> HeaderData<'a> { [INFO] [stderr] 28 | | HeaderData { [INFO] [stderr] 29 | | title: "", [INFO] [stderr] 30 | | keyword: "", [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/admin/handlers/mod.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | if self.action == action { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `self.action == action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nickel-cms`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `vtype` [INFO] [stderr] --> src/middleware/form_validator.rs:27:28 [INFO] [stderr] | [INFO] [stderr] 27 | fn type_ref_parser(vtype: i32){ [INFO] [stderr] | ^^^^^ help: consider using `_vtype` instead [INFO] [stderr] | [INFO] [stderr] ::: src/admin/models/pages.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / validators! ( [INFO] [stderr] 29 | | ["done.a", "age"]: f32 => required(), max(1); [INFO] [stderr] 30 | | ["age", "tst4"]: i32 => max(1, "2+"); [INFO] [stderr] 31 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/middleware/form_validator.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | let mut err = validation_errors.get_mut(&field).unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `type_ref_parser` [INFO] [stderr] --> src/middleware/form_validator.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | fn type_ref_parser(vtype: i32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/admin/models/pages.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / validators! ( [INFO] [stderr] 29 | | ["done.a", "age"]: f32 => required(), max(1); [INFO] [stderr] 30 | | ["age", "tst4"]: i32 => max(1, "2+"); [INFO] [stderr] 31 | | ) [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/middleware/render.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn render<'mw, T, F>(res: Response<'mw, T>, do_render: F) [INFO] [stderr] 9 | | -> MiddlewareResult<'mw, T> [INFO] [stderr] 10 | | where F: FnOnce(&mut io::Write) -> io::Result<()> [INFO] [stderr] 11 | | { [INFO] [stderr] ... | [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/middleware/form_validator.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | Validators::new(Self::validators()).create_validator(&form_data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_header.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_header.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_footer.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/layout/template_sidebar.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_create.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_form.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_options.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_formjs.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_tabs.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/pages/template_index.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/admin/main/template_index.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/helpers/template_css.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> /opt/crater/target/debug/build/nickel-cms-8ce35cf9aee19252/out/templates/helpers/template_js.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `admin::handlers::HeaderData<'a>` [INFO] [stderr] --> src/admin/handlers/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> HeaderData<'a> { [INFO] [stderr] 28 | | HeaderData { [INFO] [stderr] 29 | | title: "", [INFO] [stderr] 30 | | keyword: "", [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/admin/handlers/mod.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | if self.action == action { true } else { false } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `self.action == action` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nickel-cms`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a37fd80ae7efe73a1a52ba61cae63a99d891c4a969f963ba2ffe12cd80ffdec2"` [INFO] running `"docker" "rm" "-f" "a37fd80ae7efe73a1a52ba61cae63a99d891c4a969f963ba2ffe12cd80ffdec2"` [INFO] [stdout] a37fd80ae7efe73a1a52ba61cae63a99d891c4a969f963ba2ffe12cd80ffdec2