[INFO] updating cached repository ironlang/iron [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ironlang/iron [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ironlang/iron" "work/ex/clippy-test-run/sources/stable/gh/ironlang/iron"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ironlang/iron'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ironlang/iron" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ironlang/iron"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ironlang/iron'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89b83145292eccbc48292b92d143f164928f1855 [INFO] sha for GitHub repo ironlang/iron: 89b83145292eccbc48292b92d143f164928f1855 [INFO] validating manifest of ironlang/iron on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ironlang/iron on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ironlang/iron [INFO] finished frobbing ironlang/iron [INFO] frobbed toml for ironlang/iron written to work/ex/clippy-test-run/sources/stable/gh/ironlang/iron/Cargo.toml [INFO] started frobbing ironlang/iron [INFO] finished frobbing ironlang/iron [INFO] frobbed toml for ironlang/iron written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ironlang/iron/Cargo.toml [INFO] crate ironlang/iron has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ironlang/iron against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ironlang/iron:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c7ec0d82ce40e0fc58c997e658ede151307a4f46394babe873b6db0a54e95c5 [INFO] running `"docker" "start" "-a" "7c7ec0d82ce40e0fc58c997e658ede151307a4f46394babe873b6db0a54e95c5"` [INFO] [stderr] Compiling cranelift-entity v0.25.0 [INFO] [stderr] Compiling target-lexicon v0.2.0 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking cranelift-bforest v0.25.0 [INFO] [stderr] Compiling cranelift-codegen-meta v0.25.0 [INFO] [stderr] Compiling cranelift-codegen v0.25.0 [INFO] [stderr] Checking cranelift-frontend v0.25.0 [INFO] [stderr] Checking iron v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return _result; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | / return Ok(Expression::Prototype { [INFO] [stderr] 51 | | name, [INFO] [stderr] 52 | | parameters, [INFO] [stderr] 53 | | returns: vec![] [INFO] [stderr] 54 | | }); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | Ok(Expression::Prototype { [INFO] [stderr] 51 | name, [INFO] [stderr] 52 | parameters, [INFO] [stderr] 53 | returns: vec![] [INFO] [stderr] 54 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | Token::OpenBrace => return Ok(Expression::Prototype { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 57 | | name, parameters: vec![], returns: vec![] }), [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | Token::OpenBrace => Ok(Expression::Prototype { [INFO] [stderr] 57 | name, parameters: vec![], returns: vec![] }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/iron/codegen.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/iron/codegen.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::token::Token` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use iron::token::Token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::expression::Expression` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use iron::expression::Expression; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return _result; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | / return Ok(Expression::Prototype { [INFO] [stderr] 51 | | name, [INFO] [stderr] 52 | | parameters, [INFO] [stderr] 53 | | returns: vec![] [INFO] [stderr] 54 | | }); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 50 | Ok(Expression::Prototype { [INFO] [stderr] 51 | name, [INFO] [stderr] 52 | parameters, [INFO] [stderr] 53 | returns: vec![] [INFO] [stderr] 54 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | Token::OpenBrace => return Ok(Expression::Prototype { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 57 | | name, parameters: vec![], returns: vec![] }), [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | Token::OpenBrace => Ok(Expression::Prototype { [INFO] [stderr] 57 | name, parameters: vec![], returns: vec![] }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/iron/parser.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return parameters; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/iron/codegen.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/iron/codegen.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(source) = matches.value_of("INPUT") { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::token::Token` [INFO] [stderr] --> src/main.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use iron::token::Token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `iron::expression::Expression` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use iron::expression::Expression; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/main.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(source) = matches.value_of("INPUT") { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.80s [INFO] running `"docker" "inspect" "7c7ec0d82ce40e0fc58c997e658ede151307a4f46394babe873b6db0a54e95c5"` [INFO] running `"docker" "rm" "-f" "7c7ec0d82ce40e0fc58c997e658ede151307a4f46394babe873b6db0a54e95c5"` [INFO] [stdout] 7c7ec0d82ce40e0fc58c997e658ede151307a4f46394babe873b6db0a54e95c5