[INFO] updating cached repository irekf/rusty-csv-diff
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/irekf/rusty-csv-diff
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/irekf/rusty-csv-diff" "work/ex/clippy-test-run/sources/stable/gh/irekf/rusty-csv-diff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/irekf/rusty-csv-diff'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/irekf/rusty-csv-diff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/irekf/rusty-csv-diff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/irekf/rusty-csv-diff'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c7ed7312545ccabea74c935433d0262d6b38a288
[INFO] sha for GitHub repo irekf/rusty-csv-diff: c7ed7312545ccabea74c935433d0262d6b38a288
[INFO] validating manifest of irekf/rusty-csv-diff on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of irekf/rusty-csv-diff on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing irekf/rusty-csv-diff
[INFO] finished frobbing irekf/rusty-csv-diff
[INFO] frobbed toml for irekf/rusty-csv-diff written to work/ex/clippy-test-run/sources/stable/gh/irekf/rusty-csv-diff/Cargo.toml
[INFO] started frobbing irekf/rusty-csv-diff
[INFO] finished frobbing irekf/rusty-csv-diff
[INFO] frobbed toml for irekf/rusty-csv-diff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/irekf/rusty-csv-diff/Cargo.toml
[INFO] crate irekf/rusty-csv-diff has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting irekf/rusty-csv-diff against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/irekf/rusty-csv-diff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b799ff7d2bf98770fa4e5a5f23ac61a76fe8142897863d3633d7e90fa193ee8e
[INFO] running `"docker" "start" "-a" "b799ff7d2bf98770fa4e5a5f23ac61a76fe8142897863d3633d7e90fa193ee8e"`
[INFO] [stderr]     Checking libc v0.2.37
[INFO] [stderr]     Checking memchr v2.0.1
[INFO] [stderr]     Checking aho-corasick v0.6.4
[INFO] [stderr]     Checking regex v0.2.6
[INFO] [stderr]     Checking docopt v0.8.3
[INFO] [stderr]     Checking rusty-csv-diff v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:52:15
[INFO] [stderr]    |
[INFO] [stderr] 52 |     path_arg: &'a String,
[INFO] [stderr]    |               ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:53:20
[INFO] [stderr]    |
[INFO] [stderr] 53 |     delimiter_arg: &'a String,
[INFO] [stderr]    |                    ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:54:16
[INFO] [stderr]    |
[INFO] [stderr] 54 |     quote_arg: &'a String,
[INFO] [stderr]    |                ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 | /     loop {
[INFO] [stderr] 123 | |         let csv_row: String = match csv_line_iter.next() {
[INFO] [stderr] 124 | |             Some(result) => match result {
[INFO] [stderr] 125 | |                 Err(why) => return Err(format!("error getting csv row: {}", why)),
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |         offset_in_file += (csv_row.len() + 1) as u64;
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(result) = csv_line_iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:181:35
[INFO] [stderr]     |
[INFO] [stderr] 181 |             if row_buff.ends_with("\n") {
[INFO] [stderr]     |                                   ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/main.rs:217:1
[INFO] [stderr]     |
[INFO] [stderr] 217 | / fn main() {
[INFO] [stderr] 218 | |     /*
[INFO] [stderr] 219 | |
[INFO] [stderr] 220 | | 1. Parse arguments
[INFO] [stderr] ...   |
[INFO] [stderr] 355 | |     }
[INFO] [stderr] 356 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `csv_cols_1`
[INFO] [stderr]    --> src/main.rs:271:14
[INFO] [stderr]     |
[INFO] [stderr] 271 |     for i in 0..csv_cols_1.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 271 |     for (i, <item>) in csv_cols_1.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `csv_cols_2`
[INFO] [stderr]    --> src/main.rs:281:14
[INFO] [stderr]     |
[INFO] [stderr] 281 |     for i in 0..csv_cols_2.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 281 |     for (i, <item>) in csv_cols_2.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:322:24
[INFO] [stderr]     |
[INFO] [stderr] 322 |         let index_1 = *csv_index_1.get(row_key).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_index_1[row_key]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:323:24
[INFO] [stderr]     |
[INFO] [stderr] 323 |         let index_2 = *csv_index_2.get(row_key).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_index_2[row_key]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:340:32
[INFO] [stderr]     |
[INFO] [stderr] 340 |             let col_index_1 = *csv_col_index_1.get(*col).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_col_index_1[*col]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:341:32
[INFO] [stderr]     |
[INFO] [stderr] 341 |             let col_index_2 = *csv_col_index_2.get(*col).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_col_index_2[*col]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:52:15
[INFO] [stderr]    |
[INFO] [stderr] 52 |     path_arg: &'a String,
[INFO] [stderr]    |               ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:53:20
[INFO] [stderr]    |
[INFO] [stderr] 53 |     delimiter_arg: &'a String,
[INFO] [stderr]    |                    ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:54:16
[INFO] [stderr]    |
[INFO] [stderr] 54 |     quote_arg: &'a String,
[INFO] [stderr]    |                ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 | /     loop {
[INFO] [stderr] 123 | |         let csv_row: String = match csv_line_iter.next() {
[INFO] [stderr] 124 | |             Some(result) => match result {
[INFO] [stderr] 125 | |                 Err(why) => return Err(format!("error getting csv row: {}", why)),
[INFO] [stderr] ...   |
[INFO] [stderr] 156 | |         offset_in_file += (csv_row.len() + 1) as u64;
[INFO] [stderr] 157 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(result) = csv_line_iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:181:35
[INFO] [stderr]     |
[INFO] [stderr] 181 |             if row_buff.ends_with("\n") {
[INFO] [stderr]     |                                   ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 28
[INFO] [stderr]    --> src/main.rs:217:1
[INFO] [stderr]     |
[INFO] [stderr] 217 | / fn main() {
[INFO] [stderr] 218 | |     /*
[INFO] [stderr] 219 | |
[INFO] [stderr] 220 | | 1. Parse arguments
[INFO] [stderr] ...   |
[INFO] [stderr] 355 | |     }
[INFO] [stderr] 356 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `csv_cols_1`
[INFO] [stderr]    --> src/main.rs:271:14
[INFO] [stderr]     |
[INFO] [stderr] 271 |     for i in 0..csv_cols_1.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 271 |     for (i, <item>) in csv_cols_1.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `csv_cols_2`
[INFO] [stderr]    --> src/main.rs:281:14
[INFO] [stderr]     |
[INFO] [stderr] 281 |     for i in 0..csv_cols_2.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 281 |     for (i, <item>) in csv_cols_2.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:322:24
[INFO] [stderr]     |
[INFO] [stderr] 322 |         let index_1 = *csv_index_1.get(row_key).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_index_1[row_key]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:323:24
[INFO] [stderr]     |
[INFO] [stderr] 323 |         let index_2 = *csv_index_2.get(row_key).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_index_2[row_key]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:340:32
[INFO] [stderr]     |
[INFO] [stderr] 340 |             let col_index_1 = *csv_col_index_1.get(*col).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_col_index_1[*col]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:341:32
[INFO] [stderr]     |
[INFO] [stderr] 341 |             let col_index_2 = *csv_col_index_2.get(*col).unwrap();
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&csv_col_index_2[*col]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.74s
[INFO] running `"docker" "inspect" "b799ff7d2bf98770fa4e5a5f23ac61a76fe8142897863d3633d7e90fa193ee8e"`
[INFO] running `"docker" "rm" "-f" "b799ff7d2bf98770fa4e5a5f23ac61a76fe8142897863d3633d7e90fa193ee8e"`
[INFO] [stdout] b799ff7d2bf98770fa4e5a5f23ac61a76fe8142897863d3633d7e90fa193ee8e