[INFO] updating cached repository iquiw/rsbin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iquiw/rsbin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iquiw/rsbin" "work/ex/clippy-test-run/sources/stable/gh/iquiw/rsbin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iquiw/rsbin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iquiw/rsbin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iquiw/rsbin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iquiw/rsbin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c854c13173b7ef55089d1b4835a25f5887c6f574 [INFO] sha for GitHub repo iquiw/rsbin: c854c13173b7ef55089d1b4835a25f5887c6f574 [INFO] validating manifest of iquiw/rsbin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iquiw/rsbin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iquiw/rsbin [INFO] finished frobbing iquiw/rsbin [INFO] frobbed toml for iquiw/rsbin written to work/ex/clippy-test-run/sources/stable/gh/iquiw/rsbin/Cargo.toml [INFO] started frobbing iquiw/rsbin [INFO] finished frobbing iquiw/rsbin [INFO] frobbed toml for iquiw/rsbin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iquiw/rsbin/Cargo.toml [INFO] crate iquiw/rsbin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iquiw/rsbin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/iquiw/rsbin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12f5967f50e85fc588f99b11f09917dfe3cefc46c8f3041e5ea4080f25fb6fc3 [INFO] running `"docker" "start" "-a" "12f5967f50e85fc588f99b11f09917dfe3cefc46c8f3041e5ea4080f25fb6fc3"` [INFO] [stderr] Checking rsbin v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rsbin/os.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | let tmp = env::var("TMP").unwrap_or("/tmp".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/tmp".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rsbin/util.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(fs::create_dir(&path) [INFO] [stderr] | ____________^ [INFO] [stderr] 11 | | .with_context(|_| format!("Unable to create directory {}", path.as_ref().display()))?) [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 10 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rsbin/util.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(fs::remove_file(&path) [INFO] [stderr] | ____________^ [INFO] [stderr] 18 | | .with_context(|_| format!("Unable to delete file {}", path.as_ref().display()))?) [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 17 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rsbin/util.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | Ok(fs::remove_dir_all(&path) [INFO] [stderr] | ____________^ [INFO] [stderr] 27 | | .with_context(|_| format!("Unable to delete directory {}", path.as_ref().display()))?) [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 26 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/rsbin/os.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | let tmp = env::var("TMP").unwrap_or("/tmp".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/tmp".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rsbin/util.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | Ok(fs::create_dir(&path) [INFO] [stderr] | ____________^ [INFO] [stderr] 11 | | .with_context(|_| format!("Unable to create directory {}", path.as_ref().display()))?) [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 10 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rsbin/util.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | Ok(fs::remove_file(&path) [INFO] [stderr] | ____________^ [INFO] [stderr] 18 | | .with_context(|_| format!("Unable to delete file {}", path.as_ref().display()))?) [INFO] [stderr] | |____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 17 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/rsbin/util.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | Ok(fs::remove_dir_all(&path) [INFO] [stderr] | ____________^ [INFO] [stderr] 27 | | .with_context(|_| format!("Unable to delete directory {}", path.as_ref().display()))?) [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 26 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.16s [INFO] running `"docker" "inspect" "12f5967f50e85fc588f99b11f09917dfe3cefc46c8f3041e5ea4080f25fb6fc3"` [INFO] running `"docker" "rm" "-f" "12f5967f50e85fc588f99b11f09917dfe3cefc46c8f3041e5ea4080f25fb6fc3"` [INFO] [stdout] 12f5967f50e85fc588f99b11f09917dfe3cefc46c8f3041e5ea4080f25fb6fc3