[INFO] updating cached repository iquiw/eldep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iquiw/eldep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iquiw/eldep" "work/ex/clippy-test-run/sources/stable/gh/iquiw/eldep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iquiw/eldep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iquiw/eldep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iquiw/eldep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iquiw/eldep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f5a2df9933f1c8fbad66cfcd451ed18429820f33 [INFO] sha for GitHub repo iquiw/eldep: f5a2df9933f1c8fbad66cfcd451ed18429820f33 [INFO] validating manifest of iquiw/eldep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iquiw/eldep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iquiw/eldep [INFO] finished frobbing iquiw/eldep [INFO] frobbed toml for iquiw/eldep written to work/ex/clippy-test-run/sources/stable/gh/iquiw/eldep/Cargo.toml [INFO] started frobbing iquiw/eldep [INFO] finished frobbing iquiw/eldep [INFO] frobbed toml for iquiw/eldep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iquiw/eldep/Cargo.toml [INFO] crate iquiw/eldep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iquiw/eldep against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/iquiw/eldep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d929aa00b0dc5e3975e0542bcb6a87aa5c3dd0e46dc048cdc2e122ffb9802d00 [INFO] running `"docker" "start" "-a" "d929aa00b0dc5e3975e0542bcb6a87aa5c3dd0e46dc048cdc2e122ffb9802d00"` [INFO] [stderr] Checking tabwriter v1.0.4 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking eldep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | deps: deps, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | deps: deps, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `deps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | while let Some(arg) = args.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for arg in args { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:15 [INFO] [stderr] | [INFO] [stderr] 166 | features: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Feature]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | writeln!(&mut tw, "{}.elc", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:208:34 [INFO] [stderr] | [INFO] [stderr] 208 | fn gather_dependencies(features: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Feature]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | while let Some(arg) = args.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for arg in args { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:166:15 [INFO] [stderr] | [INFO] [stderr] 166 | features: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Feature]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | writeln!(&mut tw, "{}.elc", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:208:34 [INFO] [stderr] | [INFO] [stderr] 208 | fn gather_dependencies(features: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Feature]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.23s [INFO] running `"docker" "inspect" "d929aa00b0dc5e3975e0542bcb6a87aa5c3dd0e46dc048cdc2e122ffb9802d00"` [INFO] running `"docker" "rm" "-f" "d929aa00b0dc5e3975e0542bcb6a87aa5c3dd0e46dc048cdc2e122ffb9802d00"` [INFO] [stdout] d929aa00b0dc5e3975e0542bcb6a87aa5c3dd0e46dc048cdc2e122ffb9802d00