[INFO] updating cached repository ipost/rmosaic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ipost/rmosaic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ipost/rmosaic" "work/ex/clippy-test-run/sources/stable/gh/ipost/rmosaic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ipost/rmosaic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ipost/rmosaic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ipost/rmosaic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ipost/rmosaic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aaffff6ffbdaa9cd04a447a26844e92b2c42cb39 [INFO] sha for GitHub repo ipost/rmosaic: aaffff6ffbdaa9cd04a447a26844e92b2c42cb39 [INFO] validating manifest of ipost/rmosaic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ipost/rmosaic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ipost/rmosaic [INFO] finished frobbing ipost/rmosaic [INFO] frobbed toml for ipost/rmosaic written to work/ex/clippy-test-run/sources/stable/gh/ipost/rmosaic/Cargo.toml [INFO] started frobbing ipost/rmosaic [INFO] finished frobbing ipost/rmosaic [INFO] frobbed toml for ipost/rmosaic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ipost/rmosaic/Cargo.toml [INFO] crate ipost/rmosaic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ipost/rmosaic against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ipost/rmosaic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf7f729361398ec65decd80e2d47900cd8648bb45377d0ad93d476b832bbc174 [INFO] running `"docker" "start" "-a" "cf7f729361398ec65decd80e2d47900cd8648bb45377d0ad93d476b832bbc174"` [INFO] [stderr] Checking serde v1.0.47 [INFO] [stderr] Compiling syn v0.13.7 [INFO] [stderr] Compiling serde_derive v1.0.48 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking rmosaic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:251:25 [INFO] [stderr] | [INFO] [stderr] 251 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:251:25 [INFO] [stderr] | [INFO] [stderr] 251 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/params.rs:4:31 [INFO] [stderr] | [INFO] [stderr] 4 | const DEFAULT_MAGNIFICATION: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/params.rs:5:34 [INFO] [stderr] | [INFO] [stderr] 5 | const DEFAULT_PIXEL_GROUP_SIZE: &'static str = "16"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/params.rs:6:25 [INFO] [stderr] | [INFO] [stderr] 6 | const DEFAULT_THREADS: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | const INDEX_FILENAME: &'static str = ".mosaic_index"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/params.rs:4:31 [INFO] [stderr] | [INFO] [stderr] 4 | const DEFAULT_MAGNIFICATION: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/params.rs:5:34 [INFO] [stderr] | [INFO] [stderr] 5 | const DEFAULT_PIXEL_GROUP_SIZE: &'static str = "16"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib/params.rs:6:25 [INFO] [stderr] | [INFO] [stderr] 6 | const DEFAULT_THREADS: &'static str = "2"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | const INDEX_FILENAME: &'static str = ".mosaic_index"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib/index.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / file.write(contents.as_bytes()) [INFO] [stderr] 19 | | .expect("something went wrong while writing the file"); [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:71:10 [INFO] [stderr] | [INFO] [stderr] 71 | .expect(&format!("Error reading source image {}", source_image_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading source image {}", source_image_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | / ((((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] 78 | | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] 79 | | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] 80 | | as f64) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | f64::from(((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] 78 | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] 79 | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | ((((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d.average.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:50 [INFO] [stderr] | [INFO] [stderr] 77 | ((((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d.average.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d.average.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:79:54 [INFO] [stderr] | [INFO] [stderr] 79 | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let progress = Mutex::new(0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | .expect(&format!("Error reading image {}", source_image_path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading image {}", source_image_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | let mut p = progress.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | let bar = *p / progress_increment; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:274:21 [INFO] [stderr] | [INFO] [stderr] 274 | acc.0 + (pixel.data[0] as u64).pow(2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | acc.1 + (pixel.data[1] as u64).pow(2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:276:21 [INFO] [stderr] | [INFO] [stderr] 276 | acc.2 + (pixel.data[2] as u64).pow(2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rmosaic`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib/index.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / file.write(contents.as_bytes()) [INFO] [stderr] 19 | | .expect("something went wrong while writing the file"); [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:71:10 [INFO] [stderr] | [INFO] [stderr] 71 | .expect(&format!("Error reading source image {}", source_image_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading source image {}", source_image_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | / ((((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] 78 | | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] 79 | | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] 80 | | as f64) [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | f64::from(((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] 78 | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] 79 | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | ((((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d.average.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:77:50 [INFO] [stderr] | [INFO] [stderr] 77 | ((((d.average.0 as i32).pow(2) - (r as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d.average.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | + ((d.average.1 as i32).pow(2) - (g as i32).pow(2)).abs() [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(d.average.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:79:54 [INFO] [stderr] | [INFO] [stderr] 79 | + ((d.average.2 as i32).pow(2) - (b as i32).pow(2)).abs()) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let progress = Mutex::new(0); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:152:22 [INFO] [stderr] | [INFO] [stderr] 152 | .expect(&format!("Error reading image {}", source_image_path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error reading image {}", source_image_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/main.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | let mut p = progress.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | let bar = *p / progress_increment; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:274:21 [INFO] [stderr] | [INFO] [stderr] 274 | acc.0 + (pixel.data[0] as u64).pow(2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:275:21 [INFO] [stderr] | [INFO] [stderr] 275 | acc.1 + (pixel.data[1] as u64).pow(2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:276:21 [INFO] [stderr] | [INFO] [stderr] 276 | acc.2 + (pixel.data[2] as u64).pow(2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rmosaic`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cf7f729361398ec65decd80e2d47900cd8648bb45377d0ad93d476b832bbc174"` [INFO] running `"docker" "rm" "-f" "cf7f729361398ec65decd80e2d47900cd8648bb45377d0ad93d476b832bbc174"` [INFO] [stdout] cf7f729361398ec65decd80e2d47900cd8648bb45377d0ad93d476b832bbc174