[INFO] updating cached repository ioncodes/trexgenerator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ioncodes/trexgenerator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/trexgenerator" "work/ex/clippy-test-run/sources/stable/gh/ioncodes/trexgenerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ioncodes/trexgenerator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/trexgenerator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/trexgenerator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/trexgenerator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d288b1f6a2a3525b19ac3d539baf145a3eb9961 [INFO] sha for GitHub repo ioncodes/trexgenerator: 2d288b1f6a2a3525b19ac3d539baf145a3eb9961 [INFO] validating manifest of ioncodes/trexgenerator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ioncodes/trexgenerator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ioncodes/trexgenerator [INFO] finished frobbing ioncodes/trexgenerator [INFO] frobbed toml for ioncodes/trexgenerator written to work/ex/clippy-test-run/sources/stable/gh/ioncodes/trexgenerator/Cargo.toml [INFO] started frobbing ioncodes/trexgenerator [INFO] finished frobbing ioncodes/trexgenerator [INFO] frobbed toml for ioncodes/trexgenerator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/trexgenerator/Cargo.toml [INFO] crate ioncodes/trexgenerator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ioncodes/trexgenerator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ioncodes/trexgenerator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9e517a83311af3bf3589d3cbf75e9b770856873d1ed2b4a9cda963ac16f4596 [INFO] running `"docker" "start" "-a" "e9e517a83311af3bf3589d3cbf75e9b770856873d1ed2b4a9cda963ac16f4596"` [INFO] [stderr] Checking num-bigint v0.1.36 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking raster v0.0.7 [INFO] [stderr] Checking jumpingdino v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | if x == 24 && y == 3 || x == 24 && y == 4 || x == 25 && y == 3 || x == 25 && y == 4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 17 | if !(x != 24 && x != 25 || y != 3 && y != 4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 17 | if (x == 24 || x == 25) && (y == 3 || y == 4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / fn main() { [INFO] [stderr] 7 | | let color = Color::rgba(83, 83, 83, 255); [INFO] [stderr] 8 | | let mut canvas = Image::blank(40, 43); [INFO] [stderr] 9 | | for x in 22..38 { [INFO] [stderr] ... | [INFO] [stderr] 115 | | raster::save(&canvas, "dino.png"); [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:17:16 [INFO] [stderr] | [INFO] [stderr] 17 | if x == 24 && y == 3 || x == 24 && y == 4 || x == 25 && y == 3 || x == 25 && y == 4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 17 | if !(x != 24 && x != 25 || y != 3 && y != 4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 17 | if (x == 24 || x == 25) && (y == 3 || y == 4) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 44 [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / fn main() { [INFO] [stderr] 7 | | let color = Color::rgba(83, 83, 83, 255); [INFO] [stderr] 8 | | let mut canvas = Image::blank(40, 43); [INFO] [stderr] 9 | | for x in 22..38 { [INFO] [stderr] ... | [INFO] [stderr] 115 | | raster::save(&canvas, "dino.png"); [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.31s [INFO] running `"docker" "inspect" "e9e517a83311af3bf3589d3cbf75e9b770856873d1ed2b4a9cda963ac16f4596"` [INFO] running `"docker" "rm" "-f" "e9e517a83311af3bf3589d3cbf75e9b770856873d1ed2b4a9cda963ac16f4596"` [INFO] [stdout] e9e517a83311af3bf3589d3cbf75e9b770856873d1ed2b4a9cda963ac16f4596