[INFO] updating cached repository ioncodes/mem_jit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ioncodes/mem_jit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/mem_jit" "work/ex/clippy-test-run/sources/stable/gh/ioncodes/mem_jit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ioncodes/mem_jit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ioncodes/mem_jit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/mem_jit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/mem_jit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 59650db6204b983a40773adfa6406c91c9708dfa [INFO] sha for GitHub repo ioncodes/mem_jit: 59650db6204b983a40773adfa6406c91c9708dfa [INFO] validating manifest of ioncodes/mem_jit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ioncodes/mem_jit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ioncodes/mem_jit [INFO] finished frobbing ioncodes/mem_jit [INFO] frobbed toml for ioncodes/mem_jit written to work/ex/clippy-test-run/sources/stable/gh/ioncodes/mem_jit/Cargo.toml [INFO] started frobbing ioncodes/mem_jit [INFO] finished frobbing ioncodes/mem_jit [INFO] frobbed toml for ioncodes/mem_jit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ioncodes/mem_jit/Cargo.toml [INFO] crate ioncodes/mem_jit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ioncodes/mem_jit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ioncodes/mem_jit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1856c558409f897b6b15661b9afed64ae84be93c0953d3617e3e999cc8bbde9 [INFO] running `"docker" "start" "-a" "f1856c558409f897b6b15661b9afed64ae84be93c0953d3617e3e999cc8bbde9"` [INFO] [stderr] Checking errno v0.2.3 [INFO] [stderr] Checking aligned_alloc v0.1.3 [INFO] [stderr] Checking region v0.0.9 [INFO] [stderr] Checking mem_tests v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/jit_memory.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/jit_memory.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/jit_memory.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | self.emit32((asm & 0xFFFFFFFF) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/jit_memory.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | self.emit32(((asm >> 32) & 0xFFFFFFFF) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/jit_memory.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | self.emit32((asm & 0xFFFFFFFF) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/jit_memory.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | self.emit32(((asm >> 32) & 0xFFFFFFFF) as u32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let val = read(contents, 0); [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `size` [INFO] [stderr] --> src/jit_memory.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | size: usize, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fill` [INFO] [stderr] --> src/jit_memory.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn fill(&mut self, asm: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump` [INFO] [stderr] --> src/jit_memory.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn dump(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/jit_memory.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/jit_memory.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | contents = mem::transmute(_contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `_contents as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/jit_memory.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..self.size { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for in self.iter_mut().take(self.size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `self` [INFO] [stderr] --> src/jit_memory.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for (i, ) in self.iter().enumerate().take(100) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/jit_memory.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | unsafe { &*self.contents.offset(_index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.contents.add(_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/jit_memory.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | unsafe { &mut *self.contents.offset(_index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.contents.add(_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4096` [INFO] [stderr] --> src/main.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | let size = 1 * 4096; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/main.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | contents = mem::transmute(ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let val = read(contents, 0); [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `size` [INFO] [stderr] --> src/jit_memory.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | size: usize, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fill` [INFO] [stderr] --> src/jit_memory.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn fill(&mut self, asm: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dump` [INFO] [stderr] --> src/jit_memory.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn dump(&self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/jit_memory.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/jit_memory.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | contents = mem::transmute(_contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `_contents as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/jit_memory.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..self.size { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for in self.iter_mut().take(self.size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `self` [INFO] [stderr] --> src/jit_memory.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for (i, ) in self.iter().enumerate().take(100) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/jit_memory.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | unsafe { &*self.contents.offset(_index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.contents.add(_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/jit_memory.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | unsafe { &mut *self.contents.offset(_index as isize) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.contents.add(_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4096` [INFO] [stderr] --> src/main.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | let size = 1 * 4096; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/main.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | contents = mem::transmute(ptr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *mut u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.05s [INFO] running `"docker" "inspect" "f1856c558409f897b6b15661b9afed64ae84be93c0953d3617e3e999cc8bbde9"` [INFO] running `"docker" "rm" "-f" "f1856c558409f897b6b15661b9afed64ae84be93c0953d3617e3e999cc8bbde9"` [INFO] [stdout] f1856c558409f897b6b15661b9afed64ae84be93c0953d3617e3e999cc8bbde9