[INFO] updating cached repository iolsen/rust-life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/iolsen/rust-life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/iolsen/rust-life" "work/ex/clippy-test-run/sources/stable/gh/iolsen/rust-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/iolsen/rust-life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/iolsen/rust-life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iolsen/rust-life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iolsen/rust-life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d2df20aa6ec858318f205cfbb4197059a2f669a [INFO] sha for GitHub repo iolsen/rust-life: 6d2df20aa6ec858318f205cfbb4197059a2f669a [INFO] validating manifest of iolsen/rust-life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of iolsen/rust-life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing iolsen/rust-life [INFO] finished frobbing iolsen/rust-life [INFO] frobbed toml for iolsen/rust-life written to work/ex/clippy-test-run/sources/stable/gh/iolsen/rust-life/Cargo.toml [INFO] started frobbing iolsen/rust-life [INFO] finished frobbing iolsen/rust-life [INFO] frobbed toml for iolsen/rust-life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/iolsen/rust-life/Cargo.toml [INFO] crate iolsen/rust-life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting iolsen/rust-life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/iolsen/rust-life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e35bf7e921ec66eefe3eb8eb7ea4e50f4aa6bd8a981800f1daab01bf186efde [INFO] running `"docker" "start" "-a" "9e35bf7e921ec66eefe3eb8eb7ea4e50f4aa6bd8a981800f1daab01bf186efde"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking getch v0.2.0 [INFO] [stderr] Compiling rand v0.6.0 [INFO] [stderr] Checking rust-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/board.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/board.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | print! ("{:?} living neighbors: {}\n", self, board.living_neighbor_count(self)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/board.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/board.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | print! ("{:?} living neighbors: {}\n", self, board.living_neighbor_count(self)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:46:52 [INFO] [stderr] | [INFO] [stderr] 46 | } else if live_neighbor_count == 3 { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 47 | | new_cells.insert(cell.hash_key(), cell); [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:44:68 [INFO] [stderr] | [INFO] [stderr] 44 | if live_neighbor_count == 2 && self.life_at(&cell) { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 45 | | new_cells.insert(cell.hash_key(), cell); [INFO] [stderr] 46 | | } else if live_neighbor_count == 3 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | if key == ('q' as u8) { break } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'q' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-life`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/board.rs:46:52 [INFO] [stderr] | [INFO] [stderr] 46 | } else if live_neighbor_count == 3 { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 47 | | new_cells.insert(cell.hash_key(), cell); [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/board.rs:44:68 [INFO] [stderr] | [INFO] [stderr] 44 | if live_neighbor_count == 2 && self.life_at(&cell) { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 45 | | new_cells.insert(cell.hash_key(), cell); [INFO] [stderr] 46 | | } else if live_neighbor_count == 3 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | if key == ('q' as u8) { break } [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'q' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-life`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9e35bf7e921ec66eefe3eb8eb7ea4e50f4aa6bd8a981800f1daab01bf186efde"` [INFO] running `"docker" "rm" "-f" "9e35bf7e921ec66eefe3eb8eb7ea4e50f4aa6bd8a981800f1daab01bf186efde"` [INFO] [stdout] 9e35bf7e921ec66eefe3eb8eb7ea4e50f4aa6bd8a981800f1daab01bf186efde