[INFO] updating cached repository inter-action/personal_blog_meta_generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/inter-action/personal_blog_meta_generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/inter-action/personal_blog_meta_generator" "work/ex/clippy-test-run/sources/stable/gh/inter-action/personal_blog_meta_generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/inter-action/personal_blog_meta_generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/inter-action/personal_blog_meta_generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inter-action/personal_blog_meta_generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inter-action/personal_blog_meta_generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8046e0d74b9d85bbad5c8df5f663f2f6467a94ed [INFO] sha for GitHub repo inter-action/personal_blog_meta_generator: 8046e0d74b9d85bbad5c8df5f663f2f6467a94ed [INFO] validating manifest of inter-action/personal_blog_meta_generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of inter-action/personal_blog_meta_generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing inter-action/personal_blog_meta_generator [INFO] finished frobbing inter-action/personal_blog_meta_generator [INFO] frobbed toml for inter-action/personal_blog_meta_generator written to work/ex/clippy-test-run/sources/stable/gh/inter-action/personal_blog_meta_generator/Cargo.toml [INFO] started frobbing inter-action/personal_blog_meta_generator [INFO] finished frobbing inter-action/personal_blog_meta_generator [INFO] frobbed toml for inter-action/personal_blog_meta_generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inter-action/personal_blog_meta_generator/Cargo.toml [INFO] crate inter-action/personal_blog_meta_generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting inter-action/personal_blog_meta_generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/inter-action/personal_blog_meta_generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f63b7fef6cdf0e7d014ca022f8919bb0658f530962f8eebd2e13a594a012d860 [INFO] running `"docker" "start" "-a" "f63b7fef6cdf0e7d014ca022f8919bb0658f530962f8eebd2e13a594a012d860"` [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking toml v0.2.1 [INFO] [stderr] Checking dotenv v0.8.0 [INFO] [stderr] Checking thread_local v0.3.2 [INFO] [stderr] Checking aho-corasick v0.6.1 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking meta_creator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config_parser.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config_parser.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | whitelist: whitelist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `whitelist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config_parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | blacklist: blacklist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blacklist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/doc_reader/mod.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config_parser.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config_parser.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | whitelist: whitelist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `whitelist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config_parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | blacklist: blacklist, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `blacklist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return toml::Parser::new(&content).parse().ok_or(From::from("toml parse failed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `toml::Parser::new(&content).parse().ok_or(From::from("toml parse failed"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:98:43 [INFO] [stderr] | [INFO] [stderr] 98 | let handler = move |entry: &DirEntry| -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return toml::Parser::new(&content).parse().ok_or(From::from("toml parse failed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `toml::Parser::new(&content).parse().ok_or(From::from("toml parse failed"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config_parser.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:98:43 [INFO] [stderr] | [INFO] [stderr] 98 | let handler = move |entry: &DirEntry| -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: function is never used: `file_to_direntry` [INFO] [stderr] --> src/utils/mod.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn file_to_direntry>(filepath: T) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `path_to_entry` [INFO] [stderr] --> src/utils/mod.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | fn path_to_entry, B: AsRef>(path: A, filename: B) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/doc_reader/mod.rs:24:67 [INFO] [stderr] | [INFO] [stderr] 24 | let nlast_modified = (last_modified.as_secs() * 1000 * 1000 + last_modified.subsec_nanos() as u64) / 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(last_modified.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config_parser.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | return toml::Parser::new(&content).parse().ok_or(From::from("toml parse failed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| From::from("toml parse failed"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let ref config_path = env::var("CONFIG_PATH").expect("CONFIG_PATH is needed from system env"); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------------------------------------------- help: try: `let config_path = &env::var("CONFIG_PATH").expect("CONFIG_PATH is needed from system env");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:68:58 [INFO] [stderr] | [INFO] [stderr] 68 | blacklist.push(glob::Pattern::new(entry).expect(&format!("invalid blacklist format: {}", entry))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("invalid blacklist format: {}", entry))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:78:58 [INFO] [stderr] | [INFO] [stderr] 78 | whitelist.push(glob::Pattern::new(entry).expect(&format!("invalid whitelist format: {}", entry))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("invalid whitelist format: {}", entry))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | fn save_json(result: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Doc]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | excludes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[glob::Pattern]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | includes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[glob::Pattern]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | for ref pattern in excludes { [INFO] [stderr] | ^^^^^^^^^^^ -------- help: try: `let pattern = &excludes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | for ref pattern in includes { [INFO] [stderr] | ^^^^^^^^^^^ -------- help: try: `let pattern = &includes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/doc_reader/mod.rs:24:67 [INFO] [stderr] | [INFO] [stderr] 24 | let nlast_modified = (last_modified.as_secs() * 1000 * 1000 + last_modified.subsec_nanos() as u64) / 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(last_modified.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/config_parser.rs:15:48 [INFO] [stderr] | [INFO] [stderr] 15 | return toml::Parser::new(&content).parse().ok_or(From::from("toml parse failed")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| From::from("toml parse failed"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config_parser.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | let doc = table.get("doc").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&table["doc"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | let ref config_path = env::var("CONFIG_PATH").expect("CONFIG_PATH is needed from system env"); [INFO] [stderr] | ----^^^^^^^^^^^^^^^--------------------------------------------------------------------------- help: try: `let config_path = &env::var("CONFIG_PATH").expect("CONFIG_PATH is needed from system env");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:68:58 [INFO] [stderr] | [INFO] [stderr] 68 | blacklist.push(glob::Pattern::new(entry).expect(&format!("invalid blacklist format: {}", entry))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("invalid blacklist format: {}", entry))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:78:58 [INFO] [stderr] | [INFO] [stderr] 78 | whitelist.push(glob::Pattern::new(entry).expect(&format!("invalid whitelist format: {}", entry))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("invalid whitelist format: {}", entry))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | fn save_json(result: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Doc]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:124:25 [INFO] [stderr] | [INFO] [stderr] 124 | excludes: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[glob::Pattern]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | includes: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[glob::Pattern]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | for ref pattern in excludes { [INFO] [stderr] | ^^^^^^^^^^^ -------- help: try: `let pattern = &excludes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | for ref pattern in includes { [INFO] [stderr] | ^^^^^^^^^^^ -------- help: try: `let pattern = &includes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.98s [INFO] running `"docker" "inspect" "f63b7fef6cdf0e7d014ca022f8919bb0658f530962f8eebd2e13a594a012d860"` [INFO] running `"docker" "rm" "-f" "f63b7fef6cdf0e7d014ca022f8919bb0658f530962f8eebd2e13a594a012d860"` [INFO] [stdout] f63b7fef6cdf0e7d014ca022f8919bb0658f530962f8eebd2e13a594a012d860