[INFO] updating cached repository innoq/innoq-blockchain-rust-one [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/innoq/innoq-blockchain-rust-one [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/innoq/innoq-blockchain-rust-one" "work/ex/clippy-test-run/sources/stable/gh/innoq/innoq-blockchain-rust-one"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/innoq/innoq-blockchain-rust-one'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/innoq/innoq-blockchain-rust-one" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/innoq/innoq-blockchain-rust-one"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/innoq/innoq-blockchain-rust-one'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53d0eed9e790b9c4a6489eebdf9c5d3d88f52354 [INFO] sha for GitHub repo innoq/innoq-blockchain-rust-one: 53d0eed9e790b9c4a6489eebdf9c5d3d88f52354 [INFO] validating manifest of innoq/innoq-blockchain-rust-one on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of innoq/innoq-blockchain-rust-one on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing innoq/innoq-blockchain-rust-one [INFO] finished frobbing innoq/innoq-blockchain-rust-one [INFO] frobbed toml for innoq/innoq-blockchain-rust-one written to work/ex/clippy-test-run/sources/stable/gh/innoq/innoq-blockchain-rust-one/Cargo.toml [INFO] started frobbing innoq/innoq-blockchain-rust-one [INFO] finished frobbing innoq/innoq-blockchain-rust-one [INFO] frobbed toml for innoq/innoq-blockchain-rust-one written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/innoq/innoq-blockchain-rust-one/Cargo.toml [INFO] crate innoq/innoq-blockchain-rust-one has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting innoq/innoq-blockchain-rust-one against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/innoq/innoq-blockchain-rust-one:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ccdca0f3546c92232e242236bf1bf54ede969369907463b934a044bc9873232b [INFO] running `"docker" "start" "-a" "ccdca0f3546c92232e242236bf1bf54ede969369907463b934a044bc9873232b"` [INFO] [stderr] Checking remove_dir_all v0.5.0 [INFO] [stderr] Checking serde v1.0.39 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Compiling crc v1.7.0 [INFO] [stderr] Checking base64 v0.7.0 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking uuid v0.1.18 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling openssl v0.10.6 [INFO] [stderr] Checking brotli-sys v0.2.1 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Compiling serde_derive v1.0.39 [INFO] [stderr] Checking brotli2 v0.2.2 [INFO] [stderr] Checking url v0.2.38 [INFO] [stderr] Checking gzip-header v0.1.2 [INFO] [stderr] Checking libflate v0.1.14 [INFO] [stderr] Compiling mime_guess v1.8.4 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking tiny_http v0.5.9 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking crypto-hash v0.3.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking serde_json v1.0.15 [INFO] [stderr] Checking rouille v2.1.0 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking rustychain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | transactions: transactions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transactions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | transactions: transactions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transactions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chain.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | proof: 1917336, [INFO] [stderr] | ^^^^^^^ help: consider: `1_917_336` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chain.rs:88:20 [INFO] [stderr] | [INFO] [stderr] 88 | proof: 1917336, [INFO] [stderr] | ^^^^^^^ help: consider: `1_917_336` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::Server` [INFO] [stderr] --> src/http.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new() -> Server { [INFO] [stderr] 79 | | Server { [INFO] [stderr] 80 | | node_id: Uuid::new_v4().to_string(), [INFO] [stderr] 81 | | rusty_chain: vec![Block::genesis()], [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:186:24 [INFO] [stderr] | [INFO] [stderr] 186 | let id = url.split("/").nth(2); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn validate(chain: &Chain) -> bool { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain.rs:63:28 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn transactions(chain: &Chain) -> Vec { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/chain.rs:124:63 [INFO] [stderr] | [INFO] [stderr] 124 | let nanos: u64 = duration.as_secs() * 1_000_000_000 + (duration.subsec_nanos() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::Server` [INFO] [stderr] --> src/http.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn new() -> Server { [INFO] [stderr] 79 | | Server { [INFO] [stderr] 80 | | node_id: Uuid::new_v4().to_string(), [INFO] [stderr] 81 | | rusty_chain: vec![Block::genesis()], [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:186:24 [INFO] [stderr] | [INFO] [stderr] 186 | let id = url.split("/").nth(2); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn validate(chain: &Chain) -> bool { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chain.rs:63:28 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn transactions(chain: &Chain) -> Vec { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/chain.rs:124:63 [INFO] [stderr] | [INFO] [stderr] 124 | let nanos: u64 = duration.as_secs() * 1_000_000_000 + (duration.subsec_nanos() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.48s [INFO] running `"docker" "inspect" "ccdca0f3546c92232e242236bf1bf54ede969369907463b934a044bc9873232b"` [INFO] running `"docker" "rm" "-f" "ccdca0f3546c92232e242236bf1bf54ede969369907463b934a044bc9873232b"` [INFO] [stdout] ccdca0f3546c92232e242236bf1bf54ede969369907463b934a044bc9873232b