[INFO] updating cached repository innerand/eggspire [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/innerand/eggspire [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/innerand/eggspire" "work/ex/clippy-test-run/sources/stable/gh/innerand/eggspire"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/innerand/eggspire'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/innerand/eggspire" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/innerand/eggspire"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/innerand/eggspire'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d96dfb01166a407b7986390a686c7df68d93962 [INFO] sha for GitHub repo innerand/eggspire: 6d96dfb01166a407b7986390a686c7df68d93962 [INFO] validating manifest of innerand/eggspire on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of innerand/eggspire on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing innerand/eggspire [INFO] finished frobbing innerand/eggspire [INFO] frobbed toml for innerand/eggspire written to work/ex/clippy-test-run/sources/stable/gh/innerand/eggspire/Cargo.toml [INFO] started frobbing innerand/eggspire [INFO] finished frobbing innerand/eggspire [INFO] frobbed toml for innerand/eggspire written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/innerand/eggspire/Cargo.toml [INFO] crate innerand/eggspire has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting innerand/eggspire against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/innerand/eggspire:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3caa3b1899a146acbb7b86f63265837df8387f966ca5d3ff0bbea29f92a68f76 [INFO] running `"docker" "start" "-a" "3caa3b1899a146acbb7b86f63265837df8387f966ca5d3ff0bbea29f92a68f76"` [INFO] [stderr] Compiling openssl v0.9.21 [INFO] [stderr] Compiling openssl-sys v0.9.21 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking hyper v0.11.7 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking crypto-mac v0.4.0 [INFO] [stderr] Checking digest v0.6.2 [INFO] [stderr] Checking sha-1 v0.4.1 [INFO] [stderr] Checking hmac v0.4.2 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking egg-mode v0.11.0 [INFO] [stderr] Checking eggspire v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/args.rs:4:30 [INFO] [stderr] | [INFO] [stderr] 4 | const SECONDS_IN_WEEK: i64 = 604800; [INFO] [stderr] | ^^^^^^ help: consider: `604_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/args.rs:60:46 [INFO] [stderr] | [INFO] [stderr] 60 | Ok(num) if num > 0 && num < 52000 => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/mod.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | span: 31449600, // 52 Weeks [INFO] [stderr] | ^^^^^^^^ help: consider: `31_449_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/args.rs:4:30 [INFO] [stderr] | [INFO] [stderr] 4 | const SECONDS_IN_WEEK: i64 = 604800; [INFO] [stderr] | ^^^^^^ help: consider: `604_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/args.rs:60:46 [INFO] [stderr] | [INFO] [stderr] 60 | Ok(num) if num > 0 && num < 52000 => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/mod.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | span: 31449600, // 52 Weeks [INFO] [stderr] | ^^^^^^^^ help: consider: `31_449_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / fn main() { [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | // Init logger and set default log level (Error) [INFO] [stderr] 26 | | util::log::init(::log::LogLevelFilter::Error); [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:64 [INFO] [stderr] | [INFO] [stderr] 92 | let sleep_s = Utc::now().timestamp() - utc as i64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(utc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | if !conf.dryrun && to_delete.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_delete.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / fn main() { [INFO] [stderr] 24 | | [INFO] [stderr] 25 | | // Init logger and set default log level (Error) [INFO] [stderr] 26 | | util::log::init(::log::LogLevelFilter::Error); [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:64 [INFO] [stderr] | [INFO] [stderr] 92 | let sleep_s = Utc::now().timestamp() - utc as i64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(utc)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | if !conf.dryrun && to_delete.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_delete.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.61s [INFO] running `"docker" "inspect" "3caa3b1899a146acbb7b86f63265837df8387f966ca5d3ff0bbea29f92a68f76"` [INFO] running `"docker" "rm" "-f" "3caa3b1899a146acbb7b86f63265837df8387f966ca5d3ff0bbea29f92a68f76"` [INFO] [stdout] 3caa3b1899a146acbb7b86f63265837df8387f966ca5d3ff0bbea29f92a68f76