[INFO] updating cached repository incleaf/cr8cert [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/incleaf/cr8cert [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/incleaf/cr8cert" "work/ex/clippy-test-run/sources/stable/gh/incleaf/cr8cert"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/incleaf/cr8cert'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/incleaf/cr8cert" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/incleaf/cr8cert"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/incleaf/cr8cert'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] aa50e02f41b501ad2ff798816eac98ab3b32bc37 [INFO] sha for GitHub repo incleaf/cr8cert: aa50e02f41b501ad2ff798816eac98ab3b32bc37 [INFO] validating manifest of incleaf/cr8cert on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of incleaf/cr8cert on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing incleaf/cr8cert [INFO] finished frobbing incleaf/cr8cert [INFO] frobbed toml for incleaf/cr8cert written to work/ex/clippy-test-run/sources/stable/gh/incleaf/cr8cert/Cargo.toml [INFO] started frobbing incleaf/cr8cert [INFO] finished frobbing incleaf/cr8cert [INFO] frobbed toml for incleaf/cr8cert written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/incleaf/cr8cert/Cargo.toml [INFO] crate incleaf/cr8cert has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting incleaf/cr8cert against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/incleaf/cr8cert:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06369059560fccc187ce37dfa160d974edcc1a076339f50a7587ffa1a71dcd6d [INFO] running `"docker" "start" "-a" "06369059560fccc187ce37dfa160d974edcc1a076339f50a7587ffa1a71dcd6d"` [INFO] [stderr] Compiling openssl v0.10.12 [INFO] [stderr] Compiling openssl-src v110.0.7+1.1.0i [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Compiling openssl-sys v0.9.36 [INFO] [stderr] Checking pem v0.4.1 [INFO] [stderr] Checking cr8cert v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cert.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | pub const ROOT_NAME: &'static str = "rootCA.pem"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cert.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub const KEY_NAME: &'static str = "rootCA-key.pem"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cert.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | return homepath.join("Library/Application Support/cr8cert").to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `homepath.join("Library/Application Support/cr8cert").to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cert.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | return Ok((cert, pkey)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((cert, pkey))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cert.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | pub const ROOT_NAME: &'static str = "rootCA.pem"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cert.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub const KEY_NAME: &'static str = "rootCA-key.pem"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cert.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | return homepath.join("Library/Application Support/cr8cert").to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `homepath.join("Library/Application Support/cr8cert").to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cert.rs:163:3 [INFO] [stderr] | [INFO] [stderr] 163 | return Ok((cert, pkey)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((cert, pkey))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(_) = matches.values_of("create") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 64 | | let hosts: Vec<_> = matches.values_of("create").unwrap().collect(); [INFO] [stderr] 65 | | [INFO] [stderr] 66 | | let ca_root = cert::get_ca_root(); [INFO] [stderr] ... | [INFO] [stderr] 75 | | cert::cr8cert(hosts, root_ca, root_ca_key).ok(); [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____- help: try this: `if matches.values_of("create").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if let Some(_) = matches.values_of("create") { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 64 | | let hosts: Vec<_> = matches.values_of("create").unwrap().collect(); [INFO] [stderr] 65 | | [INFO] [stderr] 66 | | let ca_root = cert::get_ca_root(); [INFO] [stderr] ... | [INFO] [stderr] 75 | | cert::cr8cert(hosts, root_ca, root_ca_key).ok(); [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____- help: try this: `if matches.values_of("create").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 06s [INFO] running `"docker" "inspect" "06369059560fccc187ce37dfa160d974edcc1a076339f50a7587ffa1a71dcd6d"` [INFO] running `"docker" "rm" "-f" "06369059560fccc187ce37dfa160d974edcc1a076339f50a7587ffa1a71dcd6d"` [INFO] [stdout] 06369059560fccc187ce37dfa160d974edcc1a076339f50a7587ffa1a71dcd6d