[INFO] updating cached repository inalpha/csvmerge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/inalpha/csvmerge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/inalpha/csvmerge" "work/ex/clippy-test-run/sources/stable/gh/inalpha/csvmerge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/inalpha/csvmerge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/inalpha/csvmerge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inalpha/csvmerge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inalpha/csvmerge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 458bb3d078828fe1cb5ab9a0abeff03e4909f5ca [INFO] sha for GitHub repo inalpha/csvmerge: 458bb3d078828fe1cb5ab9a0abeff03e4909f5ca [INFO] validating manifest of inalpha/csvmerge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of inalpha/csvmerge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing inalpha/csvmerge [INFO] finished frobbing inalpha/csvmerge [INFO] frobbed toml for inalpha/csvmerge written to work/ex/clippy-test-run/sources/stable/gh/inalpha/csvmerge/Cargo.toml [INFO] started frobbing inalpha/csvmerge [INFO] finished frobbing inalpha/csvmerge [INFO] frobbed toml for inalpha/csvmerge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/inalpha/csvmerge/Cargo.toml [INFO] crate inalpha/csvmerge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting inalpha/csvmerge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/inalpha/csvmerge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 212ff45b3b821b2b6b38e75756311615017d39ed92676ec61376f231dd43606b [INFO] running `"docker" "start" "-a" "212ff45b3b821b2b6b38e75756311615017d39ed92676ec61376f231dd43606b"` [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking toml v0.4.7 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking config v0.9.1 [INFO] [stderr] Checking csvmerge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | rdr: rdr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | rdr: rdr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(path: &str, columns: &Vec>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 54 | | match self.rdr.read_byte_record(&mut self.row) { [INFO] [stderr] 55 | | Ok(true) => { [INFO] [stderr] 56 | | let mut row = csv::ByteRecord::new(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn new(path: &str, columns: &Vec>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 54 | | match self.rdr.read_byte_record(&mut self.row) { [INFO] [stderr] 55 | | Ok(true) => { [INFO] [stderr] 56 | | let mut row = csv::ByteRecord::new(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.27s [INFO] running `"docker" "inspect" "212ff45b3b821b2b6b38e75756311615017d39ed92676ec61376f231dd43606b"` [INFO] running `"docker" "rm" "-f" "212ff45b3b821b2b6b38e75756311615017d39ed92676ec61376f231dd43606b"` [INFO] [stdout] 212ff45b3b821b2b6b38e75756311615017d39ed92676ec61376f231dd43606b