[INFO] updating cached repository imagetest/imagetest-cli
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/imagetest/imagetest-cli
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/imagetest/imagetest-cli" "work/ex/clippy-test-run/sources/stable/gh/imagetest/imagetest-cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/imagetest/imagetest-cli'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/imagetest/imagetest-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/imagetest/imagetest-cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/imagetest/imagetest-cli'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 35f8968186c9dcfb94fc2538b584f14c02148988
[INFO] sha for GitHub repo imagetest/imagetest-cli: 35f8968186c9dcfb94fc2538b584f14c02148988
[INFO] validating manifest of imagetest/imagetest-cli on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of imagetest/imagetest-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing imagetest/imagetest-cli
[INFO] finished frobbing imagetest/imagetest-cli
[INFO] frobbed toml for imagetest/imagetest-cli written to work/ex/clippy-test-run/sources/stable/gh/imagetest/imagetest-cli/Cargo.toml
[INFO] started frobbing imagetest/imagetest-cli
[INFO] finished frobbing imagetest/imagetest-cli
[INFO] frobbed toml for imagetest/imagetest-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/imagetest/imagetest-cli/Cargo.toml
[INFO] crate imagetest/imagetest-cli has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting imagetest/imagetest-cli against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/imagetest/imagetest-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 046566bb2451633812f6a34fc4a0cdc3ce7b460cf06fa4ffc40c48b8ea0a0e90
[INFO] running `"docker" "start" "-a" "046566bb2451633812f6a34fc4a0cdc3ce7b460cf06fa4ffc40c48b8ea0a0e90"`
[INFO] [stderr]     Checking tokio-service v0.1.0
[INFO] [stderr]     Checking relay v0.1.0
[INFO] [stderr]     Checking colored v1.5.3
[INFO] [stderr]     Checking futures-cpupool v0.1.7
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking hyper v0.11.6
[INFO] [stderr]     Checking imagetest-cli v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/test.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             print!("\n");
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/test.rs:106:13
[INFO] [stderr]     |
[INFO] [stderr] 106 |             print!("\n");
[INFO] [stderr]     |             ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/validate.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const NAME: &'static str = "validate";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/test.rs:19:18
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const NAME: &'static str = "test";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 | /     return Box::new(request_json(&handle, request)
[INFO] [stderr] 135 | |         .and_then(|res| Ok(::serde_json::from_value(res).unwrap()))
[INFO] [stderr] 136 | |         .and_then(|resp| {
[INFO] [stderr] 137 | |             let result = TestResult {
[INFO] [stderr] ...   |
[INFO] [stderr] 141 | |             Ok(result)
[INFO] [stderr] 142 | |         }));
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 134 |     Box::new(request_json(&handle, request)
[INFO] [stderr] 135 |         .and_then(|res| Ok(::serde_json::from_value(res).unwrap()))
[INFO] [stderr] 136 |         .and_then(|resp| {
[INFO] [stderr] 137 |             let result = TestResult {
[INFO] [stderr] 138 |                 test,
[INFO] [stderr] 139 |                 response: resp,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:160:5
[INFO] [stderr]     |
[INFO] [stderr] 160 |     return Box::new(res);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/validate.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const NAME: &'static str = "validate";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/test.rs:19:18
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const NAME: &'static str = "test";
[INFO] [stderr]    |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 | /     return Box::new(request_json(&handle, request)
[INFO] [stderr] 135 | |         .and_then(|res| Ok(::serde_json::from_value(res).unwrap()))
[INFO] [stderr] 136 | |         .and_then(|resp| {
[INFO] [stderr] 137 | |             let result = TestResult {
[INFO] [stderr] ...   |
[INFO] [stderr] 141 | |             Ok(result)
[INFO] [stderr] 142 | |         }));
[INFO] [stderr]     | |____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 134 |     Box::new(request_json(&handle, request)
[INFO] [stderr] 135 |         .and_then(|res| Ok(::serde_json::from_value(res).unwrap()))
[INFO] [stderr] 136 |         .and_then(|resp| {
[INFO] [stderr] 137 |             let result = TestResult {
[INFO] [stderr] 138 |                 test,
[INFO] [stderr] 139 |                 response: resp,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/test.rs:160:5
[INFO] [stderr]     |
[INFO] [stderr] 160 |     return Box::new(res);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:19:17
[INFO] [stderr]    |
[INFO] [stderr] 19 | const VERSION: &'static str = env!("CARGO_PKG_VERSION");
[INFO] [stderr]    |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/validate.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |                   if let Err(_) = config {
[INFO] [stderr]    |  _________________-      ^^^^^^
[INFO] [stderr] 31 | |                     exit_with_error("Could not parse config file into expected config format", false);
[INFO] [stderr] 32 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if config.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/validate.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |                   if let Err(_) = config {
[INFO] [stderr]    |  _________________-      ^^^^^^
[INFO] [stderr] 31 | |                     exit_with_error("Could not parse config file into expected config format", false);
[INFO] [stderr] 32 | |                 }
[INFO] [stderr]    | |_________________- help: try this: `if config.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.17s
[INFO] running `"docker" "inspect" "046566bb2451633812f6a34fc4a0cdc3ce7b460cf06fa4ffc40c48b8ea0a0e90"`
[INFO] running `"docker" "rm" "-f" "046566bb2451633812f6a34fc4a0cdc3ce7b460cf06fa4ffc40c48b8ea0a0e90"`
[INFO] [stdout] 046566bb2451633812f6a34fc4a0cdc3ce7b460cf06fa4ffc40c48b8ea0a0e90