[INFO] updating cached repository ilyayudkovich/git_pull [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ilyayudkovich/git_pull [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ilyayudkovich/git_pull" "work/ex/clippy-test-run/sources/stable/gh/ilyayudkovich/git_pull"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ilyayudkovich/git_pull'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ilyayudkovich/git_pull" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ilyayudkovich/git_pull"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ilyayudkovich/git_pull'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 172d460e7204132cc973111deedc24df193cf807 [INFO] sha for GitHub repo ilyayudkovich/git_pull: 172d460e7204132cc973111deedc24df193cf807 [INFO] validating manifest of ilyayudkovich/git_pull on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilyayudkovich/git_pull on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilyayudkovich/git_pull [INFO] finished frobbing ilyayudkovich/git_pull [INFO] frobbed toml for ilyayudkovich/git_pull written to work/ex/clippy-test-run/sources/stable/gh/ilyayudkovich/git_pull/Cargo.toml [INFO] started frobbing ilyayudkovich/git_pull [INFO] finished frobbing ilyayudkovich/git_pull [INFO] frobbed toml for ilyayudkovich/git_pull written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ilyayudkovich/git_pull/Cargo.toml [INFO] crate ilyayudkovich/git_pull has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilyayudkovich/git_pull against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ilyayudkovich/git_pull:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2db1f8fb7ede0a102039ce74cd554788359bec2fdedce28e9cf42bfc926cd134 [INFO] running `"docker" "start" "-a" "2db1f8fb7ede0a102039ce74cd554788359bec2fdedce28e9cf42bfc926cd134"` [INFO] [stderr] Checking git_update v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Output` [INFO] [stderr] --> src/main.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | use std::process::{Command, Output}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `time` [INFO] [stderr] --> src/main.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | use std::{thread, time}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | return String::from_utf8(output.stdout).expect("Not from_utf8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(output.stdout).expect("Not from_utf8")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pull` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let pull = Command::new("git") [INFO] [stderr] | ^^^^ help: consider using `_pull` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:27:6 [INFO] [stderr] | [INFO] [stderr] 27 | let mut output = Command::new("git") [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | get_dirs(&root).split("\n").map( [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `Output` [INFO] [stderr] --> src/main.rs:1:29 [INFO] [stderr] | [INFO] [stderr] 1 | use std::process::{Command, Output}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `time` [INFO] [stderr] --> src/main.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | use std::{thread, time}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:22:2 [INFO] [stderr] | [INFO] [stderr] 22 | return String::from_utf8(output.stdout).expect("Not from_utf8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from_utf8(output.stdout).expect("Not from_utf8")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pull` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let pull = Command::new("git") [INFO] [stderr] | ^^^^ help: consider using `_pull` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:27:6 [INFO] [stderr] | [INFO] [stderr] 27 | let mut output = Command::new("git") [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:54:25 [INFO] [stderr] | [INFO] [stderr] 54 | get_dirs(&root).split("\n").map( [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "2db1f8fb7ede0a102039ce74cd554788359bec2fdedce28e9cf42bfc926cd134"` [INFO] running `"docker" "rm" "-f" "2db1f8fb7ede0a102039ce74cd554788359bec2fdedce28e9cf42bfc926cd134"` [INFO] [stdout] 2db1f8fb7ede0a102039ce74cd554788359bec2fdedce28e9cf42bfc926cd134