[INFO] updating cached repository illemonati/hw2_conrod [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/illemonati/hw2_conrod [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/illemonati/hw2_conrod" "work/ex/clippy-test-run/sources/stable/gh/illemonati/hw2_conrod"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/illemonati/hw2_conrod'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/illemonati/hw2_conrod" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illemonati/hw2_conrod"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illemonati/hw2_conrod'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b1cbc2d8c516395b11081f35f5283f24bd2c34f5 [INFO] sha for GitHub repo illemonati/hw2_conrod: b1cbc2d8c516395b11081f35f5283f24bd2c34f5 [INFO] validating manifest of illemonati/hw2_conrod on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of illemonati/hw2_conrod on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing illemonati/hw2_conrod [INFO] finished frobbing illemonati/hw2_conrod [INFO] frobbed toml for illemonati/hw2_conrod written to work/ex/clippy-test-run/sources/stable/gh/illemonati/hw2_conrod/Cargo.toml [INFO] started frobbing illemonati/hw2_conrod [INFO] finished frobbing illemonati/hw2_conrod [INFO] frobbed toml for illemonati/hw2_conrod written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illemonati/hw2_conrod/Cargo.toml [INFO] crate illemonati/hw2_conrod has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting illemonati/hw2_conrod against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/illemonati/hw2_conrod:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a0544da7369a361ef4cbd3e404cc3569a49a94bd6b8fa4682e611305ca4ed53 [INFO] running `"docker" "start" "-a" "3a0544da7369a361ef4cbd3e404cc3569a49a94bd6b8fa4682e611305ca4ed53"` [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling conrod_derive v0.1.2 [INFO] [stderr] Checking conrod v0.61.1 [INFO] [stderr] Checking hw2_conrod v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `conrod::backend::glium::glium::backend::glutin::glutin::GlContext` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use conrod::backend::glium::glium::backend::glutin::glutin::GlContext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Toggle` [INFO] [stderr] --> src/main.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | use conrod::widget::{Text, Button, Toggle}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `widget` [INFO] [stderr] --> src/main.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | use conrod::{widget, Positionable, Colorable, Widget, Sizeable}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | if (&text_button_num == &1){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | for input in ui.global_input().events(){ [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut main_text = [String::from("Gay, You be"), String::from("Am I?")]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | let mut uis = &mut ui.set_widgets(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | if (&text_button_num == &1){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 64 | if (text_button_num == 1){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | / match event { [INFO] [stderr] 104 | | glium::glutin::Event::WindowEvent { event, ..} => match event { [INFO] [stderr] 105 | | glium::glutin::WindowEvent::CloseRequested | [INFO] [stderr] 106 | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] ... | [INFO] [stderr] 116 | | _ => (), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let glium::glutin::Event::WindowEvent { event, ..} = event { match event { [INFO] [stderr] 104 | glium::glutin::WindowEvent::CloseRequested | [INFO] [stderr] 105 | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 106 | input: glium::glutin::KeyboardInput { [INFO] [stderr] 107 | virtual_keycode: Some(glium::glutin::VirtualKeyCode::Escape), [INFO] [stderr] 108 | .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `conrod::backend::glium::glium::backend::glutin::glutin::GlContext` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use conrod::backend::glium::glium::backend::glutin::glutin::GlContext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Toggle` [INFO] [stderr] --> src/main.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | use conrod::widget::{Text, Button, Toggle}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `widget` [INFO] [stderr] --> src/main.rs:12:14 [INFO] [stderr] | [INFO] [stderr] 12 | use conrod::{widget, Positionable, Colorable, Widget, Sizeable}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | if (&text_button_num == &1){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/main.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | for input in ui.global_input().events(){ [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut main_text = [String::from("Gay, You be"), String::from("Am I?")]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | let mut uis = &mut ui.set_widgets(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | if (&text_button_num == &1){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 64 | if (text_button_num == 1){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | / match event { [INFO] [stderr] 104 | | glium::glutin::Event::WindowEvent { event, ..} => match event { [INFO] [stderr] 105 | | glium::glutin::WindowEvent::CloseRequested | [INFO] [stderr] 106 | | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] ... | [INFO] [stderr] 116 | | _ => (), [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | if let glium::glutin::Event::WindowEvent { event, ..} = event { match event { [INFO] [stderr] 104 | glium::glutin::WindowEvent::CloseRequested | [INFO] [stderr] 105 | glium::glutin::WindowEvent::KeyboardInput { [INFO] [stderr] 106 | input: glium::glutin::KeyboardInput { [INFO] [stderr] 107 | virtual_keycode: Some(glium::glutin::VirtualKeyCode::Escape), [INFO] [stderr] 108 | .. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `"docker" "inspect" "3a0544da7369a361ef4cbd3e404cc3569a49a94bd6b8fa4682e611305ca4ed53"` [INFO] running `"docker" "rm" "-f" "3a0544da7369a361ef4cbd3e404cc3569a49a94bd6b8fa4682e611305ca4ed53"` [INFO] [stdout] 3a0544da7369a361ef4cbd3e404cc3569a49a94bd6b8fa4682e611305ca4ed53