[INFO] updating cached repository illegalprime/rust-ddp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/illegalprime/rust-ddp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/illegalprime/rust-ddp" "work/ex/clippy-test-run/sources/stable/gh/illegalprime/rust-ddp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/illegalprime/rust-ddp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/illegalprime/rust-ddp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illegalprime/rust-ddp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illegalprime/rust-ddp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4d73ed647b9d331a2819a825299525bfd4d7a47f [INFO] sha for GitHub repo illegalprime/rust-ddp: 4d73ed647b9d331a2819a825299525bfd4d7a47f [INFO] validating manifest of illegalprime/rust-ddp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of illegalprime/rust-ddp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing illegalprime/rust-ddp [INFO] finished frobbing illegalprime/rust-ddp [INFO] frobbed toml for illegalprime/rust-ddp written to work/ex/clippy-test-run/sources/stable/gh/illegalprime/rust-ddp/Cargo.toml [INFO] started frobbing illegalprime/rust-ddp [INFO] finished frobbing illegalprime/rust-ddp [INFO] frobbed toml for illegalprime/rust-ddp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illegalprime/rust-ddp/Cargo.toml [INFO] crate illegalprime/rust-ddp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting illegalprime/rust-ddp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/illegalprime/rust-ddp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5122059fefb45437e401d1c91bd76b6823d507dc8707c79a2a8b733019a2418b [INFO] running `"docker" "start" "-a" "5122059fefb45437e401d1c91bd76b6823d507dc8707c79a2a8b733019a2418b"` [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Compiling syn v0.13.4 [INFO] [stderr] Checking tokio-threadpool v0.1.3 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling serde_derive v1.0.45 [INFO] [stderr] Checking websocket v0.20.2 [INFO] [stderr] Checking ddp v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | mongos: mongos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mongos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | subs: subs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | session_id: session_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `session_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | sending: sending, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sending` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | receiving: receiving, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `receiving` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | outgoing: outgoing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outgoing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | ops: ops, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | outgoing: outgoing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outgoing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/messages.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | methods: methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `methods` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | mongos: mongos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mongos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | subs: subs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | session_id: session_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `session_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | sending: sending, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sending` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | receiving: receiving, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `receiving` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | outgoing: outgoing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `outgoing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:340:13 [INFO] [stderr] | [INFO] [stderr] 340 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | ops: ops, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ops` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/connection.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | outgoing: outgoing, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `outgoing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/messages.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | conn: conn, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/random.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | const UNMISTAKABLE_CHARS: &'static str = "23456789ABCDEFGHJKLMNPQRSTWXYZabcdefghijkmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/connection.rs:613:13 [INFO] [stderr] | [INFO] [stderr] 613 | const WS: &'static str = "ws"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/connection.rs:614:13 [INFO] [stderr] | [INFO] [stderr] 614 | const WSS: &'static str = "wss"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/messages.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | pub const VERSIONS: &'static [&'static str; 3] = &["1", "pre2", "pre1"]; [INFO] [stderr] | -^^^^^^^------------------ help: consider removing `'static`: `&[&'static str; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/messages.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | pub const VERSIONS: &'static [&'static str; 3] = &["1", "pre2", "pre1"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/random.rs:5:28 [INFO] [stderr] | [INFO] [stderr] 5 | const UNMISTAKABLE_CHARS: &'static str = "23456789ABCDEFGHJKLMNPQRSTWXYZabcdefghijkmnopqrstuvwxyz"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/connection.rs:613:13 [INFO] [stderr] | [INFO] [stderr] 613 | const WS: &'static str = "ws"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/connection.rs:614:13 [INFO] [stderr] | [INFO] [stderr] 614 | const WSS: &'static str = "wss"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/messages.rs:3:22 [INFO] [stderr] | [INFO] [stderr] 3 | pub const VERSIONS: &'static [&'static str; 3] = &["1", "pre2", "pre1"]; [INFO] [stderr] | -^^^^^^^------------------ help: consider removing `'static`: `&[&'static str; 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/messages.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | pub const VERSIONS: &'static [&'static str; 3] = &["1", "pre2", "pre1"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/random.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | rand_str.push(self.set.get(next).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.set[next]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:39:66 [INFO] [stderr] | [INFO] [stderr] 39 | let ( mut receiver, mut sender) = client.split().map_err(|e| DdpConnError::IoError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::IoError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | let mut handlers: HashMap<&'static str, Box> = HashMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | .connect_insecure().map_err(|e| DdpConnError::Network(e) )?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::Network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | .map_err(|e| DdpConnError::Parse(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::Parse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:141:53 [INFO] [stderr] | [INFO] [stderr] 141 | try!( client.send_message(&request).map_err(|e| DdpConnError::Network(e)) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::Network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:313:23 [INFO] [stderr] | [INFO] [stderr] 313 | remove_listeners: Arc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:314:23 [INFO] [stderr] | [INFO] [stderr] 314 | insert_listeners: Arc) + Send + 'static>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:315:23 [INFO] [stderr] | [INFO] [stderr] 315 | change_listeners: Arc, Option<&Ejson>) + Send + 'static>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/connection.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | / if let &mut Some(ref mut id) = id_maybe { [INFO] [stderr] 430 | | self.subs.lock().unwrap().unsub(&id); [INFO] [stderr] 431 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(ref mut id) = *id_maybe { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:444:15 [INFO] [stderr] | [INFO] [stderr] 444 | subs: HashMap) + Send + 'static>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/connection.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | / if let &mut Some(ref id) = id { [INFO] [stderr] 473 | | // TODO: Use the extra params. [INFO] [stderr] 474 | | let sub_msg = Subscribe::text(&id, &name, None); [INFO] [stderr] 475 | | self.outgoing.lock().unwrap().send(sub_msg).unwrap(); [INFO] [stderr] 476 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 472 | if let Some(ref id) = *id { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/connection.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | / if let &mut Some(ref id) = id { [INFO] [stderr] 490 | | if let Some(mut listeners) = self.subs.get_mut(id) { [INFO] [stderr] 491 | | listeners.push(Box::new(f)); [INFO] [stderr] 492 | | } [INFO] [stderr] 493 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 489 | if let Some(ref id) = *id { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client/connection.rs:506:26 [INFO] [stderr] | [INFO] [stderr] 506 | callback(data.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/client/messages.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn text<'l>(id: Option<&'l str>) -> String { [INFO] [stderr] 56 | | if let Some(id) = id { [INFO] [stderr] 57 | | json!({ [INFO] [stderr] 58 | | "msg": "pong", [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/client/messages.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn text<'l>(id: &'l str) -> String { [INFO] [stderr] 109 | | json!({ [INFO] [stderr] 110 | | "msg": "unsub", [INFO] [stderr] 111 | | "id": id [INFO] [stderr] 112 | | }).to_string() [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/random.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | rand_str.push(self.set.get(next).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.set[next]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:39:66 [INFO] [stderr] | [INFO] [stderr] 39 | let ( mut receiver, mut sender) = client.split().map_err(|e| DdpConnError::IoError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::IoError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | let mut handlers: HashMap<&'static str, Box> = HashMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:134:41 [INFO] [stderr] | [INFO] [stderr] 134 | .connect_insecure().map_err(|e| DdpConnError::Network(e) )?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::Network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:133:22 [INFO] [stderr] | [INFO] [stderr] 133 | .map_err(|e| DdpConnError::Parse(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::Parse` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client/connection.rs:141:53 [INFO] [stderr] | [INFO] [stderr] 141 | try!( client.send_message(&request).map_err(|e| DdpConnError::Network(e)) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DdpConnError::Network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:313:23 [INFO] [stderr] | [INFO] [stderr] 313 | remove_listeners: Arc>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:314:23 [INFO] [stderr] | [INFO] [stderr] 314 | insert_listeners: Arc) + Send + 'static>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:315:23 [INFO] [stderr] | [INFO] [stderr] 315 | change_listeners: Arc, Option<&Ejson>) + Send + 'static>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/connection.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | / if let &mut Some(ref mut id) = id_maybe { [INFO] [stderr] 430 | | self.subs.lock().unwrap().unsub(&id); [INFO] [stderr] 431 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 429 | if let Some(ref mut id) = *id_maybe { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/client/connection.rs:444:15 [INFO] [stderr] | [INFO] [stderr] 444 | subs: HashMap) + Send + 'static>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/connection.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | / if let &mut Some(ref id) = id { [INFO] [stderr] 473 | | // TODO: Use the extra params. [INFO] [stderr] 474 | | let sub_msg = Subscribe::text(&id, &name, None); [INFO] [stderr] 475 | | self.outgoing.lock().unwrap().send(sub_msg).unwrap(); [INFO] [stderr] 476 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 472 | if let Some(ref id) = *id { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/connection.rs:489:9 [INFO] [stderr] | [INFO] [stderr] 489 | / if let &mut Some(ref id) = id { [INFO] [stderr] 490 | | if let Some(mut listeners) = self.subs.get_mut(id) { [INFO] [stderr] 491 | | listeners.push(Box::new(f)); [INFO] [stderr] 492 | | } [INFO] [stderr] 493 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 489 | if let Some(ref id) = *id { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client/connection.rs:506:26 [INFO] [stderr] | [INFO] [stderr] 506 | callback(data.clone()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/client/messages.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn text<'l>(id: Option<&'l str>) -> String { [INFO] [stderr] 56 | | if let Some(id) = id { [INFO] [stderr] 57 | | json!({ [INFO] [stderr] 58 | | "msg": "pong", [INFO] [stderr] ... | [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/client/messages.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / pub fn text<'l>(id: &'l str) -> String { [INFO] [stderr] 109 | | json!({ [INFO] [stderr] 110 | | "msg": "unsub", [INFO] [stderr] 111 | | "id": id [INFO] [stderr] 112 | | }).to_string() [INFO] [stderr] 113 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.51s [INFO] running `"docker" "inspect" "5122059fefb45437e401d1c91bd76b6823d507dc8707c79a2a8b733019a2418b"` [INFO] running `"docker" "rm" "-f" "5122059fefb45437e401d1c91bd76b6823d507dc8707c79a2a8b733019a2418b"` [INFO] [stdout] 5122059fefb45437e401d1c91bd76b6823d507dc8707c79a2a8b733019a2418b