[INFO] updating cached repository illbexyz/tinyrenderer-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/illbexyz/tinyrenderer-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/illbexyz/tinyrenderer-rust" "work/ex/clippy-test-run/sources/stable/gh/illbexyz/tinyrenderer-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/illbexyz/tinyrenderer-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/illbexyz/tinyrenderer-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illbexyz/tinyrenderer-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illbexyz/tinyrenderer-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da176a83a99081fd2037021e039ea0ec88b0c2bc [INFO] sha for GitHub repo illbexyz/tinyrenderer-rust: da176a83a99081fd2037021e039ea0ec88b0c2bc [INFO] validating manifest of illbexyz/tinyrenderer-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of illbexyz/tinyrenderer-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing illbexyz/tinyrenderer-rust [INFO] finished frobbing illbexyz/tinyrenderer-rust [INFO] frobbed toml for illbexyz/tinyrenderer-rust written to work/ex/clippy-test-run/sources/stable/gh/illbexyz/tinyrenderer-rust/Cargo.toml [INFO] started frobbing illbexyz/tinyrenderer-rust [INFO] finished frobbing illbexyz/tinyrenderer-rust [INFO] frobbed toml for illbexyz/tinyrenderer-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/illbexyz/tinyrenderer-rust/Cargo.toml [INFO] crate illbexyz/tinyrenderer-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting illbexyz/tinyrenderer-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/illbexyz/tinyrenderer-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 24e1395625f0afa298ef6a142c8dc8a454e7d74d79080fe19af5662e3a7adafa [INFO] running `"docker" "start" "-a" "24e1395625f0afa298ef6a142c8dc8a454e7d74d79080fe19af5662e3a7adafa"` [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking tinyrenderer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `light_dir` [INFO] [stderr] --> src/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | let light_dir = Vec3::new(0.0, 0.0, -1.0).normalize(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_light_dir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/utils.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | let p3 = p1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*p1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / if (p1.x - p2.x).abs() < (p1.y - p2.y).abs() { [INFO] [stderr] 19 | | true [INFO] [stderr] 20 | | } else { [INFO] [stderr] 21 | | false [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ help: you can reduce it to: `(p1.x - p2.x).abs() < (p1.y - p2.y).abs()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | let p1_cp = p1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*p1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | let p2_cp = p2.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for x in p1.x .. p2.x+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `p1.x..=p2.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | fn barycentric(points: &Vec, p: Point) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | (points[2].x - points[0].x) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[2].x - points[0].x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | (points[1].x - points[0].x) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[1].x - points[0].x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | (points[0].x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[0].x - p.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | (points[2].y - points[0].y) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[2].y - points[0].y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | (points[1].y - points[0].y) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[1].y - points[0].y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | (points[0].y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[0].y - p.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:84:59 [INFO] [stderr] | [INFO] [stderr] 84 | fn triangle(img: &mut ImageBuffer, Vec>, pts: &Vec, color: Rgb) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | for i in bboxmin.x .. bboxmax.x + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `bboxmin.x..=bboxmax.x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | for j in bboxmin.y .. bboxmax.y + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `bboxmin.y..=bboxmax.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:33 [INFO] [stderr] | [INFO] [stderr] 122 | (((v0.x + 1.) * (width as f64) / 2.) as i32).min(width as i32 - 1), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | (((v0.y + 1.) * (height as f64) / 2.) as i32).min(height as i32 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | (((v1.x + 1.) * (width as f64) / 2.) as i32).min(width as i32 - 1), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:127:33 [INFO] [stderr] | [INFO] [stderr] 127 | (((v1.y + 1.) * (height as f64) / 2.) as i32).min(height as i32 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:145:49 [INFO] [stderr] | [INFO] [stderr] 145 | (((world_coords[j].x+1.0) * (width as f64)/2.0) as i32).min(width as i32 - 1), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:49 [INFO] [stderr] | [INFO] [stderr] 146 | (((world_coords[j].y+1.0) * (height as f64)/2.0) as i32).min(height as i32 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | let ref mut fout = File::create("output.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create("output.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `light_dir` [INFO] [stderr] --> src/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | let light_dir = Vec3::new(0.0, 0.0, -1.0).normalize(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_light_dir` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/utils.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | let p3 = p1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*p1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / if (p1.x - p2.x).abs() < (p1.y - p2.y).abs() { [INFO] [stderr] 19 | | true [INFO] [stderr] 20 | | } else { [INFO] [stderr] 21 | | false [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_________^ help: you can reduce it to: `(p1.x - p2.x).abs() < (p1.y - p2.y).abs()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | let p1_cp = p1.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*p1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | let p2_cp = p2.clone(); [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*p2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | for x in p1.x .. p2.x+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `p1.x..=p2.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | fn barycentric(points: &Vec, p: Point) -> Vec3 { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | (points[2].x - points[0].x) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[2].x - points[0].x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | (points[1].x - points[0].x) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[1].x - points[0].x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | (points[0].x - p.x) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[0].x - p.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | (points[2].y - points[0].y) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[2].y - points[0].y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | (points[1].y - points[0].y) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[1].y - points[0].y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | (points[0].y - p.y) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(points[0].y - p.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:84:59 [INFO] [stderr] | [INFO] [stderr] 84 | fn triangle(img: &mut ImageBuffer, Vec>, pts: &Vec, color: Rgb) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | for i in bboxmin.x .. bboxmax.x + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `bboxmin.x..=bboxmax.x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | for j in bboxmin.y .. bboxmax.y + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `bboxmin.y..=bboxmax.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:33 [INFO] [stderr] | [INFO] [stderr] 122 | (((v0.x + 1.) * (width as f64) / 2.) as i32).min(width as i32 - 1), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | (((v0.y + 1.) * (height as f64) / 2.) as i32).min(height as i32 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:126:33 [INFO] [stderr] | [INFO] [stderr] 126 | (((v1.x + 1.) * (width as f64) / 2.) as i32).min(width as i32 - 1), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:127:33 [INFO] [stderr] | [INFO] [stderr] 127 | (((v1.y + 1.) * (height as f64) / 2.) as i32).min(height as i32 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:145:49 [INFO] [stderr] | [INFO] [stderr] 145 | (((world_coords[j].x+1.0) * (width as f64)/2.0) as i32).min(width as i32 - 1), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:49 [INFO] [stderr] | [INFO] [stderr] 146 | (((world_coords[j].y+1.0) * (height as f64)/2.0) as i32).min(height as i32 - 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | let ref mut fout = File::create("output.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------- help: try: `let fout = &mut File::create("output.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.82s [INFO] running `"docker" "inspect" "24e1395625f0afa298ef6a142c8dc8a454e7d74d79080fe19af5662e3a7adafa"` [INFO] running `"docker" "rm" "-f" "24e1395625f0afa298ef6a142c8dc8a454e7d74d79080fe19af5662e3a7adafa"` [INFO] [stdout] 24e1395625f0afa298ef6a142c8dc8a454e7d74d79080fe19af5662e3a7adafa