[INFO] updating cached repository ilikeavocadoes/form_reader [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ilikeavocadoes/form_reader [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ilikeavocadoes/form_reader" "work/ex/clippy-test-run/sources/stable/gh/ilikeavocadoes/form_reader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ilikeavocadoes/form_reader'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ilikeavocadoes/form_reader" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ilikeavocadoes/form_reader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ilikeavocadoes/form_reader'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bc46e2d33b379ea44cae79df387fbb67adc458ad [INFO] sha for GitHub repo ilikeavocadoes/form_reader: bc46e2d33b379ea44cae79df387fbb67adc458ad [INFO] validating manifest of ilikeavocadoes/form_reader on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ilikeavocadoes/form_reader on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ilikeavocadoes/form_reader [INFO] finished frobbing ilikeavocadoes/form_reader [INFO] frobbed toml for ilikeavocadoes/form_reader written to work/ex/clippy-test-run/sources/stable/gh/ilikeavocadoes/form_reader/Cargo.toml [INFO] started frobbing ilikeavocadoes/form_reader [INFO] finished frobbing ilikeavocadoes/form_reader [INFO] frobbed toml for ilikeavocadoes/form_reader written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ilikeavocadoes/form_reader/Cargo.toml [INFO] crate ilikeavocadoes/form_reader has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ilikeavocadoes/form_reader against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ilikeavocadoes/form_reader:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec647130d70264ee7838460a2d80089a6fb60442c6299ad5af4024da931e741a [INFO] running `"docker" "start" "-a" "ec647130d70264ee7838460a2d80089a6fb60442c6299ad5af4024da931e741a"` [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Compiling syn v0.14.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking quickcheck v0.6.2 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking imageproc v0.15.0 [INFO] [stderr] Checking form_reader v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:49:85 [INFO] [stderr] | [INFO] [stderr] 49 | fn draw_hollow_polygon(image: &mut I, points: &Vec<(f32, f32)>, color: I::Pixel) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 130 | | if !next_outer_pixel_right_color { [INFO] [stderr] 131 | | let (next_direction, next_x, next_y) = match direction { [INFO] [stderr] 132 | | Direction::Right => (Direction::Up, x - 1, y + 1), [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | } else if !next_outer_pixel_right_color { [INFO] [stderr] 130 | let (next_direction, next_x, next_y) = match direction { [INFO] [stderr] 131 | Direction::Right => (Direction::Up, x - 1, y + 1), [INFO] [stderr] 132 | Direction::Down => (Direction::Right, x + 1, y + 1), [INFO] [stderr] 133 | Direction::Left => (Direction::Down, x + 1, y - 1), [INFO] [stderr] 134 | Direction::Up => (Direction::Left, x - 1, y - 1), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:265:9 [INFO] [stderr] | [INFO] [stderr] 265 | / if (x as u32) < w && (y as u32) < h && x >= 0 && y >= 0 { [INFO] [stderr] 266 | | if flooded.get_pixel(x as u32, y as u32) == &target_color { [INFO] [stderr] 267 | | flooded.put_pixel(x as u32, y as u32, replacement_color.clone()); [INFO] [stderr] 268 | | queue.push_back((x + 1, y)); [INFO] [stderr] ... | [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 265 | if (x as u32) < w && (y as u32) < h && x >= 0 && y >= 0 && flooded.get_pixel(x as u32, y as u32) == &target_color { [INFO] [stderr] 266 | flooded.put_pixel(x as u32, y as u32, replacement_color.clone()); [INFO] [stderr] 267 | queue.push_back((x + 1, y)); [INFO] [stderr] 268 | queue.push_back((x - 1, y)); [INFO] [stderr] 269 | queue.push_back((x, y + 1)); [INFO] [stderr] 270 | queue.push_back((x, y - 1)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_out` [INFO] [stderr] --> src/main.rs:86:10 [INFO] [stderr] | [INFO] [stderr] 86 | let (x_out, y_out) = (x - 1, y); [INFO] [stderr] | ^^^^^ help: consider using `_x_out` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_out` [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | let (x_out, y_out) = (x - 1, y); [INFO] [stderr] | ^^^^^ help: consider using `_y_out` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_first` [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | let x_first = x; [INFO] [stderr] | ^^^^^^^ help: consider using `_x_first` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_first` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let y_first = y; [INFO] [stderr] | ^^^^^^^ help: consider using `_y_first` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:98:81 [INFO] [stderr] | [INFO] [stderr] 98 | fn follow_contour(img: &image::GrayImage, x: i64, y: i64, direction: Direction, mut contour: Vec<(i64, i64)>) -> Vec<(i64, i64)> { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | fn draw_hollow_polygon(image: &mut I, points: &Vec<(f32, f32)>, color: I::Pixel) -> () [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(f32, f32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | follow_contour(image, x as i64, y as i64, Direction::Right, vec![]) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | follow_contour(image, x as i64, y as i64, Direction::Right, vec![]) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:103:11 [INFO] [stderr] | [INFO] [stderr] 103 | while to_follow.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_follow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if (contour.len() != 0) && (contour[0] == (x, y)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contour.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `path`. [INFO] [stderr] --> src/main.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | for j in i + 1 .. path.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 159 | for in path.iter().skip(i + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:257:82 [INFO] [stderr] | [INFO] [stderr] 257 | fn flood_breadth_first(img: image::GrayImage, x: i64, y: i64, replacement_color: &image::Luma) -> image::GrayImage { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Luma` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:258:24 [INFO] [stderr] | [INFO] [stderr] 258 | let target_color = img.get_pixel(x as u32, y as u32).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*img.get_pixel(x as u32, y as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:49:85 [INFO] [stderr] | [INFO] [stderr] 49 | fn draw_hollow_polygon(image: &mut I, points: &Vec<(f32, f32)>, color: I::Pixel) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:129:16 [INFO] [stderr] | [INFO] [stderr] 129 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 130 | | if !next_outer_pixel_right_color { [INFO] [stderr] 131 | | let (next_direction, next_x, next_y) = match direction { [INFO] [stderr] 132 | | Direction::Right => (Direction::Up, x - 1, y + 1), [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | } else if !next_outer_pixel_right_color { [INFO] [stderr] 130 | let (next_direction, next_x, next_y) = match direction { [INFO] [stderr] 131 | Direction::Right => (Direction::Up, x - 1, y + 1), [INFO] [stderr] 132 | Direction::Down => (Direction::Right, x + 1, y + 1), [INFO] [stderr] 133 | Direction::Left => (Direction::Down, x + 1, y - 1), [INFO] [stderr] 134 | Direction::Up => (Direction::Left, x - 1, y - 1), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:265:9 [INFO] [stderr] | [INFO] [stderr] 265 | / if (x as u32) < w && (y as u32) < h && x >= 0 && y >= 0 { [INFO] [stderr] 266 | | if flooded.get_pixel(x as u32, y as u32) == &target_color { [INFO] [stderr] 267 | | flooded.put_pixel(x as u32, y as u32, replacement_color.clone()); [INFO] [stderr] 268 | | queue.push_back((x + 1, y)); [INFO] [stderr] ... | [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 265 | if (x as u32) < w && (y as u32) < h && x >= 0 && y >= 0 && flooded.get_pixel(x as u32, y as u32) == &target_color { [INFO] [stderr] 266 | flooded.put_pixel(x as u32, y as u32, replacement_color.clone()); [INFO] [stderr] 267 | queue.push_back((x + 1, y)); [INFO] [stderr] 268 | queue.push_back((x - 1, y)); [INFO] [stderr] 269 | queue.push_back((x, y + 1)); [INFO] [stderr] 270 | queue.push_back((x, y - 1)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_out` [INFO] [stderr] --> src/main.rs:86:10 [INFO] [stderr] | [INFO] [stderr] 86 | let (x_out, y_out) = (x - 1, y); [INFO] [stderr] | ^^^^^ help: consider using `_x_out` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_out` [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | let (x_out, y_out) = (x - 1, y); [INFO] [stderr] | ^^^^^ help: consider using `_y_out` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x_first` [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | let x_first = x; [INFO] [stderr] | ^^^^^^^ help: consider using `_x_first` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y_first` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let y_first = y; [INFO] [stderr] | ^^^^^^^ help: consider using `_y_first` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:98:81 [INFO] [stderr] | [INFO] [stderr] 98 | fn follow_contour(img: &image::GrayImage, x: i64, y: i64, direction: Direction, mut contour: Vec<(i64, i64)>) -> Vec<(i64, i64)> { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | fn draw_hollow_polygon(image: &mut I, points: &Vec<(f32, f32)>, color: I::Pixel) -> () [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(f32, f32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | follow_contour(image, x as i64, y as i64, Direction::Right, vec![]) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | follow_contour(image, x as i64, y as i64, Direction::Right, vec![]) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:103:11 [INFO] [stderr] | [INFO] [stderr] 103 | while to_follow.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_follow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if (contour.len() != 0) && (contour[0] == (x, y)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!contour.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `path`. [INFO] [stderr] --> src/main.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | for j in i + 1 .. path.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 159 | for in path.iter().skip(i + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:257:82 [INFO] [stderr] | [INFO] [stderr] 257 | fn flood_breadth_first(img: image::GrayImage, x: i64, y: i64, replacement_color: &image::Luma) -> image::GrayImage { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `image::Luma` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:258:24 [INFO] [stderr] | [INFO] [stderr] 258 | let target_color = img.get_pixel(x as u32, y as u32).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*img.get_pixel(x as u32, y as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `"docker" "inspect" "ec647130d70264ee7838460a2d80089a6fb60442c6299ad5af4024da931e741a"` [INFO] running `"docker" "rm" "-f" "ec647130d70264ee7838460a2d80089a6fb60442c6299ad5af4024da931e741a"` [INFO] [stdout] ec647130d70264ee7838460a2d80089a6fb60442c6299ad5af4024da931e741a