[INFO] updating cached repository ikurek/PEA-Projekt1 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ikurek/PEA-Projekt1 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ikurek/PEA-Projekt1" "work/ex/clippy-test-run/sources/stable/gh/ikurek/PEA-Projekt1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ikurek/PEA-Projekt1'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ikurek/PEA-Projekt1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ikurek/PEA-Projekt1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ikurek/PEA-Projekt1'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3011bb2a17462ed4e6c926910d68f52e512c219d [INFO] sha for GitHub repo ikurek/PEA-Projekt1: 3011bb2a17462ed4e6c926910d68f52e512c219d [INFO] validating manifest of ikurek/PEA-Projekt1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ikurek/PEA-Projekt1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ikurek/PEA-Projekt1 [INFO] finished frobbing ikurek/PEA-Projekt1 [INFO] frobbed toml for ikurek/PEA-Projekt1 written to work/ex/clippy-test-run/sources/stable/gh/ikurek/PEA-Projekt1/Cargo.toml [INFO] started frobbing ikurek/PEA-Projekt1 [INFO] finished frobbing ikurek/PEA-Projekt1 [INFO] frobbed toml for ikurek/PEA-Projekt1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ikurek/PEA-Projekt1/Cargo.toml [INFO] crate ikurek/PEA-Projekt1 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ikurek/PEA-Projekt1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ikurek/PEA-Projekt1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 516bc262e2e07b4a1089d8511ed6d66aafb5cc1919db5cd817d3fca285008b6d [INFO] running `"docker" "start" "-a" "516bc262e2e07b4a1089d8511ed6d66aafb5cc1919db5cd817d3fca285008b6d"` [INFO] [stderr] Checking permutohedron v0.2.2 [INFO] [stderr] Checking projekt1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/print_utils.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/print_utils.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/print_utils.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/print_utils.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/file_reader.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod file_reader { [INFO] [stderr] 2 | | use std::io::BufReader; [INFO] [stderr] 3 | | use std::io::BufRead; [INFO] [stderr] 4 | | use std::error::Error; [INFO] [stderr] ... | [INFO] [stderr] 62 | | [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_reader.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_reader.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / return line.split_whitespace() [INFO] [stderr] 58 | | .map(|s| s.parse().unwrap()) [INFO] [stderr] 59 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | line.split_whitespace() [INFO] [stderr] 58 | .map(|s| s.parse().unwrap()) [INFO] [stderr] 59 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/print_utils.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod print_utils { [INFO] [stderr] 2 | | [INFO] [stderr] 3 | | //Drukuje na ekran macierz [INFO] [stderr] 4 | | pub fn print_matrix(matrix: &Vec>) { [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/brute_force_solution.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub mod brute_force_solution { [INFO] [stderr] 5 | | use brute_force_solution::permutohedron::LexicalPermutation; [INFO] [stderr] 6 | | use brute_force_solution::time::PreciseTime; [INFO] [stderr] 7 | | use print_utils::print_utils as PrintUtlisModule; [INFO] [stderr] ... | [INFO] [stderr] 92 | | [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/brute_force_solution.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return duration_in_ns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `duration_in_ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/dynamic_programing_solution.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub mod dynamic_programing_solution { [INFO] [stderr] 5 | | use dynamic_programing_solution::time::PreciseTime; [INFO] [stderr] 6 | | use dynamic_programing_solution::num_traits::pow; [INFO] [stderr] 7 | | use print_utils::print_utils as PrintUtlisModule; [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return duration_in_ns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `duration_in_ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/dynamic_programing_solution.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if (print_info) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/dynamic_programing_solution.rs:94:12 [INFO] [stderr] | [INFO] [stderr] 94 | if (print_info) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return connections[start as usize][set as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `connections[start as usize][set as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return result_path.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_path.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/graph_generator.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / pub mod graph_generator { [INFO] [stderr] 4 | | use graph_generator::rand; [INFO] [stderr] 5 | | use graph_generator::rand::distributions::Range; [INFO] [stderr] 6 | | use graph_generator::rand::distributions::IndependentSample; [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph_generator.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/file_reader.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod file_reader { [INFO] [stderr] 2 | | use std::io::BufReader; [INFO] [stderr] 3 | | use std::io::BufRead; [INFO] [stderr] 4 | | use std::error::Error; [INFO] [stderr] ... | [INFO] [stderr] 62 | | [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_reader.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_reader.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / return line.split_whitespace() [INFO] [stderr] 58 | | .map(|s| s.parse().unwrap()) [INFO] [stderr] 59 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | line.split_whitespace() [INFO] [stderr] 58 | .map(|s| s.parse().unwrap()) [INFO] [stderr] 59 | .collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/print_utils.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub mod print_utils { [INFO] [stderr] 2 | | [INFO] [stderr] 3 | | //Drukuje na ekran macierz [INFO] [stderr] 4 | | pub fn print_matrix(matrix: &Vec>) { [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/brute_force_solution.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub mod brute_force_solution { [INFO] [stderr] 5 | | use brute_force_solution::permutohedron::LexicalPermutation; [INFO] [stderr] 6 | | use brute_force_solution::time::PreciseTime; [INFO] [stderr] 7 | | use print_utils::print_utils as PrintUtlisModule; [INFO] [stderr] ... | [INFO] [stderr] 92 | | [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/brute_force_solution.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return duration_in_ns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `duration_in_ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/dynamic_programing_solution.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub mod dynamic_programing_solution { [INFO] [stderr] 5 | | use dynamic_programing_solution::time::PreciseTime; [INFO] [stderr] 6 | | use dynamic_programing_solution::num_traits::pow; [INFO] [stderr] 7 | | use print_utils::print_utils as PrintUtlisModule; [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return duration_in_ns; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `duration_in_ns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/dynamic_programing_solution.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if (print_info) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/dynamic_programing_solution.rs:94:12 [INFO] [stderr] | [INFO] [stderr] 94 | if (print_info) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return connections[start as usize][set as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `connections[start as usize][set as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dynamic_programing_solution.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | return result_path.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_path.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/graph_generator.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | / pub mod graph_generator { [INFO] [stderr] 4 | | use graph_generator::rand; [INFO] [stderr] 5 | | use graph_generator::rand::distributions::Range; [INFO] [stderr] 6 | | use graph_generator::rand::distributions::IndependentSample; [INFO] [stderr] ... | [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph_generator.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `matrix` is never read [INFO] [stderr] --> src/brute_force_solution.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let mut matrix: Vec> = Vec::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `matrix` is never read [INFO] [stderr] --> src/dynamic_programing_solution.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let mut matrix: Vec> = Vec::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/print_utils.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn print_matrix(matrix: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | average = average + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | average = average / (times.len() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average /= (times.len() as i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brute_force_solution.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn solve(matrix: &Vec>, print_info: bool) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | road_value = road_value + matrix[permutation[index as usize] as usize][permutation[(index + 1) as usize] as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `road_value += matrix[permutation[index as usize] as usize][permutation[(index + 1) as usize] as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dynamic_programing_solution.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | average = average + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average += x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dynamic_programing_solution.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | average = average / (times.len() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average /= (times.len() as i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic_programing_solution.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn solve(matrix: &Vec>, print_info: bool) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_path` doesn't need a mutable reference [INFO] [stderr] --> src/dynamic_programing_solution.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | result_path = get_path(&mut paths, &mut result_path, &power, start, power - 2); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic_programing_solution.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | matrix: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dynamic_programing_solution.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | power: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic_programing_solution.rs:159:28 [INFO] [stderr] | [INFO] [stderr] 159 | fn get_path(mut paths: &Vec>, mut result_path: &mut Vec, power: &i32, start: i32, set: i32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dynamic_programing_solution.rs:159:83 [INFO] [stderr] | [INFO] [stderr] 159 | fn get_path(mut paths: &Vec>, mut result_path: &mut Vec, power: &i32, start: i32, set: i32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_path` doesn't need a mutable reference [INFO] [stderr] --> src/dynamic_programing_solution.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | get_path(&mut paths, &mut result_path, &power, current_node, masked); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: value assigned to `matrix` is never read [INFO] [stderr] --> src/brute_force_solution.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let mut matrix: Vec> = Vec::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `matrix` is never read [INFO] [stderr] --> src/dynamic_programing_solution.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | let mut matrix: Vec> = Vec::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/print_utils.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn print_matrix(matrix: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | average = average + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | average = average / (times.len() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average /= (times.len() as i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brute_force_solution.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn solve(matrix: &Vec>, print_info: bool) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | road_value = road_value + matrix[permutation[index as usize] as usize][permutation[(index + 1) as usize] as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `road_value += matrix[permutation[index as usize] as usize][permutation[(index + 1) as usize] as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/brute_force_solution.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dynamic_programing_solution.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | average = average + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average += x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dynamic_programing_solution.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | average = average / (times.len() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `average /= (times.len() as i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic_programing_solution.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn solve(matrix: &Vec>, print_info: bool) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_path` doesn't need a mutable reference [INFO] [stderr] --> src/dynamic_programing_solution.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | result_path = get_path(&mut paths, &mut result_path, &power, start, power - 2); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic_programing_solution.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | matrix: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dynamic_programing_solution.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | power: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dynamic_programing_solution.rs:159:28 [INFO] [stderr] | [INFO] [stderr] 159 | fn get_path(mut paths: &Vec>, mut result_path: &mut Vec, power: &i32, start: i32, set: i32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dynamic_programing_solution.rs:159:83 [INFO] [stderr] | [INFO] [stderr] 159 | fn get_path(mut paths: &Vec>, mut result_path: &mut Vec, power: &i32, start: i32, set: i32) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_path` doesn't need a mutable reference [INFO] [stderr] --> src/dynamic_programing_solution.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | get_path(&mut paths, &mut result_path, &power, current_node, masked); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.88s [INFO] running `"docker" "inspect" "516bc262e2e07b4a1089d8511ed6d66aafb5cc1919db5cd817d3fca285008b6d"` [INFO] running `"docker" "rm" "-f" "516bc262e2e07b4a1089d8511ed6d66aafb5cc1919db5cd817d3fca285008b6d"` [INFO] [stdout] 516bc262e2e07b4a1089d8511ed6d66aafb5cc1919db5cd817d3fca285008b6d