[INFO] updating cached repository ijks/piet-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ijks/piet-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ijks/piet-rs" "work/ex/clippy-test-run/sources/stable/gh/ijks/piet-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ijks/piet-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ijks/piet-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ijks/piet-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ijks/piet-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c9f85558145516a0b07976ce5a5ad135e26a5003 [INFO] sha for GitHub repo ijks/piet-rs: c9f85558145516a0b07976ce5a5ad135e26a5003 [INFO] validating manifest of ijks/piet-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ijks/piet-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ijks/piet-rs [INFO] finished frobbing ijks/piet-rs [INFO] frobbed toml for ijks/piet-rs written to work/ex/clippy-test-run/sources/stable/gh/ijks/piet-rs/Cargo.toml [INFO] started frobbing ijks/piet-rs [INFO] finished frobbing ijks/piet-rs [INFO] frobbed toml for ijks/piet-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ijks/piet-rs/Cargo.toml [INFO] crate ijks/piet-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ijks/piet-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ijks/piet-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee5d42b8e6a37be10ed93cec28a2e450adc177e0e6e195d0faf593d095bbe9f8 [INFO] running `"docker" "start" "-a" "ee5d42b8e6a37be10ed93cec28a2e450adc177e0e6e195d0faf593d095bbe9f8"` [INFO] [stderr] Compiling cc v1.0.2 [INFO] [stderr] Checking num-rational v0.1.39 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking piet v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/program.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/program.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/program.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interpreter.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/program.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/program.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/program.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | 0xffc0c0 => Composite(Red, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_c0c0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | 0xffffc0 => Composite(Yellow, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffc0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | 0xc0ffc0 => Composite(Green, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_ffc0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | 0xc0ffff => Composite(Cyan, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | 0xc0c0ff => Composite(Blue, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_c0ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | 0xffc0ff => Composite(Magenta, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_c0ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | 0xff0000 => Composite(Red, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | 0xffff00 => Composite(Yellow, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | 0x00ff00 => Composite(Green, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | 0x00ffff => Composite(Cyan, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | 0x0000ff => Composite(Blue, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | 0xff00ff => Composite(Magenta, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | 0xc00000 => Composite(Red, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | 0xc0c000 => Composite(Yellow, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_c000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | 0x00c000 => Composite(Green, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_c000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | 0x00c0c0 => Composite(Cyan, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_c0c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | 0x0000c0 => Composite(Blue, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | 0xc000c0 => Composite(Magenta, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_00c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | 0xffffff => White, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | 0x000000 => Black, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Ordering` [INFO] [stderr] --> src/interpreter.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp::Ordering; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | 0xffc0c0 => Composite(Red, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_c0c0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | 0xffffc0 => Composite(Yellow, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffc0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | 0xc0ffc0 => Composite(Green, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_ffc0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | 0xc0ffff => Composite(Cyan, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | 0xc0c0ff => Composite(Blue, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_c0ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | 0xffc0ff => Composite(Magenta, Light), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_c0ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | 0xff0000 => Composite(Red, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | 0xffff00 => Composite(Yellow, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | 0x00ff00 => Composite(Green, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ff00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | 0x00ffff => Composite(Cyan, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | 0x0000ff => Composite(Blue, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | 0xff00ff => Composite(Magenta, Normal), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | 0xc00000 => Composite(Red, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | 0xc0c000 => Composite(Yellow, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_c000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | 0x00c000 => Composite(Green, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_c000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | 0x00c0c0 => Composite(Cyan, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_c0c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | 0x0000c0 => Composite(Blue, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | 0xc000c0 => Composite(Magenta, Dark), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00c0_00c0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | 0xffffff => White, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/color.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | 0x000000 => Black, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Ordering` [INFO] [stderr] --> src/interpreter.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::cmp::Ordering; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/interpreter.rs:120:29 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|&&(x, y)| y == farthest_y) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/interpreter.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | .filter(|&&(x, y)| x == farthest_x) [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/program.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | let (width, height) = self.size; [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Up` [INFO] [stderr] --> src/interpreter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Up, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/interpreter.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/interpreter.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate_clockwise` [INFO] [stderr] --> src/interpreter.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn rotate_clockwise(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate_counterclockwise` [INFO] [stderr] --> src/interpreter.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn rotate_counterclockwise(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/interpreter.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `switch` [INFO] [stderr] --> src/interpreter.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn switch(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current_block` [INFO] [stderr] --> src/interpreter.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | fn current_block(&self) -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next_coords` [INFO] [stderr] --> src/interpreter.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | fn next_coords(&self) -> Coords { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `x_key` [INFO] [stderr] --> src/interpreter.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | fn x_key(&(x, _): &Coords) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `y_key` [INFO] [stderr] --> src/interpreter.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | fn y_key(&(_, y): &Coords) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `execute_command` [INFO] [stderr] --> src/interpreter.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | fn execute_command(&mut self, command: &Command) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pointer` [INFO] [stderr] --> src/interpreter.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | fn pointer(&mut self, steps: i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `switch` [INFO] [stderr] --> src/interpreter.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | fn switch(&mut self, times: i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `index_to_coords` [INFO] [stderr] --> src/program.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | fn index_to_coords(&self, index: usize) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | let (r, g, b) = (r as u32, g as u32, b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | let (r, g, b) = (r as u32, g as u32, b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:82:46 [INFO] [stderr] | [INFO] [stderr] 82 | let (r, g, b) = (r as u32, g as u32, b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | let iter = current_block.iter().map(|&c| c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `current_block.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / current_block.iter() [INFO] [stderr] 120 | | .filter(|&&(x, y)| y == farthest_y) [INFO] [stderr] 121 | | .map(|&y| y) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 119 | current_block.iter() [INFO] [stderr] 120 | .filter(|&&(x, y)| y == farthest_y).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | let iter = current_block.iter().map(|&c| c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `current_block.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / current_block.iter() [INFO] [stderr] 133 | | .filter(|&&(x, y)| x == farthest_x) [INFO] [stderr] 134 | | .map(|&x| x) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 132 | current_block.iter() [INFO] [stderr] 133 | .filter(|&&(x, y)| x == farthest_x).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter.rs:167:44 [INFO] [stderr] | [INFO] [stderr] 167 | fn execute_command(&mut self, command: &Command) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Self { [INFO] [stderr] 9 | | Stack(Vec::new()) [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/interpreter.rs:120:29 [INFO] [stderr] | [INFO] [stderr] 120 | .filter(|&&(x, y)| y == farthest_y) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/interpreter.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | .filter(|&&(x, y)| x == farthest_x) [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/program.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | let (width, height) = self.size; [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Up` [INFO] [stderr] --> src/interpreter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Up, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/interpreter.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/interpreter.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Left, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate_clockwise` [INFO] [stderr] --> src/interpreter.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn rotate_clockwise(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate_counterclockwise` [INFO] [stderr] --> src/interpreter.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn rotate_counterclockwise(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Right` [INFO] [stderr] --> src/interpreter.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | Right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `switch` [INFO] [stderr] --> src/interpreter.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn switch(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `current_block` [INFO] [stderr] --> src/interpreter.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | fn current_block(&self) -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `next_coords` [INFO] [stderr] --> src/interpreter.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | fn next_coords(&self) -> Coords { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `x_key` [INFO] [stderr] --> src/interpreter.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | fn x_key(&(x, _): &Coords) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `y_key` [INFO] [stderr] --> src/interpreter.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | fn y_key(&(_, y): &Coords) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `execute_command` [INFO] [stderr] --> src/interpreter.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | fn execute_command(&mut self, command: &Command) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pointer` [INFO] [stderr] --> src/interpreter.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | fn pointer(&mut self, steps: i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `switch` [INFO] [stderr] --> src/interpreter.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | fn switch(&mut self, times: i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | let (r, g, b) = (r as u32, g as u32, b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | let (r, g, b) = (r as u32, g as u32, b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:82:46 [INFO] [stderr] | [INFO] [stderr] 82 | let (r, g, b) = (r as u32, g as u32, b as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:111:24 [INFO] [stderr] | [INFO] [stderr] 111 | let iter = current_block.iter().map(|&c| c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `current_block.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / current_block.iter() [INFO] [stderr] 120 | | .filter(|&&(x, y)| y == farthest_y) [INFO] [stderr] 121 | | .map(|&y| y) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 119 | current_block.iter() [INFO] [stderr] 120 | .filter(|&&(x, y)| y == farthest_y).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | let iter = current_block.iter().map(|&c| c); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `current_block.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/interpreter.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / current_block.iter() [INFO] [stderr] 133 | | .filter(|&&(x, y)| x == farthest_x) [INFO] [stderr] 134 | | .map(|&x| x) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 132 | current_block.iter() [INFO] [stderr] 133 | .filter(|&&(x, y)| x == farthest_x).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/interpreter.rs:167:44 [INFO] [stderr] | [INFO] [stderr] 167 | fn execute_command(&mut self, command: &Command) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Self { [INFO] [stderr] 9 | | Stack(Vec::new()) [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `codel_size` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let codel_size = matches.value_of("codel_size").map(|_| unimplemented!()); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_codel_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | interpreter.run(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `codel_size` [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | let codel_size = matches.value_of("codel_size").map(|_| unimplemented!()); [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_codel_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | interpreter.run(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.92s [INFO] running `"docker" "inspect" "ee5d42b8e6a37be10ed93cec28a2e450adc177e0e6e195d0faf593d095bbe9f8"` [INFO] running `"docker" "rm" "-f" "ee5d42b8e6a37be10ed93cec28a2e450adc177e0e6e195d0faf593d095bbe9f8"` [INFO] [stdout] ee5d42b8e6a37be10ed93cec28a2e450adc177e0e6e195d0faf593d095bbe9f8