[INFO] updating cached repository ignatenkobrain/rust2rpm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ignatenkobrain/rust2rpm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ignatenkobrain/rust2rpm" "work/ex/clippy-test-run/sources/stable/gh/ignatenkobrain/rust2rpm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ignatenkobrain/rust2rpm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ignatenkobrain/rust2rpm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ignatenkobrain/rust2rpm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ignatenkobrain/rust2rpm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77a5c30faac95fde3ac1a151b1a7e4a9a1e1deb5 [INFO] sha for GitHub repo ignatenkobrain/rust2rpm: 77a5c30faac95fde3ac1a151b1a7e4a9a1e1deb5 [INFO] validating manifest of ignatenkobrain/rust2rpm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ignatenkobrain/rust2rpm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ignatenkobrain/rust2rpm [INFO] finished frobbing ignatenkobrain/rust2rpm [INFO] frobbed toml for ignatenkobrain/rust2rpm written to work/ex/clippy-test-run/sources/stable/gh/ignatenkobrain/rust2rpm/Cargo.toml [INFO] started frobbing ignatenkobrain/rust2rpm [INFO] finished frobbing ignatenkobrain/rust2rpm [INFO] frobbed toml for ignatenkobrain/rust2rpm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ignatenkobrain/rust2rpm/Cargo.toml [INFO] crate ignatenkobrain/rust2rpm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ignatenkobrain/rust2rpm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ignatenkobrain/rust2rpm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2374fa206d0f28c5b74b156b5ca7cafb6e915ec914199e3bbadfac14145e7a0f [INFO] running `"docker" "start" "-a" "2374fa206d0f28c5b74b156b5ca7cafb6e915ec914199e3bbadfac14145e7a0f"` [INFO] [stderr] Compiling openssl v0.10.14 [INFO] [stderr] Checking home v0.3.3 [INFO] [stderr] Checking rustc-workspace-hack v1.0.0 [INFO] [stderr] Checking shell-escape v0.1.4 [INFO] [stderr] Checking semver-parser v0.9.0 [INFO] [stderr] Compiling libz-sys v1.0.24 [INFO] [stderr] Checking lock_api v0.1.4 [INFO] [stderr] Checking jobserver v0.1.11 [INFO] [stderr] Checking tar v0.4.17 [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Checking flate2 v1.0.4 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling curl-sys v0.4.13 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking crypto-hash v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking curl v0.4.18 [INFO] [stderr] Checking crates-io v0.18.0 [INFO] [stderr] Checking rustfix v0.4.2 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git2-curl v0.8.2 [INFO] [stderr] Checking cargo v0.30.0 [INFO] [stderr] Checking rust2rpm v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crates.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let dep = deps_by_name.get(crate_name.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deps_by_name[crate_name.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crates.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | let dep = deps_by_name.get(crate_name.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deps_by_name[crate_name.as_str()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpm/dependency.rs:54:41 [INFO] [stderr] | [INFO] [stderr] 54 | fn apply_version_range(cap: &str, reqs: &Vec<(&str, V)>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(&str, V)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rpm/dependency.rs:71:12 [INFO] [stderr] | [INFO] [stderr] 71 | if p.pre.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!p.pre.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/rust2rpm.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/rust2rpm.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/rust2rpm.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/rust2rpm.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/rust2rpm.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/rust2rpm.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crates.rs:64:31 [INFO] [stderr] | [INFO] [stderr] 64 | let dep = deps_by_name.get(crate_name.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deps_by_name[crate_name.as_str()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/crates.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | let dep = deps_by_name.get(crate_name.as_str()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deps_by_name[crate_name.as_str()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rpm/dependency.rs:54:41 [INFO] [stderr] | [INFO] [stderr] 54 | fn apply_version_range(cap: &str, reqs: &Vec<(&str, V)>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[(&str, V)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rpm/dependency.rs:71:12 [INFO] [stderr] | [INFO] [stderr] 71 | if p.pre.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!p.pre.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused imports: `collections::BTreeMap`, `fmt` [INFO] [stderr] --> src/bin/rust2rpm.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | use std::{collections::BTreeMap, fmt}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `resolve_dependencies_for_feature` [INFO] [stderr] --> src/bin/rust2rpm.rs:62:52 [INFO] [stderr] | [INFO] [stderr] 62 | use rust2rpm::crates::{create_self_dependency, resolve_dependencies_for_feature}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/rust2rpm.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | for (_, (_, deps)) in &deps_by_feature { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 88 | for (_, deps) in deps_by_feature.values() { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/rust2rpm.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | "" => format!("%{{name}}-devel"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"%{{name}}-devel".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error[E0023]: this pattern has 2 fields, but the corresponding tuple variant has 1 field [INFO] [stderr] --> src/bin/cargo-dependency-generator.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | Some(features, deps) => (features, deps), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ expected 1 field, found 2 [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/bin/cargo-dependency-generator.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | rpm_dep(create_self_dependency(&manifest, &[feature]))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | expected reference, found struct `cargo::core::Dependency` [INFO] [stderr] | help: consider borrowing here: `&create_self_dependency(&manifest, &[feature])` [INFO] [stderr] | [INFO] [stderr] = note: expected type `&cargo::core::Dependency` [INFO] [stderr] found type `cargo::core::Dependency` [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0023, E0308. [INFO] [stderr] For more information about an error, try `rustc --explain E0023`. [INFO] [stderr] error: Could not compile `rust2rpm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused imports: `collections::BTreeMap`, `fmt` [INFO] [stderr] --> src/bin/rust2rpm.rs:17:11 [INFO] [stderr] | [INFO] [stderr] 17 | use std::{collections::BTreeMap, fmt}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `resolve_dependencies_for_feature` [INFO] [stderr] --> src/bin/rust2rpm.rs:62:52 [INFO] [stderr] | [INFO] [stderr] 62 | use rust2rpm::crates::{create_self_dependency, resolve_dependencies_for_feature}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error[E0023]: this pattern has 2 fields, but the corresponding tuple variant has 1 field [INFO] [stderr] --> src/bin/cargo-dependency-generator.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | Some(features, deps) => (features, deps), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ expected 1 field, found 2 [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/bin/cargo-dependency-generator.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | rpm_dep(create_self_dependency(&manifest, &[feature]))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | expected reference, found struct `cargo::core::Dependency` [INFO] [stderr] | help: consider borrowing here: `&create_self_dependency(&manifest, &[feature])` [INFO] [stderr] | [INFO] [stderr] = note: expected type `&cargo::core::Dependency` [INFO] [stderr] found type `cargo::core::Dependency` [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0023, E0308. [INFO] [stderr] For more information about an error, try `rustc --explain E0023`. [INFO] [stderr] error: Could not compile `rust2rpm`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/rust2rpm.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | for (_, (_, deps)) in &deps_by_feature { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 88 | for (_, deps) in deps_by_feature.values() { [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/bin/rust2rpm.rs:105:19 [INFO] [stderr] | [INFO] [stderr] 105 | "" => format!("%{{name}}-devel"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"%{{name}}-devel".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2374fa206d0f28c5b74b156b5ca7cafb6e915ec914199e3bbadfac14145e7a0f"` [INFO] running `"docker" "rm" "-f" "2374fa206d0f28c5b74b156b5ca7cafb6e915ec914199e3bbadfac14145e7a0f"` [INFO] [stdout] 2374fa206d0f28c5b74b156b5ca7cafb6e915ec914199e3bbadfac14145e7a0f