[INFO] updating cached repository ifschleife/rust_tracing
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ifschleife/rust_tracing
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ifschleife/rust_tracing" "work/ex/clippy-test-run/sources/stable/gh/ifschleife/rust_tracing"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ifschleife/rust_tracing'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ifschleife/rust_tracing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ifschleife/rust_tracing"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ifschleife/rust_tracing'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 522d94d80bbe517a860ca714ad8c5e038a37d40e
[INFO] sha for GitHub repo ifschleife/rust_tracing: 522d94d80bbe517a860ca714ad8c5e038a37d40e
[INFO] validating manifest of ifschleife/rust_tracing on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ifschleife/rust_tracing on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ifschleife/rust_tracing
[INFO] finished frobbing ifschleife/rust_tracing
[INFO] frobbed toml for ifschleife/rust_tracing written to work/ex/clippy-test-run/sources/stable/gh/ifschleife/rust_tracing/Cargo.toml
[INFO] started frobbing ifschleife/rust_tracing
[INFO] finished frobbing ifschleife/rust_tracing
[INFO] frobbed toml for ifschleife/rust_tracing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ifschleife/rust_tracing/Cargo.toml
[INFO] crate ifschleife/rust_tracing has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ifschleife/rust_tracing against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ifschleife/rust_tracing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c4f8d234d482ca89d23067af8b4116894d7509e3160d77c420cf2125c2c7cd07
[INFO] running `"docker" "start" "-a" "c4f8d234d482ca89d23067af8b4116894d7509e3160d77c420cf2125c2c7cd07"`
[INFO] [stderr]     Checking rand v0.5.2
[INFO] [stderr]    Compiling num-derive v0.2.2
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking rust_tracing v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             u: u,
[INFO] [stderr]    |             ^^^^ help: replace it with: `u`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             v: v,
[INFO] [stderr]    |             ^^^^ help: replace it with: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:148:13
[INFO] [stderr]     |
[INFO] [stderr] 148 |             origin: origin,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `origin`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |             direction: direction,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:30:51
[INFO] [stderr]    |
[INFO] [stderr] 30 |                         scene.objects.push(Sphere{center: center, radius: 0.2, material: Material::Lambertian{albedo: vec3f(albedo_x, albedo_y, albedo_z)}});
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:37:51
[INFO] [stderr]    |
[INFO] [stderr] 37 |                         scene.objects.push(Sphere{center: center, radius: 0.2, material: Material::Metal{albedo: vec3f(albedo_x, albedo_y, albedo_z), fuzz: fuzziness}});
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:40:51
[INFO] [stderr]    |
[INFO] [stderr] 40 |                         scene.objects.push(Sphere{center: center, radius: 0.2, material: Material::Dielectric{refraction_index: 1.5}});
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             u: u,
[INFO] [stderr]    |             ^^^^ help: replace it with: `u`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/camera.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             v: v,
[INFO] [stderr]    |             ^^^^ help: replace it with: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:148:13
[INFO] [stderr]     |
[INFO] [stderr] 148 |             origin: origin,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `origin`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/math.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |             direction: direction,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:30:51
[INFO] [stderr]    |
[INFO] [stderr] 30 |                         scene.objects.push(Sphere{center: center, radius: 0.2, material: Material::Lambertian{albedo: vec3f(albedo_x, albedo_y, albedo_z)}});
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:37:51
[INFO] [stderr]    |
[INFO] [stderr] 37 |                         scene.objects.push(Sphere{center: center, radius: 0.2, material: Material::Metal{albedo: vec3f(albedo_x, albedo_y, albedo_z), fuzz: fuzziness}});
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/scene.rs:40:51
[INFO] [stderr]    |
[INFO] [stderr] 40 |                         scene.objects.push(Sphere{center: center, radius: 0.2, material: Material::Dielectric{refraction_index: 1.5}});
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^ help: replace it with: `center`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/camera.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         return Ray::new(self.origin + offset, self.lower_left_corner + s*self.horizontal + t*self.vertical - self.origin - offset);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ray::new(self.origin + offset, self.lower_left_corner + s*self.horizontal + t*self.vertical - self.origin - offset)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 |             &Material::Lambertian {albedo } => return Material::scatter_lambertian(hit_point, hit_normal, albedo, rng),
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Material::scatter_lambertian(hit_point, hit_normal, albedo, rng)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:32:50
[INFO] [stderr]    |
[INFO] [stderr] 32 |             &Material::Metal { albedo, fuzz } => return Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng),
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:33:59
[INFO] [stderr]    |
[INFO] [stderr] 33 |             &Material::Dielectric { refraction_index } => return Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng),
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return v - 2.0 * dot(v, n) * n;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v - 2.0 * dot(v, n) * n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return self.length_squared().sqrt();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.length_squared().sqrt()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return self.x*self.x + self.y*self.y + self.z*self.z;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x*self.x + self.y*self.y + self.z*self.z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/scene.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         return scene;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `scene`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/camera.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |         return Ray::new(self.origin + offset, self.lower_left_corner + s*self.horizontal + t*self.vertical - self.origin - offset);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ray::new(self.origin + offset, self.lower_left_corner + s*self.horizontal + t*self.vertical - self.origin - offset)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:31:48
[INFO] [stderr]    |
[INFO] [stderr] 31 |             &Material::Lambertian {albedo } => return Material::scatter_lambertian(hit_point, hit_normal, albedo, rng),
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Material::scatter_lambertian(hit_point, hit_normal, albedo, rng)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:32:50
[INFO] [stderr]    |
[INFO] [stderr] 32 |             &Material::Metal { albedo, fuzz } => return Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng),
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:33:59
[INFO] [stderr]    |
[INFO] [stderr] 33 |             &Material::Dielectric { refraction_index } => return Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng),
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/material.rs:92:9
[INFO] [stderr]    |
[INFO] [stderr] 92 |         return v - 2.0 * dot(v, n) * n;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v - 2.0 * dot(v, n) * n`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return self.length_squared().sqrt();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.length_squared().sqrt()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/math.rs:58:9
[INFO] [stderr]    |
[INFO] [stderr] 58 |         return self.x*self.x + self.y*self.y + self.z*self.z;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.x*self.x + self.y*self.y + self.z*self.z`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/scene.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         return scene;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `scene`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/material.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         match self {
[INFO] [stderr] 31 | |             &Material::Lambertian {albedo } => return Material::scatter_lambertian(hit_point, hit_normal, albedo, rng),
[INFO] [stderr] 32 | |             &Material::Metal { albedo, fuzz } => return Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng),
[INFO] [stderr] 33 | |             &Material::Dielectric { refraction_index } => return Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng),
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 30 |         match *self {
[INFO] [stderr] 31 |             Material::Lambertian {albedo } => return Material::scatter_lambertian(hit_point, hit_normal, albedo, rng),
[INFO] [stderr] 32 |             Material::Metal { albedo, fuzz } => return Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng),
[INFO] [stderr] 33 |             Material::Dielectric { refraction_index } => return Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/material.rs:74:17
[INFO] [stderr]    |
[INFO] [stderr] 74 | /                 let scattered;
[INFO] [stderr] 75 | |                 if rng.gen::<f32>() < Material::schlick(cosine, ref_idx) {
[INFO] [stderr] 76 | |                     scattered = Ray::new(hit_point, Material::reflect(ray_in.direction, hit_normal));
[INFO] [stderr] 77 | |                 }
[INFO] [stderr] 78 | |                 else {
[INFO] [stderr] 79 | |                     scattered = Ray::new(hit_point, refracted);
[INFO] [stderr] 80 | |                 }
[INFO] [stderr]    | |_________________^ help: it is more idiomatic to write: `let scattered = if rng.gen::<f32>() < Material::schlick(cosine, ref_idx) { Ray::new(hit_point, Material::reflect(ray_in.direction, hit_normal)) } else { Ray::new(hit_point, refracted) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/material.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 | /         match self {
[INFO] [stderr] 31 | |             &Material::Lambertian {albedo } => return Material::scatter_lambertian(hit_point, hit_normal, albedo, rng),
[INFO] [stderr] 32 | |             &Material::Metal { albedo, fuzz } => return Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng),
[INFO] [stderr] 33 | |             &Material::Dielectric { refraction_index } => return Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng),
[INFO] [stderr] 34 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 30 |         match *self {
[INFO] [stderr] 31 |             Material::Lambertian {albedo } => return Material::scatter_lambertian(hit_point, hit_normal, albedo, rng),
[INFO] [stderr] 32 |             Material::Metal { albedo, fuzz } => return Material::scatter_metal(&ray_in, hit_point, hit_normal, albedo, fuzz, rng),
[INFO] [stderr] 33 |             Material::Dielectric { refraction_index } => return Material::scatter_dielectric(&ray_in, hit_point, hit_normal, refraction_index, rng),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/material.rs:74:17
[INFO] [stderr]    |
[INFO] [stderr] 74 | /                 let scattered;
[INFO] [stderr] 75 | |                 if rng.gen::<f32>() < Material::schlick(cosine, ref_idx) {
[INFO] [stderr] 76 | |                     scattered = Ray::new(hit_point, Material::reflect(ray_in.direction, hit_normal));
[INFO] [stderr] 77 | |                 }
[INFO] [stderr] 78 | |                 else {
[INFO] [stderr] 79 | |                     scattered = Ray::new(hit_point, refracted);
[INFO] [stderr] 80 | |                 }
[INFO] [stderr]    | |_________________^ help: it is more idiomatic to write: `let scattered = if rng.gen::<f32>() < Material::schlick(cosine, ref_idx) { Ray::new(hit_point, Material::reflect(ray_in.direction, hit_normal)) } else { Ray::new(hit_point, refracted) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.56s
[INFO] running `"docker" "inspect" "c4f8d234d482ca89d23067af8b4116894d7509e3160d77c420cf2125c2c7cd07"`
[INFO] running `"docker" "rm" "-f" "c4f8d234d482ca89d23067af8b4116894d7509e3160d77c420cf2125c2c7cd07"`
[INFO] [stdout] c4f8d234d482ca89d23067af8b4116894d7509e3160d77c420cf2125c2c7cd07