[INFO] updating cached repository idanarye/rust-inherent-pub [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/idanarye/rust-inherent-pub [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/idanarye/rust-inherent-pub" "work/ex/clippy-test-run/sources/stable/gh/idanarye/rust-inherent-pub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/idanarye/rust-inherent-pub'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/idanarye/rust-inherent-pub" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/idanarye/rust-inherent-pub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/idanarye/rust-inherent-pub'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0913ef8fe8d2fbcacb92f6cb1dc07f1d9305b700 [INFO] sha for GitHub repo idanarye/rust-inherent-pub: 0913ef8fe8d2fbcacb92f6cb1dc07f1d9305b700 [INFO] validating manifest of idanarye/rust-inherent-pub on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of idanarye/rust-inherent-pub on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing idanarye/rust-inherent-pub [INFO] finished frobbing idanarye/rust-inherent-pub [INFO] frobbed toml for idanarye/rust-inherent-pub written to work/ex/clippy-test-run/sources/stable/gh/idanarye/rust-inherent-pub/Cargo.toml [INFO] started frobbing idanarye/rust-inherent-pub [INFO] finished frobbing idanarye/rust-inherent-pub [INFO] frobbed toml for idanarye/rust-inherent-pub written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/idanarye/rust-inherent-pub/Cargo.toml [INFO] crate idanarye/rust-inherent-pub has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting idanarye/rust-inherent-pub against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/idanarye/rust-inherent-pub:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e51923b130988cfef63f4f41c363b8a68b1a04bf978cfde78f65253c5cfb184a [INFO] running `"docker" "start" "-a" "e51923b130988cfef63f4f41c363b8a68b1a04bf978cfde78f65253c5cfb184a"` [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Checking quote v0.6.9 [INFO] [stderr] Checking syn v0.15.15 [INFO] [stderr] Checking inherent-pub v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:126:99 [INFO] [stderr] | [INFO] [stderr] 126 | FnArg::Captured(ArgCaptured { pat: Pat::Ident(pat_ident), .. }) if args.is_empty() && pat_ident.ident.to_string() == "self" => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*pat_ident.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:126:99 [INFO] [stderr] | [INFO] [stderr] 126 | FnArg::Captured(ArgCaptured { pat: Pat::Ident(pat_ident), .. }) if args.is_empty() && pat_ident.ident.to_string() == "self" => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*pat_ident.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> examples/example.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | assert!(geometry::Vector(3.0, 4.0).length() == 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(geometry::Vector(3.0, 4.0).length() - 5.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> examples/example.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | assert!(geometry::Vector(3.0, 4.0).length() == 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `inherent-pub`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/self_arg_flavors.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | let bar = my_module::Bar(41); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/self_arg_flavors.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | let bar = bar.foo(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/self_arg_flavors.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | let mut bar = my_module::Bar(41); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "e51923b130988cfef63f4f41c363b8a68b1a04bf978cfde78f65253c5cfb184a"` [INFO] running `"docker" "rm" "-f" "e51923b130988cfef63f4f41c363b8a68b1a04bf978cfde78f65253c5cfb184a"` [INFO] [stdout] e51923b130988cfef63f4f41c363b8a68b1a04bf978cfde78f65253c5cfb184a